user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove a single allocation on doc lints (#16314)

Browse source 
Extremely small change, -0.018% performance improvement on `tokio`
Just some warmup for continuing on larger optimizations (i.e.
`nonminimal_bool`)

changelog:Remove allocations via String pre-allocating.
This commit is contained in:
llogiq 2025-12-30 13:23:49 +00:00 • committed by GitHub
commit bddcea71d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/doc/mod.rs
View file

@ -869,10 +869,12 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
}),
true,
);
let mut doc = fragments.iter().fold(String::new(), |mut acc, fragment| {
add_doc_fragment(&mut acc, fragment);
acc
});
let mut doc = String::with_capacity(fragments.iter().map(|frag| frag.doc.as_str().len() + 1).sum());
for fragment in &fragments {
add_doc_fragment(&mut doc, fragment);
}
doc.pop();
if doc.trim().is_empty() {