user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: not suggest seek_to_start_instead_of_rewind when expr is used

Browse source
This commit is contained in:
feniljain 2022-12-17 17:24:03 +05:30
parent 3b67e6af9e
commit c39849a34d
4 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/methods/seek_to_start_instead_of_rewind.rs
View file

@ -1,6 +1,6 @@
use clippy_utils::diagnostics::span_lint_and_then;
use clippy_utils::ty::implements_trait;
use clippy_utils::{get_trait_def_id, match_def_path, paths};
use clippy_utils::{get_trait_def_id, is_expr_used_or_unified, match_def_path, paths};
use rustc_ast::ast::{LitIntType, LitKind};
use rustc_errors::Applicability;
use rustc_hir::{Expr, ExprKind};
@ -19,6 +19,10 @@ pub(super) fn check<'tcx>(
// Get receiver type
let ty = cx.typeck_results().expr_ty(recv).peel_refs();
if is_expr_used_or_unified(cx.tcx, expr) {
return;
}
if let Some(seek_trait_id) = get_trait_def_id(cx, &paths::STD_IO_SEEK) &&
implements_trait(cx, ty, seek_trait_id, &[]) &&
let ExprKind::Call(func, args1) = arg.kind &&