user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: not suggest seek_to_start_instead_of_rewind when expr is used

Browse source
This commit is contained in:
feniljain 2022-12-17 17:24:03 +05:30
parent 3b67e6af9e
commit c39849a34d
4 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/ui/seek_to_start_instead_of_rewind.fixed
View file

@ -70,6 +70,12 @@ fn seek_to_end<T: Seek>(t: &mut T) {
t.seek(SeekFrom::End(0));
}
// This should NOT trigger clippy warning because
// expr is used here
fn seek_to_start_in_let<T: Seek>(t: &mut T) {
let a = t.seek(SeekFrom::Start(0)).unwrap();
}
fn main() {
let mut f = OpenOptions::new()
.write(true)

6
tests/ui/seek_to_start_instead_of_rewind.rs
View file

@ -70,6 +70,12 @@ fn seek_to_end<T: Seek>(t: &mut T) {
t.seek(SeekFrom::End(0));
}
// This should NOT trigger clippy warning because
// expr is used here
fn seek_to_start_in_let<T: Seek>(t: &mut T) {
let a = t.seek(SeekFrom::Start(0)).unwrap();
}
fn main() {
let mut f = OpenOptions::new()
.write(true)

2
tests/ui/seek_to_start_instead_of_rewind.stderr
View file

@ -13,7 +13,7 @@ LL | t.seek(SeekFrom::Start(0));
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
error: used `seek` to go to the start of the stream
--> $DIR/seek_to_start_instead_of_rewind.rs:128:7
--> $DIR/seek_to_start_instead_of_rewind.rs:134:7
|
LL | f.seek(SeekFrom::Start(0));
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`