user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removing lint for constant usize array indexing

Browse source 
This commit removes the logic in this PR that linted out-of-bounds constant `usize` indexing on arrays. That case is already handled by rustc's `const_err` lint. Beyond removing the linting logic, the test file and its associated stderr were updated to verify that const `usize` indexing operations on arrays are no longer handled by this `indexing_slicing` lint.
This commit is contained in:
Shea Newton 2018-06-19 21:30:43 +00:00
parent e63f5dfedb
commit c479b3bc28
No known key found for this signature in database
GPG key ID: 17EB9122DC958643
3 changed files with 13 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/ui/indexing_slicing.rs
View file

@ -13,8 +13,8 @@ fn main() {
&x[..index];
&x[index_from..index_to];
&x[index_from..][..index_to]; // Two lint reports, one for [index_from..] and another for [..index_to].
x[4];
x[1 << 3];
x[4]; // Ok, let rustc's `const_err` lint handle `usize` indexing on arrays.
x[1 << 3]; // Ok, let rustc's `const_err` lint handle `usize` indexing on arrays.
&x[..=4];
&x[1..5];
&x[5..][..10]; // Two lint reports, one for [5..] and another for [..10].
@ -44,7 +44,7 @@ fn main() {
&y[..]; // Ok, should not produce stderr.
let empty: [i8; 0] = [];
empty[0];
empty[0]; // Ok, let rustc's `const_err` lint handle `usize` indexing on arrays.
&empty[1..5];
&empty[0..=4];
&empty[..=4];
@ -75,7 +75,7 @@ fn main() {
const N: usize = 15; // Out of bounds
const M: usize = 3; // In bounds
x[N];
x[N]; // Ok, let rustc's `const_err` lint handle `usize` indexing on arrays.
x[M]; // Ok, should not produce stderr.
v[N];
v[M];

30
tests/ui/indexing_slicing.stderr
View file

@ -47,25 +47,13 @@ error: slicing may panic.
|
= help: Consider using `.get(n..)` or .get_mut(n..)` instead
error: const index is out of bounds
--> $DIR/indexing_slicing.rs:16:5
|
16 | x[4];
| ^^^^
|
= note: `-D out-of-bounds-indexing` implied by `-D warnings`
error: const index is out of bounds
--> $DIR/indexing_slicing.rs:17:5
|
17 | x[1 << 3];
| ^^^^^^^^^
error: range is out of bounds
--> $DIR/indexing_slicing.rs:18:6
|
18 | &x[..=4];
| ^^^^^^^
|
= note: `-D out-of-bounds-indexing` implied by `-D warnings`
error: range is out of bounds
--> $DIR/indexing_slicing.rs:19:6
@ -159,12 +147,6 @@ error: slicing may panic.
|
= help: Consider using `.get(..n)`or `.get_mut(..n)` instead
error: const index is out of bounds
--> $DIR/indexing_slicing.rs:47:5
|
47 | empty[0];
| ^^^^^^^^
error: range is out of bounds
--> $DIR/indexing_slicing.rs:48:6
|
@ -269,12 +251,6 @@ error: slicing may panic.
|
= help: Consider using `.get(..n)`or `.get_mut(..n)` instead
error: const index is out of bounds
--> $DIR/indexing_slicing.rs:78:5
|
78 | x[N];
| ^^^^
error: indexing may panic.
--> $DIR/indexing_slicing.rs:80:5
|
@ -291,5 +267,5 @@ error: indexing may panic.
|
= help: Consider using `.get(n)` or `.get_mut(n)` instead
error: aborting due to 41 previous errors
error: aborting due to 37 previous errors