user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[infinite_loops]: fix suggestion error on async functions/closures

Browse source
This commit is contained in:
J-ZhengLi 2024-10-26 17:18:02 +00:00
parent 9cf416dc6e
commit c4815aeef1
3 changed files with 95 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/ui/infinite_loops.rs
View file

@ -3,6 +3,7 @@
#![allow(clippy::never_loop)]
#![warn(clippy::infinite_loop)]
#![feature(async_closure)]
extern crate proc_macros;
use proc_macros::{external, with_span};
@ -428,4 +429,23 @@ fn continue_outer() {
}
}
// don't suggest adding `-> !` to async fn/closure that already returning `-> !`
mod issue_12338 {
use super::do_something;
async fn foo() -> ! {
loop {
do_something();
}
}
fn bar() {
let _ = async || -> ! {
loop {
do_something();
}
};
}
}
fn main() {}

42
tests/ui/infinite_loops.stderr
View file

@ -1,5 +1,5 @@
error: infinite loop detected
--> tests/ui/infinite_loops.rs:13:5
--> tests/ui/infinite_loops.rs:14:5
|
LL | / loop {
LL | |
@ -15,7 +15,7 @@ LL | fn no_break() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:20:5
--> tests/ui/infinite_loops.rs:21:5
|
LL | / loop {
LL | |
@ -32,7 +32,7 @@ LL | fn all_inf() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:22:9
--> tests/ui/infinite_loops.rs:23:9
|
LL | / loop {
LL | |
@ -49,7 +49,7 @@ LL | fn all_inf() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:24:13
--> tests/ui/infinite_loops.rs:25:13
|
LL | / loop {
LL | |
@ -63,7 +63,7 @@ LL | fn all_inf() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:38:5
--> tests/ui/infinite_loops.rs:39:5
|
LL | / loop {
LL | |
@ -74,7 +74,7 @@ LL | | }
= help: if this is not intended, try adding a `break` or `return` condition in the loop
error: infinite loop detected
--> tests/ui/infinite_loops.rs:51:5
--> tests/ui/infinite_loops.rs:52:5
|
LL | / loop {
LL | | fn inner_fn() -> ! {
@ -90,7 +90,7 @@ LL | fn no_break_never_ret_noise() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:94:5
--> tests/ui/infinite_loops.rs:95:5
|
LL | / loop {
LL | |
@ -107,7 +107,7 @@ LL | fn break_inner_but_not_outer_1(cond: bool) -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:105:5
--> tests/ui/infinite_loops.rs:106:5
|
LL | / loop {
LL | |
@ -124,7 +124,7 @@ LL | fn break_inner_but_not_outer_2(cond: bool) -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:119:9
--> tests/ui/infinite_loops.rs:120:9
|
LL | / loop {
LL | |
@ -138,7 +138,7 @@ LL | fn break_outer_but_not_inner() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:142:9
--> tests/ui/infinite_loops.rs:143:9
|
LL | / loop {
LL | |
@ -155,7 +155,7 @@ LL | fn break_wrong_loop(cond: bool) -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:182:5
--> tests/ui/infinite_loops.rs:183:5
|
LL | / loop {
LL | |
@ -172,7 +172,7 @@ LL | fn match_like() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:223:5
--> tests/ui/infinite_loops.rs:224:5
|
LL | / loop {
LL | |
@ -186,7 +186,7 @@ LL | fn match_like() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:228:5
--> tests/ui/infinite_loops.rs:229:5
|
LL | / loop {
LL | |
@ -203,7 +203,7 @@ LL | fn match_like() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:333:9
--> tests/ui/infinite_loops.rs:334:9
|
LL | / loop {
LL | |
@ -217,7 +217,7 @@ LL | fn problematic_trait_method() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:343:9
--> tests/ui/infinite_loops.rs:344:9
|
LL | / loop {
LL | |
@ -231,7 +231,7 @@ LL | fn could_be_problematic() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:352:9
--> tests/ui/infinite_loops.rs:353:9
|
LL | / loop {
LL | |
@ -245,7 +245,7 @@ LL | let _loop_forever = || -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:366:8
--> tests/ui/infinite_loops.rs:367:8
|
LL | Ok(loop {
| ________^
@ -256,7 +256,7 @@ LL | | })
= help: if this is not intended, try adding a `break` or `return` condition in the loop
error: infinite loop detected
--> tests/ui/infinite_loops.rs:408:5
--> tests/ui/infinite_loops.rs:409:5
|
LL | / 'infinite: loop {
LL | |
@ -272,7 +272,7 @@ LL | fn continue_outer() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:415:5
--> tests/ui/infinite_loops.rs:416:5
|
LL | / loop {
LL | |
@ -289,7 +289,7 @@ LL | fn continue_outer() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:417:9
--> tests/ui/infinite_loops.rs:418:9
|
LL | / 'inner: loop {
LL | | loop {
@ -304,7 +304,7 @@ LL | fn continue_outer() -> ! {
| ++++
error: infinite loop detected
--> tests/ui/infinite_loops.rs:425:5
--> tests/ui/infinite_loops.rs:426:5
|
LL | / loop {
LL | |