From c94bf8bb680e0d6281822d289587d669e9374372 Mon Sep 17 00:00:00 2001 From: Vinzent Steinberg Date: Wed, 20 Aug 2014 23:36:07 -0400 Subject: [PATCH] bitv: make benchmarks always return a value This makes sure that the benchmarked code does not get optimized away. Also fixed a typo. Fixes #12118. --- src/libcollections/bitv.rs | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/libcollections/bitv.rs b/src/libcollections/bitv.rs index b028ac0bbd79..cb4e3c82be5c 100644 --- a/src/libcollections/bitv.rs +++ b/src/libcollections/bitv.rs @@ -2616,18 +2616,19 @@ mod tests { let mut b1 = Bitv::with_capacity(BENCH_BITS, false); let b2 = Bitv::with_capacity(BENCH_BITS, false); b.iter(|| { - b1.union(&b2); + b1.union(&b2) }) } #[bench] - fn bench_btv_small_iter(b: &mut Bencher) { + fn bench_bitv_small_iter(b: &mut Bencher) { let bitv = Bitv::with_capacity(uint::BITS, false); b.iter(|| { - let mut _sum = 0; + let mut sum = 0; for pres in bitv.iter() { - _sum += pres as uint; + sum += pres as uint; } + sum }) } @@ -2635,10 +2636,11 @@ mod tests { fn bench_bitv_big_iter(b: &mut Bencher) { let bitv = Bitv::with_capacity(BENCH_BITS, false); b.iter(|| { - let mut _sum = 0; + let mut sum = 0; for pres in bitv.iter() { - _sum += pres as uint; + sum += pres as uint; } + sum }) } @@ -2647,10 +2649,11 @@ mod tests { let bitv = BitvSet::from_bitv(from_fn(BENCH_BITS, |idx| {idx % 3 == 0})); b.iter(|| { - let mut _sum = 0; + let mut sum = 0; for idx in bitv.iter() { - _sum += idx; + sum += idx; } + sum }) } }