librustc: Forbid transmute from being called on types whose size is
only known post-monomorphization, and report `transmute` errors before
the code is generated for that `transmute`.
This can break code that looked like:
unsafe fn f<T>(x: T) {
let y: int = transmute(x);
}
Change such code to take a type parameter that has the same size as the
type being transmuted to.
Closes #12898.
[breaking-change]
This commit is contained in:
parent
8c4a10a159
commit
c9f3f47702
13 changed files with 323 additions and 31 deletions
27
src/test/compile-fail/transmute-different-sizes.rs
Normal file
27
src/test/compile-fail/transmute-different-sizes.rs
Normal file
|
|
@ -0,0 +1,27 @@
|
|||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
// Tests that `transmute` cannot be called on types of different size.
|
||||
|
||||
use std::mem::transmute;
|
||||
|
||||
unsafe fn f() {
|
||||
let _: i8 = transmute(16i16);
|
||||
//~^ ERROR transmute called on types with different sizes
|
||||
}
|
||||
|
||||
unsafe fn g<T>(x: &T) {
|
||||
let _: i8 = transmute(x);
|
||||
//~^ ERROR transmute called on types with different sizes
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
|
||||
|
||||
48
src/test/compile-fail/transmute-type-parameters.rs
Normal file
48
src/test/compile-fail/transmute-type-parameters.rs
Normal file
|
|
@ -0,0 +1,48 @@
|
|||
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
// Tests that `transmute` cannot be called on type parameters.
|
||||
|
||||
use std::mem::transmute;
|
||||
|
||||
unsafe fn f<T>(x: T) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
unsafe fn g<T>(x: (T, int)) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
unsafe fn h<T>(x: [T, ..10]) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
struct Bad<T> {
|
||||
f: T,
|
||||
}
|
||||
|
||||
unsafe fn i<T>(x: Bad<T>) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
enum Worse<T> {
|
||||
A(T),
|
||||
B,
|
||||
}
|
||||
|
||||
unsafe fn j<T>(x: Worse<T>) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
unsafe fn k<T>(x: Option<T>) {
|
||||
let _: int = transmute(x); //~ ERROR cannot transmute
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
Loading…
Add table
Add a link
Reference in a new issue