From cb6451c5afb081c626238172b9ae67e65709cdf0 Mon Sep 17 00:00:00 2001 From: Corey Richardson Date: Mon, 30 Dec 2013 17:07:19 -0500 Subject: [PATCH] Remove a fixme I don't think it's relevant, a warning is more appropriate. Easier to just maintain the order. Closes #4681 --- src/libextra/getopts.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libextra/getopts.rs b/src/libextra/getopts.rs index 5debc9991928..78baa4f7ec8b 100644 --- a/src/libextra/getopts.rs +++ b/src/libextra/getopts.rs @@ -1522,6 +1522,9 @@ mod tests { optmulti("l") ]; + // short and verbose should always be in the same order. if they + // aren't the test will fail (and in mysterious ways) + let verbose = ~[ groups::reqopt("b", "banana", "Desc", "VAL"), groups::optopt("a", "apple", "Desc", "VAL"), @@ -1533,7 +1536,6 @@ mod tests { let sample_args = ~[~"--kiwi", ~"15", ~"--apple", ~"1", ~"k", ~"-p", ~"16", ~"l", ~"35"]; - // FIXME #4681: sort options here? assert!(getopts(sample_args, short) == groups::getopts(sample_args, verbose)); }