user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct unused field warning on &struct match

Browse source
This commit is contained in:
varkor 2018-04-30 00:40:11 +01:00
parent a9975254ee
commit cc53db8bf9
3 changed files with 41 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/test/ui/lint/issue-47390-unused-variable-in-struct-pattern.rs
View file

@ -18,6 +18,10 @@ struct SoulHistory {
endless_and_singing: bool
}
enum Large {
Suit { case: () }
}
fn main() {
let i_think_continually = 2;
let who_from_the_womb_remembered = SoulHistory {
@ -31,4 +35,12 @@ fn main() {
endless_and_singing: true } = who_from_the_womb_remembered {
hours_are_suns = false;
}
let bag = &Large::Suit {
case: ()
};
match bag {
&Large::Suit { case } => {}
};
}

14
src/test/ui/lint/issue-47390-unused-variable-in-struct-pattern.stderr
View file

@ -1,5 +1,5 @@
warning: unused variable: `i_think_continually`
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:22:9
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:26:9
|
LL | let i_think_continually = 2;
| ^^^^^^^^^^^^^^^^^^^ help: consider using `_i_think_continually` instead
@ -12,13 +12,13 @@ LL | #![warn(unused)] // UI tests pass `-A unused` (#43896)
= note: #[warn(unused_variables)] implied by #[warn(unused)]
warning: unused variable: `corridors_of_light`
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:29:26
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:33:26
|
LL | if let SoulHistory { corridors_of_light,
| ^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `corridors_of_light: _`
warning: variable `hours_are_suns` is assigned to, but never used
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:30:26
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:34:26
|
LL | mut hours_are_suns,
| ^^^^^^^^^^^^^^^^^^
@ -26,7 +26,7 @@ LL | mut hours_are_suns,
= note: consider using `_hours_are_suns` instead
warning: value assigned to `hours_are_suns` is never read
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:32:9
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:36:9
|
LL | hours_are_suns = false;
| ^^^^^^^^^^^^^^
@ -38,3 +38,9 @@ LL | #![warn(unused)] // UI tests pass `-A unused` (#43896)
| ^^^^^^
= note: #[warn(unused_assignments)] implied by #[warn(unused)]
warning: unused variable: `case`
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:44:24
|
LL | &Large::Suit { case } => {}
| ^^^^ help: try ignoring the field: `case: _`