user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed all instances of XXX in preparation for relaxing of FIXME rule

Browse source
This commit is contained in:
Salem Talha 2014-01-26 03:43:42 -05:00
parent 838b5a4cc0
commit cc61fc0994
72 changed files with 119 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/libnative/io/file.rs
View file

@ -674,7 +674,7 @@ pub fn chown(p: &CString, uid: int, gid: int) -> IoResult<()> {
pub fn readlink(p: &CString) -> IoResult<Path> {
return os_readlink(p);
// XXX: I have a feeling that this reads intermediate symlinks as well.
// FIXME: I have a feeling that this reads intermediate symlinks as well.
#[cfg(windows)]
fn os_readlink(p: &CString) -> IoResult<Path> {
let handle = unsafe {
@ -709,7 +709,7 @@ pub fn readlink(p: &CString) -> IoResult<Path> {
let p = p.with_ref(|p| p);
let mut len = unsafe { libc::pathconf(p, libc::_PC_NAME_MAX) };
if len == -1 {
len = 1024; // XXX: read PATH_MAX from C ffi?
len = 1024; // FIXME: read PATH_MAX from C ffi?
}
let mut buf = vec::with_capacity::<u8>(len as uint);
match retry(|| unsafe {
@ -877,7 +877,7 @@ pub fn stat(p: &CString) -> IoResult<io::FileStat> {
pub fn lstat(p: &CString) -> IoResult<io::FileStat> {
return os_lstat(p);
// XXX: windows implementation is missing
// FIXME: windows implementation is missing
#[cfg(windows)]
fn os_lstat(_p: &CString) -> IoResult<io::FileStat> {
Err(super::unimpl())

2
src/libnative/io/mod.rs
View file

@ -97,7 +97,7 @@ fn translate_error(errno: i32, detail: bool) -> IoError {
#[cfg(not(windows))]
fn get_err(errno: i32) -> (io::IoErrorKind, &'static str) {
// XXX: this should probably be a bit more descriptive...
// FIXME: this should probably be a bit more descriptive...
match errno {
libc::EOF => (io::EndOfFile, "end of file"),
libc::ECONNREFUSED => (io::ConnectionRefused, "connection refused"),

2
src/libnative/io/timer_timerfd.rs
View file

@ -104,7 +104,7 @@ fn helper(input: libc::c_int, messages: Port<Req>) {
let mut bits = [0, ..8];
// drain the timerfd of how many times its fired
//
// XXX: should this perform a send() this number of
// FIXME: should this perform a send() this number of
// times?
FileDesc::new(fd, false).inner_read(bits);
let remove = {