Removed all instances of XXX in preparation for relaxing of FIXME rule
This commit is contained in:
parent
838b5a4cc0
commit
cc61fc0994
72 changed files with 119 additions and 119 deletions
|
|
@ -259,7 +259,7 @@ impl Drop for Request {
|
|||
}
|
||||
}
|
||||
|
||||
/// XXX: Loop(*handle) is buggy with destructors. Normal structs
|
||||
/// FIXME: Loop(*handle) is buggy with destructors. Normal structs
|
||||
/// with dtors may not be destructured, but tuple structs can,
|
||||
/// but the results are not correct.
|
||||
pub struct Loop {
|
||||
|
|
@ -284,7 +284,7 @@ impl Loop {
|
|||
}
|
||||
}
|
||||
|
||||
// XXX: Need to define the error constants like EOF so they can be
|
||||
// FIXME: Need to define the error constants like EOF so they can be
|
||||
// compared to the UvError type
|
||||
|
||||
pub struct UvError(c_int);
|
||||
|
|
@ -349,7 +349,7 @@ pub fn uv_error_to_io_error(uverr: UvError) -> IoError {
|
|||
uvll::EADDRNOTAVAIL => io::ConnectionRefused,
|
||||
err => {
|
||||
uvdebug!("uverr.code {}", err as int);
|
||||
// XXX: Need to map remaining uv error types
|
||||
// FIXME: Need to map remaining uv error types
|
||||
io::OtherIoError
|
||||
}
|
||||
};
|
||||
|
|
|
|||
|
|
@ -343,7 +343,7 @@ impl rtio::RtioTcpListener for TcpListener {
|
|||
let mut acceptor = ~TcpAcceptor { listener: self };
|
||||
|
||||
let _m = acceptor.fire_homing_missile();
|
||||
// XXX: the 128 backlog should be configurable
|
||||
// FIXME: the 128 backlog should be configurable
|
||||
match unsafe { uvll::uv_listen(acceptor.listener.handle, 128, listen_cb) } {
|
||||
0 => Ok(acceptor as ~rtio::RtioTcpAcceptor),
|
||||
n => Err(uv_error_to_io_error(UvError(n))),
|
||||
|
|
|
|||
|
|
@ -179,7 +179,7 @@ impl RtioUnixListener for PipeListener {
|
|||
let mut acceptor = ~PipeAcceptor { listener: self };
|
||||
|
||||
let _m = acceptor.fire_homing_missile();
|
||||
// XXX: the 128 backlog should be configurable
|
||||
// FIXME: the 128 backlog should be configurable
|
||||
match unsafe { uvll::uv_listen(acceptor.listener.pipe, 128, listen_cb) } {
|
||||
0 => Ok(acceptor as ~RtioUnixAcceptor),
|
||||
n => Err(uv_error_to_io_error(UvError(n))),
|
||||
|
|
|
|||
|
|
@ -157,7 +157,7 @@ extern fn read_cb(handle: *uvll::uv_stream_t, nread: ssize_t, _buf: *Buf) {
|
|||
};
|
||||
// Stop reading so that no read callbacks are
|
||||
// triggered before the user calls `read` again.
|
||||
// XXX: Is there a performance impact to calling
|
||||
// FIXME: Is there a performance impact to calling
|
||||
// stop here?
|
||||
unsafe { assert_eq!(uvll::uv_read_stop(handle), 0); }
|
||||
rcx.result = nread;
|
||||
|
|
|
|||
|
|
@ -361,7 +361,7 @@ fn request_sanity_check() {
|
|||
}
|
||||
}
|
||||
|
||||
// XXX Event loops ignore SIGPIPE by default.
|
||||
// FIXME Event loops ignore SIGPIPE by default.
|
||||
pub unsafe fn loop_new() -> *c_void {
|
||||
return rust_uv_loop_new();
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue