user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize broken_links by 99.77% (#15385)

Browse source 
We were calling an expensive functions lots of times resulting in 12
million instructions for `broken_links`, the doc lint optimization is
not over yet...

Now the instruction count for `broken_links` is at a healthy 27
thousand. This improvement is a difference of 1.5% in the total analysis
time for `tokio`.

changelog:[`broken_links`]: Optimize by 99.77%
This commit is contained in:
Samuel Tardieu 2025-08-02 07:30:04 +00:00 • committed by GitHub
commit cde155d1c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 38 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

76
clippy_lints/src/doc/broken_link.rs
View file

@ -19,52 +19,52 @@ pub fn check(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &str, fragm
}
fn warn_if_broken_link(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &str, fragments: &[DocFragment]) {
if let Some((span, _)) = source_span_for_markdown_range(cx.tcx, doc, &bl.span, fragments) {
let mut len = 0;
let mut len = 0;
// grab raw link data
let (_, raw_link) = doc.split_at(bl.span.start);
// grab raw link data
let (_, raw_link) = doc.split_at(bl.span.start);
// strip off link text part
let raw_link = match raw_link.split_once(']') {
None => return,
Some((prefix, suffix)) => {
len += prefix.len() + 1;
suffix
},
};
// strip off link text part
let raw_link = match raw_link.split_once(']') {
None => return,
Some((prefix, suffix)) => {
len += prefix.len() + 1;
suffix
},
};
let raw_link = match raw_link.split_once('(') {
None => return,
Some((prefix, suffix)) => {
if !prefix.is_empty() {
// there is text between ']' and '(' chars, so it is not a valid link
return;
}
len += prefix.len() + 1;
suffix
},
};
let raw_link = match raw_link.split_once('(') {
None => return,
Some((prefix, suffix)) => {
if !prefix.is_empty() {
// there is text between ']' and '(' chars, so it is not a valid link
return;
}
len += prefix.len() + 1;
suffix
},
};
if raw_link.starts_with("(http") {
// reduce chances of false positive reports
// by limiting this checking only to http/https links.
if raw_link.starts_with("(http") {
// reduce chances of false positive reports
// by limiting this checking only to http/https links.
return;
}
for c in raw_link.chars() {
if c == ')' {
// it is a valid link
return;
}
for c in raw_link.chars() {
if c == ')' {
// it is a valid link
return;
}
if c == '\n' {
report_broken_link(cx, span, len);
break;
}
len += 1;
if c == '\n'
&& let Some((span, _)) = source_span_for_markdown_range(cx.tcx, doc, &bl.span, fragments)
{
report_broken_link(cx, span, len);
break;
}
len += 1;
}
}