user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move transmute_int_to_bool to its own module

Browse source
This commit is contained in:
Yusuke Tanaka 2021-02-11 00:55:32 +09:00 • committed by flip1995
parent f8bc0e249c
commit d04ea41d1f
No known key found for this signature in database
GPG key ID: 1CA0DF2AF59D68A5
2 changed files with 47 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

23
clippy_lints/src/transmute/mod.rs
View file

@ -1,4 +1,5 @@
mod crosspointer_transmute;
mod transmute_int_to_bool;
mod transmute_int_to_char;
mod transmute_ptr_to_ptr;
mod transmute_ptr_to_ref;
@ -380,26 +381,12 @@ impl<'tcx> LateLintPass<'tcx> for Transmute {
if triggered {
return;
}
let triggered = transmute_int_to_bool::check(cx, e, from_ty, to_ty, args);
if triggered {
return;
}
match (&from_ty.kind(), &to_ty.kind()) {
(ty::Int(ty::IntTy::I8) | ty::Uint(ty::UintTy::U8), ty::Bool) => {
span_lint_and_then(
cx,
TRANSMUTE_INT_TO_BOOL,
e.span,
&format!("transmute from a `{}` to a `bool`", from_ty),
|diag| {
let arg = sugg::Sugg::hir(cx, &args[0], "..");
let zero = sugg::Sugg::NonParen(Cow::from("0"));
diag.span_suggestion(
e.span,
"consider using",
sugg::make_binop(ast::BinOpKind::Ne, &arg, &zero).to_string(),
Applicability::Unspecified,
);
},
)
},
(ty::Int(_) | ty::Uint(_), ty::Float(_)) if !const_context => span_lint_and_then(
cx,
TRANSMUTE_INT_TO_FLOAT,

42
clippy_lints/src/transmute/transmute_int_to_bool.rs Normal file
View file

@ -0,0 +1,42 @@
use super::TRANSMUTE_INT_TO_BOOL;
use crate::utils::{span_lint_and_then, sugg};
use rustc_ast as ast;
use rustc_errors::Applicability;
use rustc_hir::Expr;
use rustc_lint::LateContext;
use rustc_middle::ty;
use rustc_middle::ty::Ty;
use std::borrow::Cow;
/// Checks for `transmute_int_to_bool` lint.
/// Returns `true` if it's triggered, otherwise returns `false`.
pub(super) fn check<'tcx>(
cx: &LateContext<'tcx>,
e: &'tcx Expr<'_>,
from_ty: Ty<'tcx>,
to_ty: Ty<'tcx>,
args: &'tcx [Expr<'_>],
) -> bool {
match (&from_ty.kind(), &to_ty.kind()) {
(ty::Int(ty::IntTy::I8) | ty::Uint(ty::UintTy::U8), ty::Bool) => {
span_lint_and_then(
cx,
TRANSMUTE_INT_TO_BOOL,
e.span,
&format!("transmute from a `{}` to a `bool`", from_ty),
|diag| {
let arg = sugg::Sugg::hir(cx, &args[0], "..");
let zero = sugg::Sugg::NonParen(Cow::from("0"));
diag.span_suggestion(
e.span,
"consider using",
sugg::make_binop(ast::BinOpKind::Ne, &arg, &zero).to_string(),
Applicability::Unspecified,
);
},
);
true
},
_ => false,
}
}