user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #83152 - guswynn:jemallocator_part2, r=Mark-Simulacrum

Browse source 
Use tikv-jemallocator in rustc/rustdoc in addition to jemalloc-sys when enabled.

In https://github.com/rust-lang/rust/pull/81782 it was mentioned that one reason rustc may benefit from minimalloc is it doesn't use the `sdallocx` api from jemalloc.

Currently, on unix, rust uses jemalloc by importing its symbols to use them with the default, System (libc) global allocator.
This PR switches its global alloc to `tikv-jemallocator`, which correctly uses sized deallocation (https://docs.rs/tikv-jemallocator/0.4.1/src/tikv_jemallocator/lib.rs.html#121-126). `tikv-jemallocator`, as far as I can tell, is a more up-to-date set of bindings to jemalloc than `jemallocator`

The perf results of this pr are in large part due to the version upgrade of jemalloc, but sized deallocation has a non-trivial improvement, particularly to rustdoc.

This pr also includes changes to bootstrap to correctly pass the jemalloc feature through to the rustdoc build
This commit is contained in:
bors 2021-04-05 21:14:27 +00:00
commit d322385321
7 changed files with 107 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/tools/rustdoc/Cargo.toml
View file

@ -13,3 +13,6 @@ path = "main.rs"
[dependencies]
rustdoc = { path = "../../librustdoc" }
[features]
jemalloc = ['rustdoc/jemalloc']