user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Made parens addition smarter and added tests with bless

Browse source
This commit is contained in:
boolean_coercion 2021-02-13 00:33:08 +02:00
parent 642efabfbb
commit d36fe85569
3 changed files with 45 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
clippy_lints/src/from_str_radix_10.rs
View file

@ -5,6 +5,7 @@ use rustc_lint::{LateContext, LateLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
use crate::utils::span_lint_and_sugg;
use crate::utils::sugg::Sugg;
declare_clippy_lint! {
/// **What it does:**
@ -58,14 +59,20 @@ impl LateLintPass<'tcx> for FromStrRadix10 {
if let rustc_ast::ast::LitKind::Int(10, _) = lit.node;
then {
let orig_string = crate::utils::snippet(cx, arguments[0].span, "string");
let sugg = Sugg::hir_with_applicability(
cx,
&arguments[0],
"<string>",
&mut Applicability::MachineApplicable
).maybe_par();
span_lint_and_sugg(
cx,
FROM_STR_RADIX_10,
exp.span,
"this call to `from_str_radix` can be replaced with a call to `str::parse`",
"try",
format!("({}).parse()", orig_string),
format!("{}.parse::<{}>()", sugg, prim_ty.name_str()),
Applicability::MaybeIncorrect
);
}