user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #4071 - matthiaskrgr:sizeof, r=flip1995

Browse source 
trivially_copy_pass_by_ref: print size of type and limit in the lint message

changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message
This commit is contained in:
bors 2019-05-28 07:56:04 +00:00
commit d57845ffdf
5 changed files with 42 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/trivially_copy_pass_by_ref.rs
View file

@ -65,7 +65,7 @@ impl<'a, 'tcx> TriviallyCopyPassByRef {
// portability problems between 32 and 64-bit targets
let bit_width = cmp::min(bit_width, 32);
let byte_width = bit_width / 8;
// Use a limit of 2 times the register bit width
// Use a limit of 2 times the register byte width
byte_width * 2
});
Self { limit }
@ -118,7 +118,7 @@ impl<'a, 'tcx> TriviallyCopyPassByRef {
cx,
TRIVIALLY_COPY_PASS_BY_REF,
input.span,
"this argument is passed by reference, but would be more efficient if passed by value",
&format!("this argument ({} byte) is passed by reference, but would be more efficient if passed by value (limit: {} byte)", size, self.limit),
"consider passing by value instead",
value_type,
Applicability::Unspecified,