user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove rogue comma from infallible_try_from lint message (#15409)

Browse source 
Spotted while reading through the new lints in the changelog for Clippy
1.89:

```
 1 | error: infallible TryFrom impl; consider implementing From, instead
   |                                                           ^ this comma looks out of place
```

---

changelog: [`infallible_try_from`]: Fix a typo in the lint message
This commit is contained in:
Samuel Tardieu 2025-08-04 14:51:12 +00:00 • committed by GitHub
commit d6cf7b905f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/infallible_try_from.rs
View file

@ -71,7 +71,7 @@ impl<'tcx> LateLintPass<'tcx> for InfallibleTryFrom {
cx,
INFALLIBLE_TRY_FROM,
span,
"infallible TryFrom impl; consider implementing From, instead",
"infallible TryFrom impl; consider implementing From instead",
);
}
}

4
tests/ui/infallible_try_from.stderr
View file

@ -1,4 +1,4 @@
error: infallible TryFrom impl; consider implementing From, instead
error: infallible TryFrom impl; consider implementing From instead
--> tests/ui/infallible_try_from.rs:8:1
|
LL | impl TryFrom<i8> for MyStruct {
@ -10,7 +10,7 @@ LL | type Error = !;
= note: `-D clippy::infallible-try-from` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::infallible_try_from)]`
error: infallible TryFrom impl; consider implementing From, instead
error: infallible TryFrom impl; consider implementing From instead
--> tests/ui/infallible_try_from.rs:16:1
|
LL | impl TryFrom<i16> for MyStruct {