From d82eb887223582c0fd678ecfd2913ae48b90d452 Mon Sep 17 00:00:00 2001
From: Trevor Gross <tmgross@umich.edu>
Date: Sun, 6 Oct 2024 13:44:25 -0500
Subject: [PATCH] Fix shellcheck warnings in scripts

---
 .../compiler-builtins/libm/ci/run-docker.sh   | 24 +++++++++++--------
 library/compiler-builtins/libm/ci/run.sh      |  9 +++----
 2 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/library/compiler-builtins/libm/ci/run-docker.sh b/library/compiler-builtins/libm/ci/run-docker.sh
index 8d323634a67e..9191a17e2ba5 100755
--- a/library/compiler-builtins/libm/ci/run-docker.sh
+++ b/library/compiler-builtins/libm/ci/run-docker.sh
@@ -1,36 +1,40 @@
+#!/bin/bash
+
 # Small script to run tests for a target (or all targets) inside all the
 # respective docker images.
 
-set -ex
+set -euxo pipefail
 
 run() {
     local target=$1
 
-    echo $target
+    echo "testing target: $target"
 
     # This directory needs to exist before calling docker, otherwise docker will create it but it
     # will be owned by root
     mkdir -p target
 
-    docker build -t $target ci/docker/$target
+    docker build -t "$target" "ci/docker/$target"
     docker run \
            --rm \
-           --user $(id -u):$(id -g) \
+           --user "$(id -u):$(id -g)" \
            -e RUSTFLAGS \
            -e CARGO_HOME=/cargo \
            -e CARGO_TARGET_DIR=/target \
-           -v "${HOME}/.cargo":/cargo \
-           -v `pwd`/target:/target \
-           -v `pwd`:/checkout:ro \
-           -v `rustc --print sysroot`:/rust:ro \
+           -v "${HOME}/.cargo:/cargo" \
+           -v "$(pwd)/target:/target" \
+           -v "$(pwd):/checkout:ro" \
+           -v "$(rustc --print sysroot):/rust:ro" \
            --init \
            -w /checkout \
-           $target \
+           "$target" \
            sh -c "HOME=/tmp PATH=\$PATH:/rust/bin exec ci/run.sh $target"
 }
 
 if [ -z "$1" ]; then
-  for d in `ls ci/docker/`; do
+  echo "running tests for all targets"
+
+  for d in ci/docker/*; do
     run $d
   done
 else
diff --git a/library/compiler-builtins/libm/ci/run.sh b/library/compiler-builtins/libm/ci/run.sh
index b5d6e45f7108..1b016cc4fb2a 100755
--- a/library/compiler-builtins/libm/ci/run.sh
+++ b/library/compiler-builtins/libm/ci/run.sh
@@ -1,9 +1,10 @@
-#!/usr/bin/env sh
+#!/bin/sh
 
-set -ex
-TARGET=$1
+set -eux
 
-cmd="cargo test --all --target $TARGET"
+target="$1"
+
+cmd="cargo test --all --target $target"
 
 # Needed for no-panic to correct detect a lack of panics
 export RUSTFLAGS="$RUSTFLAGS -Ccodegen-units=1"