diff --git a/src/librustc/middle/trans/cleanup.rs b/src/librustc/middle/trans/cleanup.rs index 6e92ea9f11e5..299cf8f6aeeb 100644 --- a/src/librustc/middle/trans/cleanup.rs +++ b/src/librustc/middle/trans/cleanup.rs @@ -662,7 +662,7 @@ impl<'a> CleanupHelperMethods<'a> for FunctionContext<'a> { // Check if a landing pad block exists; if not, create one. { let mut scopes = self.scopes.borrow_mut(); - let last_scope = scopes.get().mut_last(); + let last_scope = scopes.get().mut_last().unwrap(); match last_scope.cached_landing_pad { Some(llbb) => { return llbb; } None => { diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs index 81e3e6c7eda5..0b9820e12ebc 100644 --- a/src/libstd/vec.rs +++ b/src/libstd/vec.rs @@ -2031,7 +2031,7 @@ pub trait MutableVector<'a, T> { fn mut_iter(self) -> MutItems<'a, T>; /// Returns a mutable pointer to the last item in the vector. - fn mut_last(self) -> &'a mut T; + fn mut_last(self) -> Option<&'a mut T>; /// Returns a reversed iterator that allows modifying each value fn mut_rev_iter(self) -> RevMutItems<'a, T>; @@ -2298,10 +2298,10 @@ impl<'a,T> MutableVector<'a, T> for &'a mut [T] { } #[inline] - fn mut_last(self) -> &'a mut T { + fn mut_last(self) -> Option<&'a mut T> { let len = self.len(); - if len == 0 { fail!("mut_last: empty vector") } - &mut self[len - 1] + if len == 0 { return None; } + Some(&mut self[len - 1]) } #[inline] @@ -4305,6 +4305,16 @@ mod tests { let mut y: &mut [int] = []; assert!(y.mut_pop_ref().is_none()); } + + #[test] + fn test_mut_last() { + let mut x = [1, 2, 3, 4, 5]; + let h = x.mut_last(); + assert_eq!(*h.unwrap(), 5); + + let mut y: &mut [int] = []; + assert!(y.mut_last().is_none()); + } } #[cfg(test)] diff --git a/src/libsyntax/opt_vec.rs b/src/libsyntax/opt_vec.rs index ce3042cb9cde..c575e170bef4 100644 --- a/src/libsyntax/opt_vec.rs +++ b/src/libsyntax/opt_vec.rs @@ -62,10 +62,10 @@ impl OptVec { } } - pub fn mut_last<'a>(&'a mut self) -> &'a mut T { + pub fn mut_last<'a>(&'a mut self) -> Option<&'a mut T> { match *self { Vec(ref mut v) => v.mut_last(), - Empty => fail!("mut_last on empty opt_vec") + Empty => None } }