From dc587cc46c363d6cc087d00719fa39773b6e9fab Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Mon, 29 Jan 2018 08:36:10 -0800 Subject: [PATCH] Comment that the rdtsc intrinsics should be ok Some more info should be in #308, and otherwise ... Closes #308 --- library/stdarch/stdsimd-verify/tests/x86-intel.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/library/stdarch/stdsimd-verify/tests/x86-intel.rs b/library/stdarch/stdsimd-verify/tests/x86-intel.rs index 4cfdbdcb240f..41d66c07c6b1 100644 --- a/library/stdarch/stdsimd-verify/tests/x86-intel.rs +++ b/library/stdarch/stdsimd-verify/tests/x86-intel.rs @@ -227,7 +227,10 @@ fn matches(rust: &Function, intel: &Intrinsic) -> Result<(), String> { continue; } - // FIXME(#308) + // these flags on the rdtsc/rtdscp intrinsics we don't test for right + // now, but we may wish to add these one day! + // + // For more info see #308 if *cpuid == "TSC" || *cpuid == "RDTSCP" { continue; } @@ -343,7 +346,9 @@ fn matches(rust: &Function, intel: &Intrinsic) -> Result<(), String> { "_mm256_setr_epi64x" | "_mm256_set1_epi64x" => true, - // FIXME(#308) + // These return a 64-bit argument but they're assembled from other + // 32-bit registers, so these work on 32-bit just fine. See #308 for + // more info. "_rdtsc" | "__rdtscp" => true,