From df2ddb75bf5131ee1d71dad7e7b09f2b06f2f24a Mon Sep 17 00:00:00 2001 From: Mark Rousskov Date: Sat, 8 Jul 2023 10:18:35 -0400 Subject: [PATCH] Downgrade addr2line This prevents #113238 from hitting stable while we sort out options for avoiding it. The downgrade is expected to not affect any users on stable, since it primarily affects tier 3 targets. --- Cargo.lock | 27 ++++++++++++------- library/std/Cargo.toml | 2 +- .../issue-71394-no-from-impl.stderr | 4 +-- 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index efd3d85f43eb..8b097249451d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2,16 +2,25 @@ # It is not intended for manual editing. version = 3 +[[package]] +name = "addr2line" +version = "0.18.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6ca9b76e919fd83ccfb509f51b28c333c0e03f2221616e347a129215cec4e4a9" +dependencies = [ + "compiler_builtins", + "gimli 0.26.2", + "rustc-std-workspace-alloc", + "rustc-std-workspace-core", +] + [[package]] name = "addr2line" version = "0.19.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "a76fd60b23679b7d19bd066031410fb7e458ccc5e958eb5c325888ce4baedc97" dependencies = [ - "compiler_builtins", "gimli 0.27.2", - "rustc-std-workspace-alloc", - "rustc-std-workspace-core", ] [[package]] @@ -228,7 +237,7 @@ version = "0.3.67" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "233d376d6d185f2a3093e58f283f60f880315b6c60075b01f36b3b85154564ca" dependencies = [ - "addr2line", + "addr2line 0.19.0", "cc", "cfg-if", "libc", @@ -1524,8 +1533,11 @@ version = "0.26.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "22030e2c5a68ec659fde1e949a745124b48e6fa8b045b7ed5bd1fe4ccc5c4e5d" dependencies = [ + "compiler_builtins", "fallible-iterator", "indexmap", + "rustc-std-workspace-alloc", + "rustc-std-workspace-core", "stable_deref_trait", ] @@ -1534,11 +1546,6 @@ name = "gimli" version = "0.27.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "ad0a93d233ebf96623465aad4046a8d3aa4da22d4f4beba5388838c8a434bbb4" -dependencies = [ - "compiler_builtins", - "rustc-std-workspace-alloc", - "rustc-std-workspace-core", -] [[package]] name = "glob" @@ -4718,7 +4725,7 @@ checksum = "a2eb9349b6444b326872e140eb1cf5e7c522154d69e7a0ffb0fb81c06b37543f" name = "std" version = "0.0.0" dependencies = [ - "addr2line", + "addr2line 0.18.0", "alloc", "cfg-if", "compiler_builtins", diff --git a/library/std/Cargo.toml b/library/std/Cargo.toml index 824abc72a223..09afc696c33b 100644 --- a/library/std/Cargo.toml +++ b/library/std/Cargo.toml @@ -23,7 +23,7 @@ hashbrown = { version = "0.13", default-features = false, features = ['rustc-dep std_detect = { path = "../stdarch/crates/std_detect", default-features = false, features = ['rustc-dep-of-std'] } # Dependencies of the `backtrace` crate -addr2line = { version = "0.19.0", optional = true, default-features = false } +addr2line = { version = "0.18.0", optional = true, default-features = false } rustc-demangle = { version = "0.1.21", features = ['rustc-dep-of-std'] } miniz_oxide = { version = "0.6.0", optional = true, default-features = false } [dependencies.object] diff --git a/tests/ui/suggestions/issue-71394-no-from-impl.stderr b/tests/ui/suggestions/issue-71394-no-from-impl.stderr index ea57992b4832..2cd036d2b030 100644 --- a/tests/ui/suggestions/issue-71394-no-from-impl.stderr +++ b/tests/ui/suggestions/issue-71394-no-from-impl.stderr @@ -5,7 +5,6 @@ LL | let _: &[i8] = data.into(); | ^^^^ the trait `From<&[u8]>` is not implemented for `&[i8]` | = help: the following other types implement trait `From`: - <&'input [u8] as From>> <[T; 10] as From<(T, T, T, T, T, T, T, T, T, T)>> <[T; 11] as From<(T, T, T, T, T, T, T, T, T, T, T)>> <[T; 12] as From<(T, T, T, T, T, T, T, T, T, T, T, T)>> @@ -13,7 +12,8 @@ LL | let _: &[i8] = data.into(); <[T; 2] as From<(T, T)>> <[T; 3] as From<(T, T, T)>> <[T; 4] as From<(T, T, T, T)>> - and 7 others + <[T; 5] as From<(T, T, T, T, T)>> + and 6 others = note: required for `&[u8]` to implement `Into<&[i8]>` error: aborting due to previous error