diff --git a/src/doc/style/testing/unit.md b/src/doc/style/testing/unit.md index 813660d8fdfb..dbbe9fc3ac6d 100644 --- a/src/doc/style/testing/unit.md +++ b/src/doc/style/testing/unit.md @@ -1,10 +1,10 @@ % Unit testing -Unit tests should live in a `test` submodule at the bottom of the module they -test. Mark the `test` submodule with `#[cfg(test)]` so it is only compiled when +Unit tests should live in a `tests` submodule at the bottom of the module they +test. Mark the `tests` submodule with `#[cfg(test)]` so it is only compiled when testing. -The `test` module should contain: +The `tests` module should contain: * Imports needed only for testing. * Functions marked with `#[test]` striving for full coverage of the parent module's @@ -17,7 +17,7 @@ For example: // Excerpt from std::str #[cfg(test)] -mod test { +mod tests { #[test] fn test_eq() { assert!((eq(&"".to_owned(), &"".to_owned()))); diff --git a/src/doc/trpl/testing.md b/src/doc/trpl/testing.md index 8cf126cad95f..45f87a674059 100644 --- a/src/doc/trpl/testing.md +++ b/src/doc/trpl/testing.md @@ -219,10 +219,10 @@ fn it_works() { This is a very common use of `assert_eq!`: call some function with some known arguments and compare it to the expected output. -# The `test` module +# The `tests` module There is one way in which our existing example is not idiomatic: it's -missing the test module. The idiomatic way of writing our example +missing the `tests` module. The idiomatic way of writing our example looks like this: ```{rust,ignore} @@ -231,7 +231,7 @@ pub fn add_two(a: i32) -> i32 { } #[cfg(test)] -mod test { +mod tests { use super::add_two; #[test] @@ -241,7 +241,7 @@ mod test { } ``` -There's a few changes here. The first is the introduction of a `mod test` with +There's a few changes here. The first is the introduction of a `mod tests` with a `cfg` attribute. The module allows us to group all of our tests together, and to also define helper functions if needed, that don't become a part of the rest of our crate. The `cfg` attribute only compiles our test code if we're @@ -260,7 +260,7 @@ pub fn add_two(a: i32) -> i32 { } #[cfg(test)] -mod test { +mod tests { use super::*; #[test] @@ -279,7 +279,7 @@ $ cargo test Running target/adder-91b3e234d4ed382a running 1 test -test test::it_works ... ok +test tests::it_works ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured @@ -292,7 +292,7 @@ test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured It works! -The current convention is to use the `test` module to hold your "unit-style" +The current convention is to use the `tests` module to hold your "unit-style" tests. Anything that just tests one small bit of functionality makes sense to go here. But what about "integration-style" tests instead? For that, we have the `tests` directory @@ -325,7 +325,7 @@ $ cargo test Running target/adder-91b3e234d4ed382a running 1 test -test test::it_works ... ok +test tests::it_works ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured @@ -346,7 +346,7 @@ test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured Now we have three sections: our previous test is also run, as well as our new one. -That's all there is to the `tests` directory. The `test` module isn't needed +That's all there is to the `tests` directory. The `tests` module isn't needed here, since the whole thing is focused on tests. Let's finally check out that third section: documentation tests. @@ -382,7 +382,7 @@ pub fn add_two(a: i32) -> i32 { } #[cfg(test)] -mod test { +mod tests { use super::*; #[test] @@ -405,7 +405,7 @@ $ cargo test Running target/adder-91b3e234d4ed382a running 1 test -test test::it_works ... ok +test tests::it_works ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured diff --git a/src/liballoc/heap.rs b/src/liballoc/heap.rs index 4c7441b1d2a6..9d1d8a7ac24b 100644 --- a/src/liballoc/heap.rs +++ b/src/liballoc/heap.rs @@ -384,7 +384,7 @@ mod imp { } #[cfg(test)] -mod test { +mod tests { extern crate test; use self::test::Bencher; use boxed::Box; diff --git a/src/libcollections/linked_list.rs b/src/libcollections/linked_list.rs index deb1476c23f0..c73a6f9b324a 100644 --- a/src/libcollections/linked_list.rs +++ b/src/libcollections/linked_list.rs @@ -933,7 +933,7 @@ impl Hash for LinkedList { } #[cfg(test)] -mod test { +mod tests { use std::clone::Clone; use std::iter::{Iterator, IntoIterator}; use std::option::Option::{Some, None, self}; diff --git a/src/libcollections/vec_deque.rs b/src/libcollections/vec_deque.rs index bbe7830b4238..61369b30dea1 100644 --- a/src/libcollections/vec_deque.rs +++ b/src/libcollections/vec_deque.rs @@ -1772,7 +1772,7 @@ impl fmt::Debug for VecDeque { } #[cfg(test)] -mod test { +mod tests { use core::iter::{Iterator, self}; use core::option::Option::Some; diff --git a/src/libcoretest/num/mod.rs b/src/libcoretest/num/mod.rs index 85ca547da852..0ea9f8afb4e5 100644 --- a/src/libcoretest/num/mod.rs +++ b/src/libcoretest/num/mod.rs @@ -45,7 +45,7 @@ pub fn test_num(ten: T, two: T) where } #[cfg(test)] -mod test { +mod tests { use core::option::Option; use core::option::Option::{Some, None}; use core::num::Float; diff --git a/src/librand/chacha.rs b/src/librand/chacha.rs index 9cd3b74e1552..bcb827cb471c 100644 --- a/src/librand/chacha.rs +++ b/src/librand/chacha.rs @@ -202,7 +202,7 @@ impl Rand for ChaChaRng { #[cfg(test)] -mod test { +mod tests { use std::prelude::v1::*; use core::iter::order; diff --git a/src/librand/distributions/exponential.rs b/src/librand/distributions/exponential.rs index 5ba6d8912f26..f46d35a33db1 100644 --- a/src/librand/distributions/exponential.rs +++ b/src/librand/distributions/exponential.rs @@ -82,7 +82,7 @@ impl IndependentSample for Exp { } #[cfg(test)] -mod test { +mod tests { use std::prelude::v1::*; use distributions::{Sample, IndependentSample}; diff --git a/src/librand/distributions/gamma.rs b/src/librand/distributions/gamma.rs index f37093c6db85..2951563934b3 100644 --- a/src/librand/distributions/gamma.rs +++ b/src/librand/distributions/gamma.rs @@ -276,7 +276,7 @@ impl IndependentSample for StudentT { } #[cfg(test)] -mod test { +mod tests { use std::prelude::v1::*; use distributions::{Sample, IndependentSample}; diff --git a/src/librand/isaac.rs b/src/librand/isaac.rs index a7f7889783f7..22fe46a8bd83 100644 --- a/src/librand/isaac.rs +++ b/src/librand/isaac.rs @@ -510,7 +510,7 @@ impl Rand for Isaac64Rng { #[cfg(test)] -mod test { +mod tests { use std::prelude::v1::*; use core::iter::order; diff --git a/src/librand/reseeding.rs b/src/librand/reseeding.rs index ea084b2816dd..bb0b13c43756 100644 --- a/src/librand/reseeding.rs +++ b/src/librand/reseeding.rs @@ -120,7 +120,7 @@ impl Default for ReseedWithDefault { } #[cfg(test)] -mod test { +mod tests { use std::prelude::v1::*; use core::iter::{order, repeat}; diff --git a/src/librustc/session/config.rs b/src/librustc/session/config.rs index f4ea069447fd..050ccd647128 100644 --- a/src/librustc/session/config.rs +++ b/src/librustc/session/config.rs @@ -1111,7 +1111,7 @@ impl fmt::Display for CrateType { } #[cfg(test)] -mod test { +mod tests { use session::config::{build_configuration, optgroups, build_session_options}; use session::build_session; diff --git a/src/librustc_back/fs.rs b/src/librustc_back/fs.rs index 2ab4d7ff78a1..37e3efb4d83f 100644 --- a/src/librustc_back/fs.rs +++ b/src/librustc_back/fs.rs @@ -41,7 +41,7 @@ pub fn realpath(original: &Path) -> io::Result { } #[cfg(all(not(windows), test))] -mod test { +mod tests { use tempdir::TempDir; use std::fs::{self, File}; use super::realpath; diff --git a/src/librustc_back/rpath.rs b/src/librustc_back/rpath.rs index 58073079d31d..1daeb1cb223e 100644 --- a/src/librustc_back/rpath.rs +++ b/src/librustc_back/rpath.rs @@ -171,7 +171,7 @@ fn minimize_rpaths(rpaths: &[String]) -> Vec { } #[cfg(all(unix, test))] -mod test { +mod tests { use super::{RPathConfig}; use super::{minimize_rpaths, rpaths_to_flags, get_rpath_relative_to_output}; use std::path::{Path, PathBuf}; diff --git a/src/librustc_data_structures/graph/mod.rs b/src/librustc_data_structures/graph/mod.rs index 5741544fe541..17fd0b815362 100644 --- a/src/librustc_data_structures/graph/mod.rs +++ b/src/librustc_data_structures/graph/mod.rs @@ -36,7 +36,7 @@ use std::usize; use snapshot_vec::{SnapshotVec, SnapshotVecDelegate}; #[cfg(test)] -mod test; +mod tests; pub struct Graph { nodes: SnapshotVec> , diff --git a/src/librustc_data_structures/graph/test.rs b/src/librustc_data_structures/graph/tests.rs similarity index 100% rename from src/librustc_data_structures/graph/test.rs rename to src/librustc_data_structures/graph/tests.rs diff --git a/src/librustc_data_structures/unify/mod.rs b/src/librustc_data_structures/unify/mod.rs index 7036c010c658..a899bbacc030 100644 --- a/src/librustc_data_structures/unify/mod.rs +++ b/src/librustc_data_structures/unify/mod.rs @@ -14,7 +14,7 @@ use std::marker::PhantomData; use snapshot_vec as sv; #[cfg(test)] -mod test; +mod tests; /// This trait is implemented by any type that can serve as a type /// variable. We call such variables *unification keys*. For example, diff --git a/src/librustc_data_structures/unify/test.rs b/src/librustc_data_structures/unify/tests.rs similarity index 100% rename from src/librustc_data_structures/unify/test.rs rename to src/librustc_data_structures/unify/tests.rs diff --git a/src/librustdoc/html/toc.rs b/src/librustdoc/html/toc.rs index 78feb6c77c45..93aa74d7005f 100644 --- a/src/librustdoc/html/toc.rs +++ b/src/librustdoc/html/toc.rs @@ -198,7 +198,7 @@ impl fmt::Display for Toc { } #[cfg(test)] -mod test { +mod tests { use super::{TocBuilder, Toc, TocEntry}; #[test] diff --git a/src/libstd/dynamic_lib.rs b/src/libstd/dynamic_lib.rs index d0f990eaf782..ef72cbc96e18 100644 --- a/src/libstd/dynamic_lib.rs +++ b/src/libstd/dynamic_lib.rs @@ -117,7 +117,7 @@ impl DynamicLibrary { } #[cfg(all(test, not(target_os = "ios")))] -mod test { +mod tests { use super::*; use prelude::v1::*; use libc; diff --git a/src/libstd/io/stdio.rs b/src/libstd/io/stdio.rs index 42fad701533b..a9dab8191fd9 100644 --- a/src/libstd/io/stdio.rs +++ b/src/libstd/io/stdio.rs @@ -418,7 +418,7 @@ pub fn _print(args: fmt::Arguments) { } #[cfg(test)] -mod test { +mod tests { use thread; use super::*; diff --git a/src/libstd/io/util.rs b/src/libstd/io/util.rs index c82f9515e8d5..d797e757a483 100644 --- a/src/libstd/io/util.rs +++ b/src/libstd/io/util.rs @@ -102,7 +102,7 @@ impl Write for Sink { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use io::prelude::*; diff --git a/src/libstd/rand/os.rs b/src/libstd/rand/os.rs index 30d5ae5c6008..a04bb6705b32 100644 --- a/src/libstd/rand/os.rs +++ b/src/libstd/rand/os.rs @@ -346,7 +346,7 @@ mod imp { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sync::mpsc::channel; diff --git a/src/libstd/rand/reader.rs b/src/libstd/rand/reader.rs index 2837bac44569..d19bc5b617f8 100644 --- a/src/libstd/rand/reader.rs +++ b/src/libstd/rand/reader.rs @@ -63,7 +63,7 @@ impl Rng for ReaderRng { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use super::ReaderRng; diff --git a/src/libstd/rt/backtrace.rs b/src/libstd/rt/backtrace.rs index ced84d7551ee..72cbe2b533bb 100644 --- a/src/libstd/rt/backtrace.rs +++ b/src/libstd/rt/backtrace.rs @@ -38,7 +38,7 @@ pub fn log_enabled() -> bool { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sys_common; macro_rules! t { ($a:expr, $b:expr) => ({ diff --git a/src/libstd/sync/future.rs b/src/libstd/sync/future.rs index 2cdde1aca9e6..2d281eb4e249 100644 --- a/src/libstd/sync/future.rs +++ b/src/libstd/sync/future.rs @@ -155,7 +155,7 @@ impl Future { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sync::mpsc::channel; use sync::Future; diff --git a/src/libstd/sync/mpsc/mod.rs b/src/libstd/sync/mpsc/mod.rs index b3cc133d2294..74e85db1a06f 100644 --- a/src/libstd/sync/mpsc/mod.rs +++ b/src/libstd/sync/mpsc/mod.rs @@ -1065,7 +1065,7 @@ impl error::Error for TryRecvError { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use std::env; diff --git a/src/libstd/sync/mpsc/select.rs b/src/libstd/sync/mpsc/select.rs index b8ad92841f2d..58f16a83ba93 100644 --- a/src/libstd/sync/mpsc/select.rs +++ b/src/libstd/sync/mpsc/select.rs @@ -346,7 +346,7 @@ impl Iterator for Packets { #[cfg(test)] #[allow(unused_imports)] -mod test { +mod tests { use prelude::v1::*; use thread; diff --git a/src/libstd/sync/mpsc/spsc_queue.rs b/src/libstd/sync/mpsc/spsc_queue.rs index c75ac1308086..4dd84364fa80 100644 --- a/src/libstd/sync/mpsc/spsc_queue.rs +++ b/src/libstd/sync/mpsc/spsc_queue.rs @@ -241,7 +241,7 @@ impl Drop for Queue { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sync::Arc; diff --git a/src/libstd/sync/mutex.rs b/src/libstd/sync/mutex.rs index 5e688717c4a2..caf011c54f27 100644 --- a/src/libstd/sync/mutex.rs +++ b/src/libstd/sync/mutex.rs @@ -361,7 +361,7 @@ pub fn guard_poison<'a, T>(guard: &MutexGuard<'a, T>) -> &'a poison::Flag { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sync::mpsc::channel; diff --git a/src/libstd/sync/once.rs b/src/libstd/sync/once.rs index 948965f5efa9..2ce974c1271a 100644 --- a/src/libstd/sync/once.rs +++ b/src/libstd/sync/once.rs @@ -121,7 +121,7 @@ impl Once { } #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use thread; diff --git a/src/libstd/sys/common/remutex.rs b/src/libstd/sys/common/remutex.rs index b35063c0e234..00238500c3a8 100644 --- a/src/libstd/sys/common/remutex.rs +++ b/src/libstd/sys/common/remutex.rs @@ -151,7 +151,7 @@ impl<'a, T> Drop for ReentrantMutexGuard<'a, T> { #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use sys_common::remutex::{ReentrantMutex, ReentrantMutexGuard}; use cell::RefCell; diff --git a/src/libstd/thread/mod.rs b/src/libstd/thread/mod.rs index 28e4650478bb..9168a716d438 100644 --- a/src/libstd/thread/mod.rs +++ b/src/libstd/thread/mod.rs @@ -722,7 +722,7 @@ fn _assert_sync_and_send() { //////////////////////////////////////////////////////////////////////////////// #[cfg(test)] -mod test { +mod tests { use prelude::v1::*; use any::Any; diff --git a/src/libsyntax/ast.rs b/src/libsyntax/ast.rs index 399810cb7f50..94dc36b16ba0 100644 --- a/src/libsyntax/ast.rs +++ b/src/libsyntax/ast.rs @@ -1869,7 +1869,7 @@ pub struct MacroDef { } #[cfg(test)] -mod test { +mod tests { use serialize; use super::*; diff --git a/src/libsyntax/ast_util.rs b/src/libsyntax/ast_util.rs index 78f06ce5fd5d..720b2095a908 100644 --- a/src/libsyntax/ast_util.rs +++ b/src/libsyntax/ast_util.rs @@ -632,7 +632,7 @@ pub fn lit_is_str(lit: &Lit) -> bool { } #[cfg(test)] -mod test { +mod tests { use ast::*; use super::*; diff --git a/src/libsyntax/codemap.rs b/src/libsyntax/codemap.rs index 34ad192845c5..5e0cb647c8b4 100644 --- a/src/libsyntax/codemap.rs +++ b/src/libsyntax/codemap.rs @@ -949,7 +949,7 @@ pub struct MalformedCodemapPositions { // #[cfg(test)] -mod test { +mod tests { use super::*; use std::rc::Rc; diff --git a/src/libsyntax/ext/expand.rs b/src/libsyntax/ext/expand.rs index d1db956adb3f..4ea2d4e5c686 100644 --- a/src/libsyntax/ext/expand.rs +++ b/src/libsyntax/ext/expand.rs @@ -1553,7 +1553,7 @@ impl<'a, 'v> Visitor<'v> for MacroExterminator<'a> { #[cfg(test)] -mod test { +mod tests { use super::{pattern_bindings, expand_crate}; use super::{PatIdentFinder, IdentRenamer, PatIdentRenamer, ExpansionConfig}; use ast; diff --git a/src/libsyntax/fold.rs b/src/libsyntax/fold.rs index 8ba36cefc65d..c857d4403cbf 100644 --- a/src/libsyntax/fold.rs +++ b/src/libsyntax/fold.rs @@ -1343,7 +1343,7 @@ pub fn noop_fold_stmt(Spanned {node, span}: Stmt, folder: &mut T) } #[cfg(test)] -mod test { +mod tests { use std::io; use ast; use util::parser_testing::{string_to_crate, matches_codepattern}; diff --git a/src/libsyntax/parse/lexer/comments.rs b/src/libsyntax/parse/lexer/comments.rs index fb3a96f4c288..1577b50ad760 100644 --- a/src/libsyntax/parse/lexer/comments.rs +++ b/src/libsyntax/parse/lexer/comments.rs @@ -383,7 +383,7 @@ pub fn gather_comments_and_literals(span_diagnostic: &diagnostic::SpanHandler, } #[cfg(test)] -mod test { +mod tests { use super::*; #[test] fn test_block_doc_comment_1() { diff --git a/src/libsyntax/parse/lexer/mod.rs b/src/libsyntax/parse/lexer/mod.rs index 8e37b983e21e..d13ab65d72b2 100644 --- a/src/libsyntax/parse/lexer/mod.rs +++ b/src/libsyntax/parse/lexer/mod.rs @@ -1501,7 +1501,7 @@ fn ident_continue(c: Option) -> bool { } #[cfg(test)] -mod test { +mod tests { use super::*; use codemap::{BytePos, CodeMap, Span, NO_EXPANSION}; diff --git a/src/libsyntax/parse/mod.rs b/src/libsyntax/parse/mod.rs index 1a1713a8ba63..dee3e5fee74d 100644 --- a/src/libsyntax/parse/mod.rs +++ b/src/libsyntax/parse/mod.rs @@ -761,7 +761,7 @@ pub fn integer_lit(s: &str, suffix: Option<&str>, sd: &SpanHandler, sp: Span) -> } #[cfg(test)] -mod test { +mod tests { use super::*; use std::rc::Rc; use codemap::{Span, BytePos, Pos, Spanned, NO_EXPANSION}; diff --git a/src/libsyntax/parse/token.rs b/src/libsyntax/parse/token.rs index 2bb74944ce91..538aa3843277 100644 --- a/src/libsyntax/parse/token.rs +++ b/src/libsyntax/parse/token.rs @@ -746,7 +746,7 @@ pub fn fresh_mark() -> ast::Mrk { } #[cfg(test)] -mod test { +mod tests { use super::*; use ast; use ext::mtwt; diff --git a/src/libsyntax/print/pprust.rs b/src/libsyntax/print/pprust.rs index 5a57e09fcfff..980ce720026c 100644 --- a/src/libsyntax/print/pprust.rs +++ b/src/libsyntax/print/pprust.rs @@ -3008,7 +3008,7 @@ impl<'a> State<'a> { fn repeat(s: &str, n: usize) -> String { iter::repeat(s).take(n).collect() } #[cfg(test)] -mod test { +mod tests { use super::*; use ast; diff --git a/src/libsyntax/util/parser_testing.rs b/src/libsyntax/util/parser_testing.rs index 6adeb30a94ec..d016eb39239f 100644 --- a/src/libsyntax/util/parser_testing.rs +++ b/src/libsyntax/util/parser_testing.rs @@ -142,7 +142,7 @@ pub fn is_whitespace(c: char) -> bool { } #[cfg(test)] -mod test { +mod tests { use super::*; #[test] fn eqmodws() { diff --git a/src/libsyntax/util/small_vector.rs b/src/libsyntax/util/small_vector.rs index 153f9d4a26df..5353d12b6781 100644 --- a/src/libsyntax/util/small_vector.rs +++ b/src/libsyntax/util/small_vector.rs @@ -204,7 +204,7 @@ impl MoveMap for SmallVector { } #[cfg(test)] -mod test { +mod tests { use super::*; #[test] diff --git a/src/libterm/terminfo/parm.rs b/src/libterm/terminfo/parm.rs index c9ad08bb8523..2b8c24741ae7 100644 --- a/src/libterm/terminfo/parm.rs +++ b/src/libterm/terminfo/parm.rs @@ -573,7 +573,7 @@ fn format(val: Param, op: FormatOp, flags: Flags) -> Result ,String> { } #[cfg(test)] -mod test { +mod tests { use super::{expand,Param,Words,Variables,Number}; use std::result::Result::Ok; diff --git a/src/libterm/terminfo/parser/compiled.rs b/src/libterm/terminfo/parser/compiled.rs index 3de99088da47..ef42d8c2506b 100644 --- a/src/libterm/terminfo/parser/compiled.rs +++ b/src/libterm/terminfo/parser/compiled.rs @@ -345,7 +345,7 @@ pub fn msys_terminfo() -> Box { } #[cfg(test)] -mod test { +mod tests { use super::{boolnames, boolfnames, numnames, numfnames, stringnames, stringfnames}; diff --git a/src/test/run-pass/issue-16597.rs b/src/test/run-pass/issue-16597.rs index d074095dbded..7f0a341f1471 100644 --- a/src/test/run-pass/issue-16597.rs +++ b/src/test/run-pass/issue-16597.rs @@ -11,7 +11,7 @@ // compile-flags:--test // ignore-pretty turns out the pretty-printer doesn't handle gensym'd things... -mod test { +mod tests { use super::*; #[test]