From e50cfa7e779e4df57419c4a64d977e08e105deac Mon Sep 17 00:00:00 2001 From: mcarton Date: Sun, 2 Oct 2016 02:38:26 +0200 Subject: [PATCH] Add a test for a `shadow` corner case --- clippy_lints/src/shadow.rs | 2 +- tests/compile-fail/shadow.rs | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/clippy_lints/src/shadow.rs b/clippy_lints/src/shadow.rs index 8e3a44031ab5..2794cd14304b 100644 --- a/clippy_lints/src/shadow.rs +++ b/clippy_lints/src/shadow.rs @@ -262,7 +262,7 @@ fn lint_shadow(cx: &LateContext, name: Name, span: Span, pattern_span: Span, span_lint_and_then(cx, SHADOW_UNRELATED, span, - &format!("{} shadows a previous declaration", snippet(cx, pattern_span, "_")), + &format!("`{}` shadows a previous declaration", snippet(cx, pattern_span, "_")), |db| { db.span_note(prev_span, "previous binding is here"); }); } } diff --git a/tests/compile-fail/shadow.rs b/tests/compile-fail/shadow.rs index fae87cd97503..bf0bdd818632 100644 --- a/tests/compile-fail/shadow.rs +++ b/tests/compile-fail/shadow.rs @@ -20,6 +20,9 @@ fn main() { let y = 1; let x = y; //~ERROR `x` is shadowed by `y` + let x; //~ERROR `x` shadows a previous declaration + x = 42; + let o = Some(1_u8); if let Some(p) = o { assert_eq!(1, p); }