user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #6133 - JPTIZ:no-box-for-c-ffi, r=ebroto

Browse source 
clippy_lints: Do not warn against Box parameter in C FFI

changelog: [`boxed_local`]: don't lint in `extern fn` arguments

Fixes #5542.

When using C FFI, to handle pointers in parameters it is needed to
declare them as `Box` in its Rust-side signature. However, the current
linter warns against the usage of Box stating that "local variable
doesn't need to be boxed here".

This commit fixes it by ignoring functions whose Abi is C.
This commit is contained in:
bors 2020-10-08 22:50:29 +00:00
commit e651a04fab
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/ui/escape_analysis.rs
View file

@ -174,3 +174,11 @@ mod issue_3739 {
};
}
}
/// Issue #5542
///
/// This shouldn't warn for `boxed_local` as it is intended to called from non-Rust code.
pub extern "C" fn do_not_warn_me(_c_pointer: Box<String>) -> () {}
#[rustfmt::skip] // Forces rustfmt to not add ABI
pub extern fn do_not_warn_me_no_abi(_c_pointer: Box<String>) -> () {}