don't trigger unnecessary_debug_formatting in tests
This commit is contained in:
parent
a9c61ec1e1
commit
e6a4cf63ad
2 changed files with 9 additions and 2 deletions
|
|
@ -9,7 +9,7 @@ use clippy_utils::macros::{
|
|||
use clippy_utils::msrvs::{self, Msrv};
|
||||
use clippy_utils::source::{SpanRangeExt, snippet};
|
||||
use clippy_utils::ty::{implements_trait, is_type_lang_item};
|
||||
use clippy_utils::{is_diag_trait_item, is_from_proc_macro};
|
||||
use clippy_utils::{is_diag_trait_item, is_from_proc_macro, is_in_test};
|
||||
use itertools::Itertools;
|
||||
use rustc_ast::{
|
||||
FormatArgPosition, FormatArgPositionKind, FormatArgsPiece, FormatArgumentKind, FormatCount, FormatOptions,
|
||||
|
|
@ -484,7 +484,8 @@ impl<'tcx> FormatArgsExpr<'_, 'tcx> {
|
|||
|
||||
fn check_unnecessary_debug_formatting(&self, name: Symbol, value: &Expr<'tcx>) {
|
||||
let cx = self.cx;
|
||||
if !value.span.from_expansion()
|
||||
if !is_in_test(cx.tcx, value.hir_id)
|
||||
&& !value.span.from_expansion()
|
||||
&& !is_from_proc_macro(cx, value)
|
||||
&& let ty = cx.typeck_results().expr_ty(value)
|
||||
&& self.can_display_format(ty)
|
||||
|
|
|
|||
|
|
@ -41,3 +41,9 @@ fn main() {
|
|||
let deref_path = DerefPath { path };
|
||||
println!("{:?}", &*deref_path); //~ unnecessary_debug_formatting
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn issue_14345() {
|
||||
let input = std::path::Path::new("/foo/bar");
|
||||
assert!(input.ends_with("baz"), "{input:?}");
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue