From e84531811160308fbdd0a8ec3e9b697bb17ccd02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= <berykubik@gmail.com>
Date: Sat, 15 Mar 2025 11:11:56 +0100
Subject: [PATCH] Do not error out on missing parent metrics

---
 src/ci/citool/src/main.rs | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/ci/citool/src/main.rs b/src/ci/citool/src/main.rs
index 01483a2633d0..29f94e2be5db 100644
--- a/src/ci/citool/src/main.rs
+++ b/src/ci/citool/src/main.rs
@@ -150,11 +150,24 @@ fn postprocess_metrics(
         return Ok(());
     };
 
-    let parent_metrics =
-        download_job_metrics(&job_name, &parent).context("cannot download parent metrics")?;
-    let job_metrics =
-        HashMap::from([(job_name, JobMetrics { parent: Some(parent_metrics), current: metrics })]);
-    output_test_diffs(job_metrics);
+    // This command is executed also on PR builds, which might not have parent metrics
+    // available, because some PR jobs don't run on auto builds, and PR jobs do not upload metrics
+    // due to missing permissions.
+    // To avoid having to detect if this is a PR job, and to avoid having failed steps in PR jobs,
+    // we simply print an error if the parent metrics were not found, but otherwise exit
+    // successfully.
+    match download_job_metrics(&job_name, &parent).context("cannot download parent metrics") {
+        Ok(parent_metrics) => {
+            let job_metrics = HashMap::from([(
+                job_name,
+                JobMetrics { parent: Some(parent_metrics), current: metrics },
+            )]);
+            output_test_diffs(job_metrics);
+        }
+        Err(error) => {
+            eprintln!("Metrics for job `{job_name}` and commit `{parent}` not found: {error:?}");
+        }
+    }
 
     Ok(())
 }