user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

set default PR messages to fail the changelog CI (#14069)

Browse source 
I noticed that default PR messages could pass the changelog checking CI.

For example, if a PR is submitted without modifying the PR template, the
following line is mistakenly treated as a valid changelog by the CI:

```
changelog: [`lint_name`]: your change
```
r? flip1995

changelog: none
This commit is contained in:
Philipp Krones 2025-01-26 15:28:48 +00:00 • committed by GitHub
commit e84d60daec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
.github/workflows/clippy_changelog.yml vendored
View file

@ -26,11 +26,13 @@ jobs:
run: |
body=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -s "https://api.github.com/repos/rust-lang/rust-clippy/pulls/$PR_NUMBER" | \
python -c "import sys, json; print(json.load(sys.stdin)['body'])")
output=$(grep "^changelog:\s*\S" <<< "$body" | sed "s/changelog:\s*//g") || {
echo "ERROR: pull request message must contain 'changelog: ...'. Please add it."
output=$(awk '/^changelog:\s*\S/ && !/changelog: \[.*\]: your change/' <<< "$body" | sed "s/changelog:\s*//g")
if [ -z "$output" ]; then
echo "ERROR: pull request message must contain 'changelog: ...' with your changelog. Please add it."
exit 1
}
echo "changelog: $output"
else
echo "changelog: $output"
fi
env:
PYTHONIOENCODING: 'utf-8'
PR_NUMBER: '${{ github.event.number }}'