user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Harden duplicates checking and add tests

Browse source
This commit is contained in:
Andy Caldwell 2022-07-28 23:05:24 +01:00
parent 08e7ec4047
commit ea25ef10cf
No known key found for this signature in database
GPG key ID: D4204541AC1D228D
5 changed files with 24 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/utils/conf.rs
View file

@ -92,8 +92,8 @@ impl fmt::Display for ConfError {
impl Error for ConfError {}
fn conf_error(s: String) -> Box<dyn Error> {
Box::new(ConfError(s))
fn conf_error(s: impl Into<String>) -> Box<dyn Error> {
Box::new(ConfError(s.into()))
}
macro_rules! define_Conf {
@ -154,7 +154,13 @@ macro_rules! define_Conf {
$name = Some(value);
// $new_conf is the same as one of the defined `$name`s, so
// this variable is defined in line 2 of this function.
$($new_conf = Some(value);)?
$(match $new_conf {
Some(_) => errors.push(conf_error(concat!(
"duplicate field `", stringify!($new_conf),
"` (provided as `", stringify!($name), "`)"
))),
None => $new_conf = Some(value),
})?
},
}
}