From ea9c5c405ecea256721c6d65b7de21bffe21056b Mon Sep 17 00:00:00 2001 From: blake2-ppc Date: Sun, 4 Aug 2013 17:10:09 +0200 Subject: [PATCH] std: Remove uint::iterate, replaced by `range` --- src/libextra/bitv.rs | 7 +++---- src/libstd/num/uint.rs | 24 ------------------------ src/libstd/ptr.rs | 7 +++---- 3 files changed, 6 insertions(+), 32 deletions(-) diff --git a/src/libextra/bitv.rs b/src/libextra/bitv.rs index f32170a3a6de..6dedd9ee4dd2 100644 --- a/src/libextra/bitv.rs +++ b/src/libextra/bitv.rs @@ -206,14 +206,13 @@ impl BigBitv { #[inline] pub fn equals(&self, b: &BigBitv, nbits: uint) -> bool { let len = b.storage.len(); - do uint::iterate(0, len) |i| { + for i in range(0, len) { let mask = big_mask(nbits, i); if mask & self.storage[i] != mask & b.storage[i] { - false - } else { - true + return false; } } + true } } diff --git a/src/libstd/num/uint.rs b/src/libstd/num/uint.rs index 275a72d6ecc0..86bc98e53fcb 100644 --- a/src/libstd/num/uint.rs +++ b/src/libstd/num/uint.rs @@ -70,30 +70,6 @@ pub fn div_round(x: uint, y: uint) -> uint { /// pub fn div_floor(x: uint, y: uint) -> uint { return x / y; } -/// -/// Iterate over the range [`lo`..`hi`), or stop when requested -/// -/// # Arguments -/// -/// * lo - The integer at which to start the loop (included) -/// * hi - The integer at which to stop the loop (excluded) -/// * it - A block to execute with each consecutive integer of the range. -/// Return `true` to continue, `false` to stop. -/// -/// # Return value -/// -/// `true` If execution proceeded correctly, `false` if it was interrupted, -/// that is if `it` returned `false` at any point. -/// -pub fn iterate(lo: uint, hi: uint, it: &fn(uint) -> bool) -> bool { - let mut i = lo; - while i < hi { - if (!it(i)) { return false; } - i += 1u; - } - return true; -} - impl iter::Times for uint { #[inline] /// diff --git a/src/libstd/ptr.rs b/src/libstd/ptr.rs index 55c18faf83de..dfd11f9227d4 100644 --- a/src/libstd/ptr.rs +++ b/src/libstd/ptr.rs @@ -12,6 +12,7 @@ use cast; use clone::Clone; +use iterator::{range, Iterator}; use option::{Option, Some, None}; use unstable::intrinsics; use util::swap; @@ -20,7 +21,6 @@ use util::swap; #[cfg(not(test))] use num::Int; #[cfg(not(test))] use cmp::{Eq, Ord}; -use uint; /// Calculate the offset from a pointer #[inline] @@ -240,11 +240,10 @@ pub unsafe fn array_each_with_len(arr: **T, len: uint, cb: &fn(*T)) { fail!("ptr::array_each_with_len failure: arr input is null pointer"); } //let start_ptr = *arr; - uint::iterate(0, len, |e| { + for e in range(0, len) { let n = offset(arr, e as int); cb(*n); - true - }); + } debug!("array_each_with_len: after iterate"); }