user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only call default steps once, not once for each PathSet

Browse source 
Running steps multiple times defeats the whole point of #96501,
since lint messages will be duplicated.
This commit is contained in:
Joshua Nelson 2022-06-19 17:25:20 -05:00
parent 0e1a6fb463
commit ee8e0bc582
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/bootstrap/builder.rs
View file

@ -304,9 +304,7 @@ impl StepDescription {
if paths.is_empty() || builder.config.include_default_paths {
for (desc, should_run) in v.iter().zip(&should_runs) {
if desc.default && should_run.is_really_default() {
for pathset in &should_run.paths {
desc.maybe_run(builder, vec![pathset.clone()]);
}
desc.maybe_run(builder, should_run.paths.iter().cloned().collect());
}
}
}