user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #32073 - jseyfried:fix_another_trait_privacy_error, r=nikomatsakis

Browse source 
Fix incorrect trait privacy error

This PR fixes #21670 by using the crate metadata instead of `ExternalExports` to determine if an external item is public.

r? @nikomatsakis
This commit is contained in:
bors 2016-03-09 07:14:05 -08:00
commit ef3d051630
8 changed files with 22 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/librustc_driver/driver.rs
View file

@ -768,7 +768,6 @@ pub fn phase_3_run_analysis_passes<'tcx, F, R>(sess: &'tcx Session,
freevars,
export_map,
trait_map,
external_exports,
glob_map,
} = time(time_passes,
"resolution",
@ -829,9 +828,7 @@ pub fn phase_3_run_analysis_passes<'tcx, F, R>(sess: &'tcx Session,
analysis.access_levels =
time(time_passes, "privacy checking", || {
rustc_privacy::check_crate(tcx,
&analysis.export_map,
external_exports)
rustc_privacy::check_crate(tcx, &analysis.export_map)
});
// Do not move this check past lint