From f318ba2d2fb542e0b1df9be38671dc64e3c07ab5 Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Tue, 28 Aug 2018 14:04:07 +0200 Subject: [PATCH] Warn about naively fixing the FIXME --- src/librustc/ty/layout.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/librustc/ty/layout.rs b/src/librustc/ty/layout.rs index c93ca836bef0..4524c486272b 100644 --- a/src/librustc/ty/layout.rs +++ b/src/librustc/ty/layout.rs @@ -1627,6 +1627,13 @@ impl<'a, 'tcx, C> TyLayoutMethods<'tcx, C> for Ty<'tcx> tcx.mk_array(tcx.types.usize, 3), ) /* FIXME use actual fn pointers + Warning: naively computing the number of entries in the + vtable by counting the methods on the trait + methods on + all parent traits does not work, because some methods can + be not object safe and thus excluded from the vtable. + Increase this counter if you tried to implement this but + failed to do it without duplicating a lot of code from + other places in the compiler: 2 tcx.mk_tup(&[ tcx.mk_array(tcx.types.usize, 3), tcx.mk_array(Option),