diff --git a/clippy_lints/src/doc/mod.rs b/clippy_lints/src/doc/mod.rs index 2984c5c15199..8b6256a50f4f 100644 --- a/clippy_lints/src/doc/mod.rs +++ b/clippy_lints/src/doc/mod.rs @@ -17,7 +17,7 @@ use rustc_hir::{AnonConst, Expr}; use rustc_lint::{LateContext, LateLintPass}; use rustc_middle::hir::nested_filter; use rustc_middle::lint::in_external_macro; -use rustc_middle::ty; +use rustc_middle::ty::{self}; use rustc_resolve::rustdoc::{ add_doc_fragment, attrs_to_doc_fragments, main_body_opts, source_span_for_markdown_range, DocFragment, }; @@ -556,9 +556,8 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet, attrs: &[ acc }); doc.pop(); - let doc = doc.trim().to_string(); - if doc.is_empty() { + if doc.trim().is_empty() { return Some(DocInfo { empty: true, doc_headers: DocHeaders::default(), diff --git a/tests/ui/empty_docs.rs b/tests/ui/empty_docs.rs index 77564c1c33df..f5b4bb6736d1 100644 --- a/tests/ui/empty_docs.rs +++ b/tests/ui/empty_docs.rs @@ -59,3 +59,5 @@ fn warn() { fn dont_warn() { /*! dont warn me */ } + +trait NoDoc {}