diff --git a/src/libstd/rt/comm.rs b/src/libstd/rt/comm.rs index 46c99d21d9d0..f098f8b2767c 100644 --- a/src/libstd/rt/comm.rs +++ b/src/libstd/rt/comm.rs @@ -286,8 +286,14 @@ impl Drop for PortOneHack { STATE_ONE => { let _packet: ~Packet = cast::transmute(this.void_packet); } - _ => { - util::unreachable() + task_as_state => { + // This case occurs during unwinding, when the blocked + // receiver was killed awake. The task can't still be + // blocked (we are it), but we need to free the handle. + let recvr = BlockedTask::cast_from_uint(task_as_state); + // FIXME(#7554)(bblum): Make this cfg(test) dependent. + // in a later commit. + assert!(recvr.wake().is_none()); } } } diff --git a/src/libstd/task/spawn.rs b/src/libstd/task/spawn.rs index aac4463888b3..b099985b1ace 100644 --- a/src/libstd/task/spawn.rs +++ b/src/libstd/task/spawn.rs @@ -669,19 +669,44 @@ pub fn spawn_raw(opts: TaskOpts, f: ~fn()) { } fn spawn_raw_newsched(mut opts: TaskOpts, f: ~fn()) { - let f = Cell::new(f); + let child_data = Cell::new(gen_child_taskgroup(opts.linked, opts.supervised)); + + let child_wrapper: ~fn() = || { + // Child task runs this code. + let child_data = Cell::new(child_data.take()); // :( + let enlist_success = do Local::borrow:: |me| { + let (child_tg, ancestors, is_main) = child_data.take(); + let mut ancestors = ancestors; + // FIXME(#7544): Optimize out the xadd in this clone, somehow. + let handle = me.death.kill_handle.get_ref().clone(); + // Atomically try to get into all of our taskgroups. + if enlist_many(NewTask(handle), &child_tg, &mut ancestors) { + // Got in. We can run the provided child body, and can also run + // the taskgroup's exit-time-destructor afterward. + me.taskgroup = Some(TCB(child_tg, ancestors, is_main, None)); + true + } else { + false + } + }; + // Should be run after the local-borrowed task is returned. + if enlist_success { + f() + } + }; let mut task = unsafe { let sched = Local::unsafe_borrow::(); rtdebug!("unsafe borrowed sched"); if opts.linked { + let child_wrapper = Cell::new(child_wrapper); do Local::borrow::() |running_task| { - ~running_task.new_child(&mut (*sched).stack_pool, f.take()) + ~running_task.new_child(&mut (*sched).stack_pool, child_wrapper.take()) } } else { // An unlinked task is a new root in the task tree - ~Task::new_root(&mut (*sched).stack_pool, f.take()) + ~Task::new_root(&mut (*sched).stack_pool, child_wrapper) } };