user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

question_mark: don't add as_ref() for a call expression

Browse source
This commit is contained in:
Shotaro Yamada 2020-04-17 13:09:02 +09:00
parent eb9c15a6b3
commit f58bb5b234
4 changed files with 40 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
clippy_lints/src/question_mark.rs
View file

@ -70,10 +70,12 @@ impl QuestionMark {
replacement = Some(format!("Some({}?)", receiver_str));
}
}
} else if Self::moves_by_default(cx, subject) {
replacement = Some(format!("{}.as_ref()?;", receiver_str));
} else if Self::moves_by_default(cx, subject)
&& !matches!(subject.kind, ExprKind::Call(..) | ExprKind::MethodCall(..))
{
replacement = Some(format!("{}.as_ref()?;", receiver_str));
} else {
replacement = Some(format!("{}?;", receiver_str));
replacement = Some(format!("{}?;", receiver_str));
}
if let Some(replacement_str) = replacement {