From f59d645a9b1a4902ae52602db6270be75f7aa512 Mon Sep 17 00:00:00 2001 From: Nathan West Date: Thu, 29 Nov 2018 20:36:32 -0500 Subject: [PATCH] Defactored Bytes::read Removed unneeded refactoring of read_one_byte, which removed the unneeded dynamic dispatch (`dyn Read`) used by that function. --- src/libstd/io/mod.rs | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index 076524e624a4..452cbae4411d 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -1936,18 +1936,6 @@ impl BufRead for Take { } } -fn read_one_byte(reader: &mut dyn Read) -> Option> { - let mut buf = [0]; - loop { - return match reader.read(&mut buf) { - Ok(0) => None, - Ok(..) => Some(Ok(buf[0])), - Err(ref e) if e.kind() == ErrorKind::Interrupted => continue, - Err(e) => Some(Err(e)), - }; - } -} - /// An iterator over `u8` values of a reader. /// /// This struct is generally created by calling [`bytes`] on a reader. @@ -1965,7 +1953,15 @@ impl Iterator for Bytes { type Item = Result; fn next(&mut self) -> Option> { - read_one_byte(&mut self.inner) + let mut buf = [0]; + loop { + return match self.inner.read(&mut buf) { + Err(ref e) if e.kind() == ErrorKind::Interrupted => continue, + Ok(0) => None, + Ok(..) => Some(Ok(buf[0])), + Err(e) => Some(Err(e)), + }; + } } }