user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use verbose for associated functions suggestion

Browse source
This commit is contained in:
yukang 2025-11-21 20:34:35 +08:00
parent 5f7653df82
commit f5a5f0ff03
11 changed files with 115 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_hir_typeck/src/method/suggest.rs
View file

@ -2339,7 +2339,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
applicability = Applicability::HasPlaceholders;
"(...)".to_owned()
};
err.span_suggestion(
err.span_suggestion_verbose(
sugg_span,
"use associated function syntax instead",
format!("{ty_str}::{item_name}{args}"),

10
tests/ui/issues/issue-4265.stderr
View file

@ -14,10 +14,7 @@ LL | struct Foo {
| ---------- method `bar` not found for this struct
...
LL | Foo { baz: 0 }.bar();
| ---------------^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `Foo::bar()`
| ^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `Foo`
@ -25,6 +22,11 @@ note: the candidate is defined in an impl for the type `Foo`
|
LL | fn bar() {
| ^^^^^^^^
help: use associated function syntax instead
|
LL - Foo { baz: 0 }.bar();
LL + Foo::bar();
|
error: aborting due to 2 previous errors

10
tests/ui/methods/issue-3707.stderr
View file

@ -2,10 +2,7 @@ error[E0599]: no method named `boom` found for reference `&Obj` in the current s
--> $DIR/issue-3707.rs:10:14
|
LL | self.boom();
| -----^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `Obj::boom()`
| ^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `Obj`
@ -13,6 +10,11 @@ note: the candidate is defined in an impl for the type `Obj`
|
LL | pub fn boom() -> bool {
| ^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - self.boom();
LL + Obj::boom();
|
error: aborting due to 1 previous error

10
tests/ui/suggestions/issue-102354.stderr
View file

@ -2,10 +2,7 @@ error[E0599]: no method named `func` found for type `i32` in the current scope
--> $DIR/issue-102354.rs:9:7
|
LL | x.func();
| --^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `i32::func()`
| ^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in the trait `Trait`
@ -13,6 +10,11 @@ note: the candidate is defined in the trait `Trait`
|
LL | fn func() {}
| ^^^^^^^^^
help: use associated function syntax instead
|
LL - x.func();
LL + i32::func();
|
error: aborting due to 1 previous error

10
tests/ui/suggestions/issue-103646.stderr
View file

@ -4,10 +4,7 @@ error[E0599]: no method named `nya` found for type parameter `T` in the current
LL | fn uwu<T: Cat>(c: T) {
| - method `nya` not found for this type parameter
LL | c.nya();
| --^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `T::nya()`
| ^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in the trait `Cat`
@ -15,6 +12,11 @@ note: the candidate is defined in the trait `Cat`
|
LL | fn nya() {}
| ^^^^^^^^
help: use associated function syntax instead
|
LL - c.nya();
LL + T::nya();
|
error: aborting due to 1 previous error

10
tests/ui/suggestions/suggest-assoc-fn-call-deref.stderr
View file

@ -2,10 +2,7 @@ error[E0599]: no method named `test` found for struct `Box<Foo<i32>>` in the cur
--> $DIR/suggest-assoc-fn-call-deref.rs:13:7
|
LL | x.test();
| --^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `Foo::<i32>::test()`
| ^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `Foo<T>`
@ -13,6 +10,11 @@ note: the candidate is defined in an impl for the type `Foo<T>`
|
LL | fn test() -> i32 { 1 }
| ^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - x.test();
LL + Foo::<i32>::test();
|
error: aborting due to 1 previous error

30
tests/ui/suggestions/suggest-assoc-fn-call-for-impl-trait.stderr
View file

@ -5,10 +5,7 @@ LL | struct A {
| -------- method `foo` not found for this struct
...
LL | _a.foo();
| ---^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `A::foo(_a)`
| ^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in the trait `M`
@ -16,6 +13,11 @@ note: the candidate is defined in the trait `M`
|
LL | fn foo(_a: Self);
| ^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _a.foo();
LL + A::foo(_a);
|
error[E0599]: no method named `baz` found for struct `A` in the current scope
--> $DIR/suggest-assoc-fn-call-for-impl-trait.rs:23:8
@ -24,10 +26,7 @@ LL | struct A {
| -------- method `baz` not found for this struct
...
LL | _a.baz(0);
| ---^^^---
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `A::baz(0)`
| ^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in the trait `M`
@ -35,6 +34,11 @@ note: the candidate is defined in the trait `M`
|
LL | fn baz(_a: i32);
| ^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _a.baz(0);
LL + A::baz(0);
|
error[E0599]: no method named `bar` found for struct `A` in the current scope
--> $DIR/suggest-assoc-fn-call-for-impl-trait.rs:27:8
@ -43,10 +47,7 @@ LL | struct A {
| -------- method `bar` not found for this struct
...
LL | _b.bar();
| ---^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `A::bar(_b)`
| ^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in the trait `M`
@ -54,6 +55,11 @@ note: the candidate is defined in the trait `M`
|
LL | fn bar(_a: Self);
| ^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _b.bar();
LL + A::bar(_b);
|
error: aborting due to 3 previous errors

10
tests/ui/suggestions/suggest-assoc-fn-call-with-turbofish-placeholder.stderr
View file

@ -5,10 +5,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `default_hello` not found for this struct
...
LL | x.default_hello();
| --^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<_>::default_hello()`
| ^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -16,6 +13,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn default_hello() {}
| ^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - x.default_hello();
LL + GenericAssocMethod::<_>::default_hello();
|
error: aborting due to 1 previous error

10
tests/ui/suggestions/suggest-assoc-fn-call-with-turbofish-through-deref.stderr
View file

@ -2,10 +2,7 @@ error[E0599]: no method named `hello` found for struct `RefMut<'_, HasAssocMetho
--> $DIR/suggest-assoc-fn-call-with-turbofish-through-deref.rs:11:11
|
LL | state.hello();
| ------^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `HasAssocMethod::hello()`
| ^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `HasAssocMethod`
@ -13,6 +10,11 @@ note: the candidate is defined in an impl for the type `HasAssocMethod`
|
LL | fn hello() {}
| ^^^^^^^^^^
help: use associated function syntax instead
|
LL - state.hello();
LL + HasAssocMethod::hello();
|
error: aborting due to 1 previous error

50
tests/ui/suggestions/suggest-assoc-fn-call-with-turbofish.stderr
View file

@ -5,10 +5,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `self_ty_ref_hello` not found for this struct
...
LL | x.self_ty_ref_hello();
| --^^^^^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<_>::self_ty_ref_hello(&x)`
| ^^^^^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -16,6 +13,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn self_ty_ref_hello(_: &Self) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - x.self_ty_ref_hello();
LL + GenericAssocMethod::<_>::self_ty_ref_hello(&x);
|
error[E0599]: no method named `self_ty_hello` found for struct `GenericAssocMethod<{integer}>` in the current scope
--> $DIR/suggest-assoc-fn-call-with-turbofish.rs:16:7
@ -24,10 +26,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `self_ty_hello` not found for this struct
...
LL | x.self_ty_hello();
| --^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<_>::self_ty_hello(x)`
| ^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -35,6 +34,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn self_ty_hello(_: Self) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - x.self_ty_hello();
LL + GenericAssocMethod::<_>::self_ty_hello(x);
|
error[E0599]: no method named `default_hello` found for struct `GenericAssocMethod<i32>` in the current scope
--> $DIR/suggest-assoc-fn-call-with-turbofish.rs:20:7
@ -43,10 +47,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `default_hello` not found for this struct
...
LL | y.default_hello();
| --^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<i32>::default_hello()`
| ^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -54,6 +55,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn default_hello() {}
| ^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - y.default_hello();
LL + GenericAssocMethod::<i32>::default_hello();
|
error[E0599]: no method named `self_ty_ref_hello` found for struct `GenericAssocMethod<i32>` in the current scope
--> $DIR/suggest-assoc-fn-call-with-turbofish.rs:22:7
@ -62,10 +68,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `self_ty_ref_hello` not found for this struct
...
LL | y.self_ty_ref_hello();
| --^^^^^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<i32>::self_ty_ref_hello(&y)`
| ^^^^^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -73,6 +76,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn self_ty_ref_hello(_: &Self) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - y.self_ty_ref_hello();
LL + GenericAssocMethod::<i32>::self_ty_ref_hello(&y);
|
error[E0599]: no method named `self_ty_hello` found for struct `GenericAssocMethod<i32>` in the current scope
--> $DIR/suggest-assoc-fn-call-with-turbofish.rs:24:7
@ -81,10 +89,7 @@ LL | struct GenericAssocMethod<T>(T);
| ---------------------------- method `self_ty_hello` not found for this struct
...
LL | y.self_ty_hello();
| --^^^^^^^^^^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `GenericAssocMethod::<i32>::self_ty_hello(y)`
| ^^^^^^^^^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
@ -92,6 +97,11 @@ note: the candidate is defined in an impl for the type `GenericAssocMethod<T>`
|
LL | fn self_ty_hello(_: Self) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - y.self_ty_hello();
LL + GenericAssocMethod::<i32>::self_ty_hello(y);
|
error: aborting due to 5 previous errors

40
tests/ui/suggestions/suggest-assoc-fn-call-without-receiver.stderr
View file

@ -5,10 +5,7 @@ LL | struct A {}
| -------- method `hello` not found for this struct
...
LL | _a.hello(1);
| ---^^^^^---
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `A::hello(1)`
| ^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `A`
@ -16,6 +13,11 @@ note: the candidate is defined in an impl for the type `A`
|
LL | fn hello(_a: i32) {}
| ^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _a.hello(1);
LL + A::hello(1);
|
error[E0599]: no method named `test` found for struct `A` in the current scope
--> $DIR/suggest-assoc-fn-call-without-receiver.rs:22:8
@ -24,10 +26,7 @@ LL | struct A {}
| -------- method `test` not found for this struct
...
LL | _a.test(1);
| ---^^^^---
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `A::test(_a, 1)`
| ^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `A`
@ -35,6 +34,11 @@ note: the candidate is defined in an impl for the type `A`
|
LL | fn test(_a: Self, _b: i32) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _a.test(1);
LL + A::test(_a, 1);
|
error[E0599]: no method named `hello` found for struct `B<&str>` in the current scope
--> $DIR/suggest-assoc-fn-call-without-receiver.rs:26:8
@ -43,10 +47,7 @@ LL | struct B<T> {
| ----------- method `hello` not found for this struct
...
LL | _b.hello(1);
| ---^^^^^---
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `B::<&str>::hello(1)`
| ^^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `B<T>`
@ -54,6 +55,11 @@ note: the candidate is defined in an impl for the type `B<T>`
|
LL | fn hello(_a: i32) {}
| ^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _b.hello(1);
LL + B::<&str>::hello(1);
|
error[E0599]: no method named `test` found for struct `B<&str>` in the current scope
--> $DIR/suggest-assoc-fn-call-without-receiver.rs:28:8
@ -62,10 +68,7 @@ LL | struct B<T> {
| ----------- method `test` not found for this struct
...
LL | _b.test(1);
| ---^^^^---
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `B::<&str>::test(_b, 1)`
| ^^^^ this is an associated function, not a method
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `B<T>`
@ -73,6 +76,11 @@ note: the candidate is defined in an impl for the type `B<T>`
|
LL | fn test(_a: Self, _b: i32) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
help: use associated function syntax instead
|
LL - _b.test(1);
LL + B::<&str>::test(_b, 1);
|
error: aborting due to 4 previous errors