user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rollup merge of #101737 - notriddle:notriddle/search-results-result-name-span, r=GuillaumeGomez

Browse source 
rustdoc: remove no-op CSS `.search-results .result-name > span`

The rule `display: inline-block` was added in 5afa52bc7d. The `margin: 0` and `font-weight: normal` were added in c01bd560e2.

Both seem to have been added to override class-based rules that were targetted at method sections. See <c01bd560e2/src/librustdoc/html/static/rustdoc.css (L140-L148)> for an example. The selectors that these were meant to override were changed in a8318e420d and 76a3b609d0 to be more specific, so they no longer need to be overridden.
This commit is contained in:
Matthias Krüger 2022-09-13 22:25:34 +02:00 • committed by GitHub
commit f80b38b568
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/librustdoc/html/static/css/rustdoc.css
View file

@ -986,12 +986,6 @@ so that we can apply CSS-filters to change the arrow color in themes */
padding-right: 1em;
}
.search-results .result-name > span {
display: inline-block;
margin: 0;
font-weight: normal;
}
.popover {
font-size: 1rem;
position: absolute;

3
src/test/rustdoc-gui/search-result-display.goml
View file

@ -13,6 +13,9 @@ size: (600, 100)
// when computed it's larger.
assert-css: (".search-results div.desc", {"width": "566px"})
// The result set is all on one line.
assert-css: (".search-results .result-name > span", {"display": "inline"})
// Check that the crate filter `<select>` is correctly handled when it goes to next line.
// To do so we need to update the length of one of its `<option>`.
size: (900, 900)