user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a couple small tests to the match-same-arm lint.

Browse source
This commit is contained in:
laurent 2017-11-29 20:42:37 +00:00
parent 273ddafac5
commit f8dbd32433
3 changed files with 42 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/copies.rs
View file

@ -203,14 +203,10 @@ fn lint_match_arms(cx: &LateContext, expr: &Expr) {
db.span_note(i.body.span, "same as this");
// Note: this does not use `span_suggestion` on purpose: there is no clean way
// to
// remove the other arm. Building a span and suggest to replace it to "" makes
// an
// even more confusing error message. Also in order not to make up a span for
// the
// whole pattern, the suggestion is only shown when there is only one pattern.
// The
// user should know about `|` if they are already using it…
// to remove the other arm. Building a span and suggest to replace it to ""
// makes an even more confusing error message. Also in order not to make up a
// span for the whole pattern, the suggestion is only shown when there is only
// one pattern. The user should know about `|` if they are already using it…
if i.pats.len() == 1 && j.pats.len() == 1 {
let lhs = snippet(cx, i.pats[0].span, "<pat1>");