user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

removed lint for division/modulo for literal 0

Browse source
This commit is contained in:
henil 2020-10-30 17:11:44 +05:30
parent e97602e482
commit fa0a78b130
2 changed files with 2 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

7
clippy_lints/src/arithmetic.rs
View file

@ -90,12 +90,7 @@ impl<'tcx> LateLintPass<'tcx> for Arithmetic {
if l_ty.peel_refs().is_integral() && r_ty.peel_refs().is_integral() {
match op.node {
hir::BinOpKind::Div | hir::BinOpKind::Rem => match &r.kind {
hir::ExprKind::Lit(lit) => {
if let rustc_ast::ast::LitKind::Int(0, _) = lit.node {
span_lint(cx, INTEGER_ARITHMETIC, expr.span, "integer arithmetic detected");
self.expr_span = Some(expr.span);
}
},
hir::ExprKind::Lit(_lit) => (),
hir::ExprKind::Unary(hir::UnOp::UnNeg, expr) => {
if let hir::ExprKind::Lit(lit) = &expr.kind {
if let rustc_ast::ast::LitKind::Int(1, _) = lit.node {

14
tests/ui/integer_arithmetic.stderr
View file

@ -75,12 +75,6 @@ error: integer arithmetic detected
LL | i *= 2;
| ^^^^^^
error: integer arithmetic detected
--> $DIR/integer_arithmetic.rs:37:5
|
LL | i /= 0;
| ^^^^^^
error: integer arithmetic detected
--> $DIR/integer_arithmetic.rs:38:11
|
@ -99,12 +93,6 @@ error: integer arithmetic detected
LL | i /= var2;
| ^^^^^^^^^
error: integer arithmetic detected
--> $DIR/integer_arithmetic.rs:42:5
|
LL | i %= 0;
| ^^^^^^
error: integer arithmetic detected
--> $DIR/integer_arithmetic.rs:43:11
|
@ -177,5 +165,5 @@ error: integer arithmetic detected
LL | (&x + &y)
| ^^^^^^^^^
error: aborting due to 29 previous errors
error: aborting due to 27 previous errors