Merge branch 'master' into no_effect_with_drop

tests/ui/absurd-extreme-comparisons.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(absurd_extreme_comparisons)]
 #![allow(unused, eq_op, no_effect, unnecessary_operation, needless_pass_by_value)]

tests/ui/absurd-extreme-comparisons.stderr

@@ -143,5 +143,3 @@ error: <-comparison of unit values detected. This will always be false
    |
    = note: `-D unit-cmp` implied by `-D warnings`
 
-error: aborting due to 18 previous errors
-

tests/ui/approx_const.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(approx_constant)]
 #[allow(unused, shadow_unrelated, similar_names)]

tests/ui/approx_const.stderr

@@ -114,5 +114,3 @@ error: approximate value of `f{32, 64}::consts::SQRT_2` found. Consider using it
 55 |     let my_sq2 = 1.4142;
    |                  ^^^^^^
 
-error: aborting due to 19 previous errors
-

tests/ui/arithmetic.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(integer_arithmetic, float_arithmetic)]
 #![allow(unused, shadow_reuse, shadow_unrelated, no_effect, unnecessary_operation)]

tests/ui/arithmetic.stderr

@@ -69,5 +69,3 @@ error: floating-point arithmetic detected
 29 |     -f;
    |     ^^
 
-error: aborting due to 11 previous errors
-

tests/ui/array_indexing.rs

@@ -1,5 +1,5 @@
 #![feature(inclusive_range_syntax, plugin)]
-#![plugin(clippy)]
+
 
 #![warn(indexing_slicing)]
 #![warn(out_of_bounds_indexing)]
@@ -13,8 +13,8 @@ fn main() {
     x[1 << 3];
     &x[1..5];
     &x[0..3];
-    &x[0...4];
-    &x[...4];
+    &x[0..=4];
+    &x[..=4];
     &x[..];
     &x[1..];
     &x[4..];
@@ -26,19 +26,19 @@ fn main() {
     y[0];
     &y[1..2];
     &y[..];
-    &y[0...4];
-    &y[...4];
+    &y[0..=4];
+    &y[..=4];
 
     let empty: [i8; 0] = [];
     empty[0];
     &empty[1..5];
-    &empty[0...4];
-    &empty[...4];
+    &empty[0..=4];
+    &empty[..=4];
     &empty[..];
     &empty[0..];
     &empty[0..0];
-    &empty[0...0];
-    &empty[...0];
+    &empty[0..=0];
+    &empty[..=0];
     &empty[..0];
     &empty[1..];
     &empty[..4];

tests/ui/array_indexing.stderr

@@ -21,13 +21,13 @@ error: range is out of bounds
 error: range is out of bounds
   --> $DIR/array_indexing.rs:16:6
    |
-16 |     &x[0...4];
+16 |     &x[0..=4];
    |      ^^^^^^^^
 
 error: range is out of bounds
   --> $DIR/array_indexing.rs:17:6
    |
-17 |     &x[...4];
+17 |     &x[..=4];
    |      ^^^^^^^
 
 error: range is out of bounds
@@ -59,13 +59,13 @@ error: slicing may panic
 error: slicing may panic
   --> $DIR/array_indexing.rs:29:6
    |
-29 |     &y[0...4];
+29 |     &y[0..=4];
    |      ^^^^^^^^
 
 error: slicing may panic
   --> $DIR/array_indexing.rs:30:6
    |
-30 |     &y[...4];
+30 |     &y[..=4];
    |      ^^^^^^^
 
 error: const index is out of bounds
@@ -83,25 +83,25 @@ error: range is out of bounds
 error: range is out of bounds
   --> $DIR/array_indexing.rs:35:6
    |
-35 |     &empty[0...4];
+35 |     &empty[0..=4];
    |      ^^^^^^^^^^^^
 
 error: range is out of bounds
   --> $DIR/array_indexing.rs:36:6
    |
-36 |     &empty[...4];
+36 |     &empty[..=4];
    |      ^^^^^^^^^^^
 
 error: range is out of bounds
   --> $DIR/array_indexing.rs:40:6
    |
-40 |     &empty[0...0];
+40 |     &empty[0..=0];
    |      ^^^^^^^^^^^^
 
 error: range is out of bounds
   --> $DIR/array_indexing.rs:41:6
    |
-41 |     &empty[...0];
+41 |     &empty[..=0];
    |      ^^^^^^^^^^^
 
 error: range is out of bounds
@@ -116,5 +116,3 @@ error: range is out of bounds
 44 |     &empty[..4];
    |      ^^^^^^^^^^
 
-error: aborting due to 19 previous errors
-

tests/ui/assign_ops.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(assign_ops)]
 #[allow(unused_assignments)]

tests/ui/assign_ops.stderr

@@ -134,5 +134,3 @@ error: manual implementation of an assign operation
 40 |     s = s + "bla";
    |     ^^^^^^^^^^^^^ help: replace it with: `s += "bla"`
 
-error: aborting due to 22 previous errors
-

tests/ui/assign_ops2.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[allow(unused_assignments)]
 #[warn(misrefactored_assign_op)]

tests/ui/assign_ops2.stderr

@@ -48,5 +48,3 @@ error: variable appears on both sides of an assignment operation
 15 |     a &= a & 1;
    |     ^^^^^^^^^^ help: replace it with: `a &= 1`
 
-error: aborting due to 8 previous errors
-

tests/ui/attrs.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(inline_always, deprecated_semver)]
 

tests/ui/attrs.stderr

@@ -20,5 +20,3 @@ error: the since field must contain a semver-compliant version
 30 | #[deprecated(since = "1")]
    |              ^^^^^^^^^^^
 
-error: aborting due to 3 previous errors
-

tests/ui/bit_masks.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 const THREE_BITS : i64 = 7;
 const EVEN_MORE_REDIRECTION : i64 = THREE_BITS;

tests/ui/bit_masks.stderr

@@ -6,20 +6,6 @@ error: &-masking with zero
    |
    = note: `-D bad-bit-mask` implied by `-D warnings`
 
-error: bit mask could be simplified with a call to `trailing_zeros`
-  --> $DIR/bit_masks.rs:12:5
-   |
-12 |     x & 0 == 0;
-   |     ^^^^^^^^^^ help: try: `x.trailing_zeros() >= 0`
-   |
-   = note: `-D verbose-bit-mask` implied by `-D warnings`
-
-error: bit mask could be simplified with a call to `trailing_zeros`
-  --> $DIR/bit_masks.rs:14:5
-   |
-14 |     x & 1 == 0; //ok, compared with zero
-   |     ^^^^^^^^^^ help: try: `x.trailing_zeros() >= 1`
-
 error: incompatible bit mask: `_ & 2` can never be equal to `1`
   --> $DIR/bit_masks.rs:15:5
    |
@@ -106,5 +92,3 @@ error: ineffective bit mask: `x | 1` compared to `8`, is the same as x compared
 55 |     x | 1 >= 8;
    |     ^^^^^^^^^^
 
-error: aborting due to 17 previous errors
-

tests/ui/blacklisted_name.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![allow(dead_code, similar_names, single_match, toplevel_ref_arg, unused_mut, unused_variables)]
 #![warn(blacklisted_name)]

tests/ui/blacklisted_name.stderr

@@ -84,5 +84,3 @@ error: use of a blacklisted/placeholder name `baz`
 35 |     if let Some(ref mut baz) = Some(42) {}
    |                         ^^^
 
-error: aborting due to 14 previous errors
-

tests/ui/block_in_if_condition.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(block_in_if_condition_expr)]
 #![warn(block_in_if_condition_stmt)]

tests/ui/block_in_if_condition.stderr

@@ -50,5 +50,3 @@ error: this boolean expression can be simplified
    |
    = note: `-D nonminimal-bool` implied by `-D warnings`
 
-error: aborting due to 5 previous errors
-

tests/ui/bool_comparison.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(bool_comparison)]
 fn main() {

tests/ui/bool_comparison.stderr

@@ -24,5 +24,3 @@ error: equality checks against false can be replaced by a negation
 10 |     if false == x { "yes" } else { "no" };
    |        ^^^^^^^^^^ help: try simplifying it as shown: `!x`
 
-error: aborting due to 4 previous errors
-

tests/ui/booleans.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(nonminimal_bool, logic_bug)]
 
 #[allow(unused, many_single_char_names)]

tests/ui/booleans.stderr

@@ -130,5 +130,3 @@ help: try
 39 |     let _ = !(a == b && c == d);
    |             ^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 13 previous errors
-

tests/ui/borrow_box.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![deny(borrowed_box)]
 #![allow(blacklisted_name)]

tests/ui/borrow_box.stderr

@@ -28,5 +28,3 @@ error: you seem to be trying to use `&Box<T>`. Consider using just `&T`
 22 |     fn test4(a: &Box<bool>);
    |                 ^^^^^^^^^^ help: try: `&bool`
 
-error: aborting due to 4 previous errors
-

tests/ui/box_vec.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(clippy)]
 #![allow(boxed_local, needless_pass_by_value)]

tests/ui/box_vec.stderr

@@ -7,5 +7,3 @@ error: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
    = note: `-D box-vec` implied by `-D warnings`
    = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
 
-error: aborting due to previous error
-

tests/ui/builtin-type-shadow.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(builtin_type_shadow)]
 
 fn foo<u32>(a: u32) -> u32 {

tests/ui/builtin-type-shadow.stderr

@@ -17,5 +17,3 @@ error[E0308]: mismatched types
   = note: expected type `u32`
              found type `{integer}`
 
-error: aborting due to 2 previous errors
-

tests/ui/bytecount.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[deny(naive_bytecount)]
 fn main() {

tests/ui/bytecount.stderr

@@ -22,5 +22,3 @@ error: You appear to be counting bytes the naive way
 22 |     let _ = x.iter().filter(|a| b + 1 == **a).count(); // naive byte count
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(x, b + 1)`
 
-error: aborting due to 3 previous errors
-

tests/ui/cast.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(cast_precision_loss, cast_possible_truncation, cast_sign_loss, cast_possible_wrap, cast_lossless)]
 #[allow(no_effect, unnecessary_operation)]

tests/ui/cast.stderr

@@ -460,5 +460,3 @@ error: casting to the same type is unnecessary (`bool` -> `bool`)
 88 |     false as bool;
    |     ^^^^^^^^^^^^^
 
-error: aborting due to 75 previous errors
-

tests/ui/char_lit_as_u8.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(char_lit_as_u8)]
 #![allow(unused_variables)]

tests/ui/char_lit_as_u8.stderr

@@ -8,5 +8,3 @@ error: casting character literal to u8. `char`s are 4 bytes wide in rust, so cas
   = help: Consider using a byte literal instead:
           b'a'
 
-error: aborting due to previous error
-

tests/ui/cmp_nan.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(cmp_nan)]
 #[allow(float_cmp, no_effect, unnecessary_operation)]

tests/ui/cmp_nan.stderr

@@ -72,5 +72,3 @@ error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead
 21 |     y >= std::f64::NAN;
    |     ^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 12 previous errors
-

tests/ui/cmp_null.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(cmp_null)]
 #![allow(unused_mut)]
 

tests/ui/cmp_null.stderr

@@ -12,5 +12,3 @@ error: Comparing with null is better expressed by the .is_null() method
 16 |     if m == ptr::null_mut() {
    |        ^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 2 previous errors
-

tests/ui/cmp_owned.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(cmp_owned)]
 #[allow(unnecessary_operation)]

tests/ui/cmp_owned.stderr

@@ -36,5 +36,3 @@ error: this creates an owned instance just for comparison
 30 |         self.to_owned() == *other
    |         ^^^^^^^^^^^^^^^ try calling implementing the comparison without allocating
 
-error: aborting due to 6 previous errors
-

tests/ui/collapsible_if.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(collapsible_if)]
 fn main() {

tests/ui/collapsible_if.stderr

@@ -252,5 +252,3 @@ help: try
 112 | }
     |
 
-error: aborting due to 13 previous errors
-

tests/ui/complex_types.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(clippy)]
 #![allow(unused, needless_pass_by_value)]
 #![feature(associated_type_defaults)]

tests/ui/complex_types.stderr

@@ -90,5 +90,3 @@ error: very complex type used. Consider factoring parts into `type` definitions
 40 |     let _y: Vec<Vec<Box<(u32, u32, u32, u32)>>> = vec![];
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 15 previous errors
-

tests/ui/conf_bad_arg.rs

@@ -1,6 +1,6 @@
 // error-pattern: `conf_file` must be a named value
 
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file))]
 
 fn main() {}

tests/ui/conf_bad_arg.stderr

@@ -1,14 +1,8 @@
-error: `conf_file` must be a named value
- --> $DIR/conf_bad_arg.rs:4:18
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_bad_arg.rs:4:1
   |
 4 | #![plugin(clippy(conf_file))]
-  |                  ^^^^^^^^^
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-note: Clippy will use default configuration
- --> $DIR/conf_bad_arg.rs:4:18
-  |
-4 | #![plugin(clippy(conf_file))]
-  |                  ^^^^^^^^^
-
-error: aborting due to previous error
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/conf_bad_toml.rs

@@ -1,6 +1,6 @@
 // error-pattern: error reading Clippy's configuration file
 
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file="./tests/ui/conf_bad_toml.toml"))]
 
 fn main() {}

tests/ui/conf_bad_toml.stderr

@@ -1,4 +1,8 @@
-error: error reading Clippy's configuration file: expected an equals, found an identifier at line 1
-
-error: aborting due to previous error
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_bad_toml.rs:4:1
+  |
+4 | #![plugin(clippy(conf_file="./$DIR/conf_bad_toml.toml"))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  |
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/conf_bad_type.rs

@@ -1,6 +1,6 @@
 // error-pattern: error reading Clippy's configuration file: `blacklisted-names` is expected to be a `Vec < String >` but is a `integer`
 
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file="./tests/ui/conf_bad_type.toml"))]
 
 fn main() {}

tests/ui/conf_bad_type.stderr

@@ -1,4 +1,8 @@
-error: error reading Clippy's configuration file: invalid type: integer `42`, expected a sequence
-
-error: aborting due to previous error
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_bad_type.rs:4:1
+  |
+4 | #![plugin(clippy(conf_file="./$DIR/conf_bad_type.toml"))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  |
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/conf_french_blacklisted_name.rs

@@ -1,4 +1,4 @@
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file="./tests/auxiliary/conf_french_blacklisted_name.toml"))]
 
 #![allow(dead_code)]

tests/ui/conf_french_blacklisted_name.stderr

@@ -1,46 +1,8 @@
-error: use of a blacklisted/placeholder name `toto`
- --> $DIR/conf_french_blacklisted_name.rs:9:9
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_french_blacklisted_name.rs:2:1
   |
-9 | fn test(toto: ()) {}
-  |         ^^^^
+2 | #![plugin(clippy(conf_file="./tests/auxiliary/conf_french_blacklisted_name.toml"))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-  = note: `-D blacklisted-name` implied by `-D warnings`
-
-error: use of a blacklisted/placeholder name `toto`
-  --> $DIR/conf_french_blacklisted_name.rs:12:9
-   |
-12 |     let toto = 42;
-   |         ^^^^
-
-error: use of a blacklisted/placeholder name `tata`
-  --> $DIR/conf_french_blacklisted_name.rs:13:9
-   |
-13 |     let tata = 42;
-   |         ^^^^
-
-error: use of a blacklisted/placeholder name `titi`
-  --> $DIR/conf_french_blacklisted_name.rs:14:9
-   |
-14 |     let titi = 42;
-   |         ^^^^
-
-error: use of a blacklisted/placeholder name `toto`
-  --> $DIR/conf_french_blacklisted_name.rs:20:10
-   |
-20 |         (toto, Some(tata), titi @ Some(_)) => (),
-   |          ^^^^
-
-error: use of a blacklisted/placeholder name `tata`
-  --> $DIR/conf_french_blacklisted_name.rs:20:21
-   |
-20 |         (toto, Some(tata), titi @ Some(_)) => (),
-   |                     ^^^^
-
-error: use of a blacklisted/placeholder name `titi`
-  --> $DIR/conf_french_blacklisted_name.rs:20:28
-   |
-20 |         (toto, Some(tata), titi @ Some(_)) => (),
-   |                            ^^^^
-
-error: aborting due to 7 previous errors
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/conf_path_non_string.rs

@@ -1,5 +1,5 @@
 #![feature(attr_literals)]
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file=42))]
 
 fn main() {}

tests/ui/conf_path_non_string.stderr

@@ -1,14 +1,8 @@
-error: `conf_file` value must be a string
- --> $DIR/conf_path_non_string.rs:3:28
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_path_non_string.rs:3:1
   |
 3 | #![plugin(clippy(conf_file=42))]
-  |                            ^^
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-note: Clippy will use default configuration
- --> $DIR/conf_path_non_string.rs:3:28
-  |
-3 | #![plugin(clippy(conf_file=42))]
-  |                            ^^
-
-error: aborting due to previous error
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/conf_unknown_key.rs

@@ -1,6 +1,6 @@
 // error-pattern: error reading Clippy's configuration file: unknown key `foobar`
 
-#![feature(plugin)]
+
 #![plugin(clippy(conf_file="./tests/auxiliary/conf_unknown_key.toml"))]
 
 fn main() {}

tests/ui/conf_unknown_key.stderr

@@ -1,4 +1,8 @@
-error: error reading Clippy's configuration file: unknown field `foobar`, expected one of `blacklisted-names`, `cyclomatic-complexity-threshold`, `doc-valid-idents`, `too-many-arguments-threshold`, `type-complexity-threshold`, `single-char-binding-names-threshold`, `too-large-for-stack`, `enum-variant-name-threshold`, `enum-variant-size-threshold`, `third-party`
-
-error: aborting due to previous error
+error: compiler plugins are experimental and possibly buggy (see issue #29597)
+ --> $DIR/conf_unknown_key.rs:4:1
+  |
+4 | #![plugin(clippy(conf_file="./tests/auxiliary/conf_unknown_key.toml"))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  |
+  = help: add #![feature(plugin)] to the crate attributes to enable
 

tests/ui/copies.rs

@@ -1,5 +1,4 @@
-#![feature(plugin, inclusive_range_syntax)]
-#![plugin(clippy)]
+#![feature(dotdoteq_in_patterns, inclusive_range_syntax)]
 
 #![allow(dead_code, no_effect, unnecessary_operation)]
 #![allow(let_and_return)]
@@ -33,7 +32,7 @@ fn if_same_then_else() -> Result<&'static str, ()> {
         ..;
         0..;
         ..10;
-        0...10;
+        0..=10;
         foo();
     }
     else {
@@ -42,7 +41,7 @@ fn if_same_then_else() -> Result<&'static str, ()> {
         ..;
         0..;
         ..10;
-        0...10;
+        0..=10;
         foo();
     }
 
@@ -64,7 +63,7 @@ fn if_same_then_else() -> Result<&'static str, ()> {
         0..10;
     }
     else {
-        0...10;
+        0..=10;
     }
 
     if true {
@@ -161,7 +160,7 @@ fn if_same_then_else() -> Result<&'static str, ()> {
         let _ = match 42 {
             42 => 1,
             a if a > 0 => 2,
-            10...15 => 3,
+            10..=15 => 3,
             _ => 4,
         };
     }
@@ -172,7 +171,7 @@ fn if_same_then_else() -> Result<&'static str, ()> {
         let _ = match 42 {
             42 => 1,
             a if a > 0 => 2,
-            10...15 => 3,
+            10..=15 => 3,
             _ => 4,
         };
     }

tests/ui/copies.stderr

@@ -1,11 +1,11 @@
 error: This else block is redundant.
 
-   --> $DIR/copies.rs:121:20
+   --> $DIR/copies.rs:120:20
     |
-121 |               } else {
+120 |               } else {
     |  ____________________^
-122 | |                 continue;
-123 | |             }
+121 | |                 continue;
+122 | |             }
     | |_____________^
     |
     = note: `-D needless-continue` implied by `-D warnings`
@@ -18,12 +18,12 @@ error: This else block is redundant.
 
 error: This else block is redundant.
 
-   --> $DIR/copies.rs:131:20
+   --> $DIR/copies.rs:130:20
     |
-131 |               } else {
+130 |               } else {
     |  ____________________^
-132 | |                 continue;
-133 | |             }
+131 | |                 continue;
+132 | |             }
     | |_____________^
     |
     = help: Consider dropping the else clause and merging the code that follows (in the loop) with the if block, like so:
@@ -33,5 +33,3 @@ error: This else block is redundant.
             }
             
 
-error: aborting due to 2 previous errors
-

tests/ui/cyclomatic_complexity.rs

@@ -1,5 +1,5 @@
 #![feature(plugin, custom_attribute)]
-#![plugin(clippy)]
+
 #![allow(clippy)]
 #![warn(cyclomatic_complexity)]
 #![allow(unused)]

tests/ui/cyclomatic_complexity.stderr

@@ -269,5 +269,3 @@ error: the function has a cyclomatic complexity of 8
     |
     = help: you could split it up into multiple smaller functions
 
-error: aborting due to 20 previous errors
-

tests/ui/cyclomatic_complexity_attr_used.rs

@@ -1,5 +1,5 @@
 #![feature(plugin, custom_attribute)]
-#![plugin(clippy)]
+
 #![warn(cyclomatic_complexity)]
 #![warn(unused)]
 

tests/ui/cyclomatic_complexity_attr_used.stderr

@@ -13,5 +13,3 @@ error: the function has a cyclomatic complexity of 3
    = note: `-D cyclomatic-complexity` implied by `-D warnings`
    = help: you could split it up into multiple smaller functions
 
-error: aborting due to previous error
-

tests/ui/deprecated.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(str_to_string)]
 

tests/ui/deprecated.stderr

@@ -24,5 +24,3 @@ error: lint unstable_as_mut_slice has been removed: `Vec::as_mut_slice` has been
 10 | #[warn(unstable_as_mut_slice)]
    |        ^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 4 previous errors
-

tests/ui/derive.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![feature(untagged_unions)]
 

tests/ui/derive.stderr

@@ -106,5 +106,3 @@ note: consider deriving `Clone` or removing `Copy`
 87 | | }
    | |_^
 
-error: aborting due to 7 previous errors
-

tests/ui/diverging_sub_expression.rs

@@ -1,5 +1,5 @@
 #![feature(plugin, never_type)]
-#![plugin(clippy)]
+
 #![warn(diverging_sub_expression)]
 #![allow(match_same_arms, logic_bug)]
 

tests/ui/diverging_sub_expression.stderr

@@ -36,5 +36,3 @@ error: sub-expression diverges
 37 |             _ => true || break,
    |                          ^^^^^
 
-error: aborting due to 6 previous errors
-

tests/ui/dlist.rs

@@ -1,7 +1,7 @@
 #![feature(plugin, alloc)]
 #![feature(associated_type_defaults)]
 
-#![plugin(clippy)]
+
 #![warn(clippy)]
 #![allow(dead_code, needless_pass_by_value)]
 

tests/ui/dlist.stderr

@@ -47,5 +47,3 @@ error: I see you're using a LinkedList! Perhaps you meant some other data struct
    |
    = help: a VecDeque might work
 
-error: aborting due to 6 previous errors
-

tests/ui/doc.rs

@@ -1,7 +1,7 @@
 //! This file tests for the DOC_MARKDOWN lint
 
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![allow(dead_code)]
 #![warn(doc_markdown)]
 
@@ -159,3 +159,11 @@ fn issue_1469() {}
  *This would also be an error under a strict common mark interpretation
  */
 fn issue_1920() {}
+
+/// Ok: <http://www.unicode.org/reports/tr9/#Reordering_Resolved_Levels>
+///
+/// Not ok: http://www.unicode.org
+/// Not ok: https://www.unicode.org
+/// Not ok: http://www.unicode.org/
+/// Not ok: http://www.unicode.org/reports/tr9/#Reordering_Resolved_Levels
+fn issue_1832() {}

tests/ui/doc.stderr

@@ -156,5 +156,27 @@ error: you should put `be_sure_we_got_to_the_end_of_it` between ticks in the doc
 138 | /// be_sure_we_got_to_the_end_of_it
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 26 previous errors
+error: you should put bare URLs between `<`/`>` or make a proper Markdown link
+   --> $DIR/doc.rs:165:13
+    |
+165 | /// Not ok: http://www.unicode.org
+    |             ^^^^^^^^^^^^^^^^^^^^^^
+
+error: you should put bare URLs between `<`/`>` or make a proper Markdown link
+   --> $DIR/doc.rs:166:13
+    |
+166 | /// Not ok: https://www.unicode.org
+    |             ^^^^^^^^^^^^^^^^^^^^^^^
+
+error: you should put bare URLs between `<`/`>` or make a proper Markdown link
+   --> $DIR/doc.rs:167:13
+    |
+167 | /// Not ok: http://www.unicode.org/
+    |             ^^^^^^^^^^^^^^^^^^^^^^
+
+error: you should put bare URLs between `<`/`>` or make a proper Markdown link
+   --> $DIR/doc.rs:168:13
+    |
+168 | /// Not ok: http://www.unicode.org/reports/tr9/#Reordering_Resolved_Levels
+    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 

tests/ui/double_neg.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(double_neg)]
 fn main() {

tests/ui/double_neg.stderr

@@ -6,5 +6,3 @@ error: `--x` could be misinterpreted as pre-decrement by C programmers, is usual
   |
   = note: `-D double-neg` implied by `-D warnings`
 
-error: aborting due to previous error
-

tests/ui/double_parens.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(double_parens)]
 #![allow(dead_code)]

tests/ui/double_parens.stderr

@@ -30,5 +30,3 @@ error: Consider removing unnecessary double parentheses
 32 |     (())
    |     ^^^^
 
-error: aborting due to 5 previous errors
-

tests/ui/drop_forget_copy.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(drop_copy, forget_copy)]
 #![allow(toplevel_ref_arg, drop_ref, forget_ref, unused_mut)]

tests/ui/drop_forget_copy.stderr

@@ -72,5 +72,3 @@ note: argument has type SomeStruct
 42 |     forget(s4);
    |            ^^
 
-error: aborting due to 6 previous errors
-

tests/ui/drop_forget_ref.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(drop_ref, forget_ref)]
 #![allow(toplevel_ref_arg, similar_names, needless_pass_by_value)]

tests/ui/drop_forget_ref.stderr

@@ -216,5 +216,3 @@ note: argument has type &SomeStruct
 59 |     std::mem::forget(&SomeStruct);
    |                      ^^^^^^^^^^^
 
-error: aborting due to 18 previous errors
-

tests/ui/duplicate_underscore_argument.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![warn(duplicate_underscore_argument)]
 #[allow(dead_code, unused)]

tests/ui/duplicate_underscore_argument.stderr

@@ -6,5 +6,3 @@ error: `darth` already exists, having another argument having almost the same na
   |
   = note: `-D duplicate-underscore-argument` implied by `-D warnings`
 
-error: aborting due to previous error
-

tests/ui/empty_enum.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #![allow(dead_code)]
 #![warn(empty_enum)]

tests/ui/empty_enum.stderr

@@ -11,5 +11,3 @@ help: consider using the uninhabited type `!` or a wrapper around it
 7 | enum Empty {}
   | ^^^^^^^^^^^^^
 
-error: aborting due to previous error
-

tests/ui/entry.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![allow(unused, needless_pass_by_value)]
 
 #![warn(map_entry)]

tests/ui/entry.stderr

@@ -42,5 +42,3 @@ error: usage of `contains_key` followed by `insert` on a `BTreeMap`
 37 |     if !m.contains_key(&k) { foo(); m.insert(k, v) } else { None };
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `m.entry(k)`
 
-error: aborting due to 7 previous errors
-

tests/ui/enum_glob_use.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(clippy, clippy_pedantic)]
 #![allow(unused_imports, dead_code, missing_docs_in_private_items)]
 

tests/ui/enum_glob_use.stderr

@@ -12,5 +12,3 @@ error: don't use glob imports for enum variants
 12 | use self::Enum::*;
    | ^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 2 previous errors
-

tests/ui/enum_variants.rs

@@ -1,5 +1,5 @@
 #![feature(plugin, non_ascii_idents)]
-#![plugin(clippy)]
+
 #![warn(clippy, pub_enum_variant_names)]
 
 enum FakeCallType {

tests/ui/enum_variants.stderr

@@ -97,5 +97,3 @@ error: All variants have the same prefix: `With`
    = note: `-D pub-enum-variant-names` implied by `-D warnings`
    = help: remove the prefixes and use full paths to the variants instead of glob imports
 
-error: aborting due to 10 previous errors
-

tests/ui/enums_clike.rs

@@ -1,6 +1,6 @@
 // ignore-x86
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![warn(clippy)]
 
 #![allow(unused)]

tests/ui/enums_clike.stderr

@@ -48,5 +48,3 @@ error: Clike enum variant discriminant is not portable to 32-bit targets
 37 |     A = 0x1_0000_0000,
    |     ^^^^^^^^^^^^^^^^^
 
-error: aborting due to 8 previous errors
-

tests/ui/eq_op.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(eq_op)]
 #[allow(identity_op, double_parens, many_single_char_names)]

tests/ui/eq_op.stderr

@@ -204,5 +204,3 @@ error: taken reference of right operand
    |
    = note: `-D op-ref` implied by `-D warnings`
 
-error: aborting due to 33 previous errors
-

tests/ui/escape_analysis.rs

@@ -1,5 +1,5 @@
 #![feature(plugin, box_syntax)]
-#![plugin(clippy)]
+
 #![allow(warnings, clippy)]
 
 #![warn(boxed_local)]

tests/ui/eta.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 #![allow(unknown_lints, unused, no_effect, redundant_closure_call, many_single_char_names, needless_pass_by_value)]
 #![warn(redundant_closure)]
 

tests/ui/eta.stderr

@@ -32,5 +32,3 @@ error: redundant closure found
 18 |     let e = Some(1u8).map(|a| generic(a));
    |                           ^^^^^^^^^^^^^^ help: remove closure as shown: `generic`
 
-error: aborting due to 5 previous errors
-

tests/ui/eval_order_dependence.rs

@@ -1,5 +1,5 @@
-#![feature(plugin)]
-#![plugin(clippy)]
+
+
 
 #[warn(eval_order_dependence)]
 #[allow(unused_assignments, unused_variables, many_single_char_names, no_effect, dead_code, blacklisted_name)]