Suggest copied or cloned

This commit is contained in:
Michael Goulet 2022-09-03 07:29:57 +00:00
parent 0209485578
commit fdbede7ad8
5 changed files with 194 additions and 0 deletions

View file

@ -0,0 +1,23 @@
// run-rustfix
fn expect<T>(_: T) {}
fn main() {
let x = Some(&());
expect::<Option<()>>(x.copied());
//~^ ERROR mismatched types
//~| HELP use `Option::copied` to copy the value inside the `Option`
let x = Ok(&());
expect::<Result<(), ()>>(x.copied());
//~^ ERROR mismatched types
//~| HELP use `Result::copied` to copy the value inside the `Result`
let s = String::new();
let x = Some(&s);
expect::<Option<String>>(x.cloned());
//~^ ERROR mismatched types
//~| HELP use `Option::cloned` to clone the value inside the `Option`
let x = Ok(&s);
expect::<Result<String, ()>>(x.cloned());
//~^ ERROR mismatched types
//~| HELP use `Result::cloned` to clone the value inside the `Result`
}

View file

@ -0,0 +1,23 @@
// run-rustfix
fn expect<T>(_: T) {}
fn main() {
let x = Some(&());
expect::<Option<()>>(x);
//~^ ERROR mismatched types
//~| HELP use `Option::copied` to copy the value inside the `Option`
let x = Ok(&());
expect::<Result<(), ()>>(x);
//~^ ERROR mismatched types
//~| HELP use `Result::copied` to copy the value inside the `Result`
let s = String::new();
let x = Some(&s);
expect::<Option<String>>(x);
//~^ ERROR mismatched types
//~| HELP use `Option::cloned` to clone the value inside the `Option`
let x = Ok(&s);
expect::<Result<String, ()>>(x);
//~^ ERROR mismatched types
//~| HELP use `Result::cloned` to clone the value inside the `Result`
}

View file

@ -0,0 +1,83 @@
error[E0308]: mismatched types
--> $DIR/copied-and-cloned.rs:7:26
|
LL | expect::<Option<()>>(x);
| -------------------- ^ expected `()`, found `&()`
| |
| arguments to this function are incorrect
|
= note: expected enum `Option<()>`
found enum `Option<&()>`
note: function defined here
--> $DIR/copied-and-cloned.rs:3:4
|
LL | fn expect<T>(_: T) {}
| ^^^^^^ ----
help: use `Option::copied` to copy the value inside the `Option`
|
LL | expect::<Option<()>>(x.copied());
| +++++++++
error[E0308]: mismatched types
--> $DIR/copied-and-cloned.rs:11:30
|
LL | expect::<Result<(), ()>>(x);
| ------------------------ ^ expected `()`, found `&()`
| |
| arguments to this function are incorrect
|
= note: expected enum `Result<(), ()>`
found enum `Result<&(), _>`
note: function defined here
--> $DIR/copied-and-cloned.rs:3:4
|
LL | fn expect<T>(_: T) {}
| ^^^^^^ ----
help: use `Result::copied` to copy the value inside the `Result`
|
LL | expect::<Result<(), ()>>(x.copied());
| +++++++++
error[E0308]: mismatched types
--> $DIR/copied-and-cloned.rs:16:30
|
LL | expect::<Option<String>>(x);
| ------------------------ ^ expected struct `String`, found `&String`
| |
| arguments to this function are incorrect
|
= note: expected enum `Option<String>`
found enum `Option<&String>`
note: function defined here
--> $DIR/copied-and-cloned.rs:3:4
|
LL | fn expect<T>(_: T) {}
| ^^^^^^ ----
help: use `Option::cloned` to clone the value inside the `Option`
|
LL | expect::<Option<String>>(x.cloned());
| +++++++++
error[E0308]: mismatched types
--> $DIR/copied-and-cloned.rs:20:34
|
LL | expect::<Result<String, ()>>(x);
| ---------------------------- ^ expected struct `String`, found `&String`
| |
| arguments to this function are incorrect
|
= note: expected enum `Result<String, ()>`
found enum `Result<&String, _>`
note: function defined here
--> $DIR/copied-and-cloned.rs:3:4
|
LL | fn expect<T>(_: T) {}
| ^^^^^^ ----
help: use `Result::cloned` to clone the value inside the `Result`
|
LL | expect::<Result<String, ()>>(x.cloned());
| +++++++++
error: aborting due to 4 previous errors
For more information about this error, try `rustc --explain E0308`.