Commit graph

23 commits

Author SHA1 Message Date
Michael Howell
24913bd768 rustdoc: remove unneeded position: relative setting CSS
This was added to control percentage sizes, in
79956b96e8

Now, the only percentage size is [`border-radius`], which is
based on the size of the box itself, not its containing block.
This leaves the property unused.

[`border-radius`]: https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius
2023-05-22 16:46:29 -07:00
Michael Howell
5570fdae88 rustdoc: merge identical CSS rules 2023-05-22 16:40:01 -07:00
Michael Howell
1d0f34fd77 rustdoc: remove unused CSS color: inherit
This code was added back when `border-color: currentColor` was used.
Since it was changed in ad9a89eef2, the
current color is not used any more.
2023-04-21 17:07:42 -07:00
Michael Howell
ad9a89eef2 rustdoc: make settings radio and checks thicker, less contrast
This is very dependent on subjectivity and what screen you use,
but this change makes the radio buttons' outer circle less ugly.

This is because I could see the pixels very clearly, thanks to the
very thin line and high contrast. This change makes both less
severe, giving your browser's antialiasing algorithm more to
work with. Since it's thicker, lowering the contrast shouldn't
impact visibility.
2023-04-12 08:39:43 -07:00
Michael Howell
31c14f6c5d rustdoc: remove unused CSS from .setting-check
These rules were needed for the mobile-style switches, but those
were removed in 0f3ae6218e
2023-01-30 16:36:57 -07:00
Michael Howell
5dd87c58aa rustdoc: simplify settings popover DOM
* Changes the class names so that they all start with `setting-`.
  That should make it harder to accidentally use a setting class outside
  the settings popover, where loading the CSS might accidentally change
  the styles of something unrelated.
* Get rid of an unnecessary wrapper DIV around the radio button line.
* Simplify CSS selectors by making the DOM easier and more intuitive
  to target.
2023-01-23 15:08:33 -07:00
Michael Howell
112d85c1ec rustdoc: use CSS inline layout for radio line instead of flexbox
This uses less code to lay them out the same way.
2023-01-20 14:28:16 -07:00
Michael Howell
9ee4df0e9c rustdoc: remove redundant rule #settings .setting-line
Since the current version of settings.js always nests things below
a div with ID `settings`, this rule always overrode the one above.
2023-01-18 12:39:13 -07:00
Michael Howell
54089e6390 rustdoc: instead of .setting-name { width: 100% }, use default div CSS 2023-01-17 11:49:36 -07:00
Michael Howell
1d328de3ec rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle
This swaps things around so that the class that gets used more often has
the shorter name.
2023-01-13 12:38:03 -07:00
Michael Howell
88aaaa6135 rustdoc: remove unused CSS .sub-settings
Obsoleted when 9625ed8be7 changed the DOM.
2022-12-15 12:27:32 -07:00
Michael Howell
0f3ae6218e rustdoc: use checkbox instead of switch for settings toggles
The switch is designed to give the application a "physical" feel, but
nothing else in here really followed through. They didn't support the
"flick" gesture that real iOS switches support, and the radio
buttons that were also used in Rustdoc Settings were a more "classic"
form element anyway.

Also, while "switches" are the exclusive toggle design on iOS (since
[Apple HIG] reserves checkboxes for Mac only), the [Google Material]
guidelines say that lists of switches are bad, and you should just use
check boxes.

[Apple HIG]: https://developer.apple.com/design/human-interface-guidelines/components/selection-and-input/toggles
[Google Material]: https://m3.material.io/components/checkbox/guidelines#6902f23d-ceba-4b19-ae3b-b78b9b01d185
2022-11-10 17:22:37 -07:00
Michael Howell
db570586a5 rustdoc: move setting-line color CSS to settings.css 2022-10-19 09:24:09 -07:00
Michael Howell
f55ea418c3 rustdoc: clean up "normalize.css 8" input override CSS
These rules were copied from normalize.css 3, and are mostly redundant.

* `optgroup` isn't used in rustdoc at all
* `textarea` is only used for the "copy" button, so it's not visible
* The remaining buttons and inputs mostly have styles set anyway.
* We should never be setting `color` without also setting the
  background to something. Otherwise, you get white-on-gray
  text. That seems to be [the reason] why `normalize.css` changed this.

[the reason]: https://github.com/necolas/normalize.css/pull/502
2022-09-28 15:39:27 -07:00
Guillaume Gomez
9d118c5dca Fix settings display on small screen size 2022-07-27 14:45:12 +02:00
Guillaume Gomez
cc4f804829 Move help popup into a pocket menu as well 2022-06-23 00:22:25 +02:00
Guillaume Gomez
5b6c5933cc Move theme rules out of settings.css 2022-05-30 12:12:43 +02:00
Guillaume Gomez
e8d0fbf4eb Improve display of settings radio buttons 2022-05-30 12:12:43 +02:00
Guillaume Gomez
1ebf0d9c72 Allow to click on toggle text to update it 2022-05-24 15:40:50 +02:00
Guillaume Gomez
92482cabaa Remove unused CSS settings rules 2022-05-11 11:27:13 +02:00
Jacob Hoffman-Andrews
c790128c3c Improve wrapping on settings page
Previously, the radio button choices for themes would wrap awkwardly on
narrow screens. With this change, the group of choices will prefer
bumping down to the next line together, leaving the setting name on its
own line.

Also fix some minor spacing issues:

 - Align the setting name vertically with the radio button choices.
 - Use margin instead of padding for most spacing choices.
 - Use no margin/padding on the right-hand side.
2022-01-31 01:46:10 -08:00
Jacob Hoffman-Andrews
11b17c6c04 rustdoc settings: use radio buttons for theme
This reduces the number of clicks required to change theme.

Also, simplify the UI a bit (remove setting grouping), and add a "Back"
link close to the settings icon.
2022-01-23 15:55:50 -08:00
Guillaume Gomez
e5c24ba400 Clean up rustdoc static files 2021-07-07 17:52:18 +02:00
Renamed from src/librustdoc/html/static/settings.css (Browse further)