Guillaume Gomez
116c5a25e7
Add eslint key-spacing check
2022-05-20 20:27:35 +02:00
Guillaume Gomez
b036fd378b
Add eslint arrow-spacing check
2022-05-20 20:27:34 +02:00
Guillaume Gomez
8fe333abd0
Add new lint to enforce whitespace after keywords
2022-05-19 17:19:22 +02:00
Guillaume Gomez
72496d88d3
Move some DOM generation into the HTML settings file directly
2022-05-18 11:40:15 +02:00
Yuki Okushi
b8dd27079c
Rollup merge of #97113 - GuillaumeGomez:search-ui-fixes, r=notriddle
...
Search GUI fixes
The first fix is about the duplicated "in":

The second fix is about the `<select>` broken style:


You can test it [here](https://rustdoc.crud.net/imperio/search-ui-fixes/doc/foo/index.html?search=test ).
r? `@notriddle`
2022-05-18 07:41:00 +09:00
Jacob Hoffman-Andrews
453979462a
rustdoc: make search.js a module
...
Previously, search.js relied on the DOM and the `window` object. It can now be
loaded in the absence of the DOM, for instance by Node. The same is true of
search-index.js.
This allows removing a lot of code from src/tools/rustdoc-js/tester.js that
tried to parse search.js and extract specific functions that were needed for
testing.
2022-05-17 09:26:18 -07:00
Guillaume Gomez
0f8b3f4cae
Fix display of search crate filter select
2022-05-17 14:20:34 +02:00
Guillaume Gomez
d765b73a01
Fix duplicated "in" in the search result text
2022-05-17 13:15:49 +02:00
Guillaume Gomez
5d84c0c569
Add new eslint rule about brace style
2022-05-15 13:59:51 +02:00
Guillaume Gomez
e8762757c3
Remove theme picker button
2022-05-14 17:21:52 +02:00
Guillaume Gomez
5e01ba36c9
Improve settings menu display
2022-05-14 17:21:52 +02:00
Yuki Okushi
93a4dfd737
Rollup merge of #96998 - notriddle:notriddle/var-N, r=jsha
...
rustdoc: remove weird, unused variable from source-files.js
2022-05-14 13:42:52 +09:00
Michael Howell
1b41d11d74
rustdoc: remove weird, unused variable from source-files.js
2022-05-12 17:34:46 -07:00
Michael Howell
d3fd6bfd30
rustdoc: fix GUI crash when searching for magic JS property values
2022-05-12 14:15:31 -07:00
bors
c6499fd998
Auto merge of #96974 - matthiaskrgr:rollup-jd4otnc, r=matthiaskrgr
...
Rollup of 5 pull requests
Successful merges:
- #95896 (Note the contacts for the nvptx64 target(s))
- #96860 (openbsd: convert futex timeout managment to Timespec usage)
- #96939 (Fix settings page CSS)
- #96941 (update graphviz links)
- #96968 (Add tests for #96806 )
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-05-12 15:07:35 +00:00
Matthias Krüger
231cd0fd7d
Rollup merge of #96939 - GuillaumeGomez:settings-css, r=notriddle
...
Fix settings page CSS
In https://github.com/rust-lang/rust/pull/96741 , I moved the CSS loading outside of `settings.js`. The result was that on the settings page, there isn't the settings CSS anymore:

I also used this opportunity to remove unused CSS rules (we don't have `<select>` elements anymore in the settings).
cc `@jsha`
r? `@notriddle`
2022-05-12 16:41:04 +02:00
bors
481db40311
Auto merge of #95562 - lcnr:attr-no-encode, r=davidtwco
...
don't encode only locally used attrs
Part of https://github.com/rust-lang/compiler-team/issues/505 .
We now filter builtin attributes before encoding them in the crate metadata in case they should only be used in the local crate. To prevent accidental misuse `get_attrs` now requires the caller to state which attribute they are interested in. For places where that isn't trivially possible, I've added a method `fn get_attrs_unchecked` which I intend to remove in a followup PR.
After this pull request landed, we can then slowly move all attributes to only be used in the local crate while being certain that we don't accidentally try to access them from extern crates.
cc https://github.com/rust-lang/rust/pull/94963#issuecomment-1082924289
2022-05-12 12:48:30 +00:00
Guillaume Gomez
92482cabaa
Remove unused CSS settings rules
2022-05-11 11:27:13 +02:00
Guillaume Gomez
84615e868b
Add missing CSS file for settings page
2022-05-11 11:27:00 +02:00
Yuki Okushi
95b2d37a39
Rollup merge of #96900 - GuillaumeGomez:fix-js-error, r=notriddle
...
Fix js error
On the source code pages, we get a JS error:

It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test.
cc ``@jsha``
r? ``@notriddle``
2022-05-11 13:16:33 +09:00
Yuki Okushi
d34915f691
Rollup merge of #96879 - notriddle:notriddle/search-ranking, r=GuillaumeGomez
...
rustdoc: search result ranking fix
# Before

# After

2022-05-11 00:09:35 +09:00
Guillaume Gomez
f9fc7ef097
Remove unused CSS rule
2022-05-10 16:40:32 +02:00
Guillaume Gomez
f82b3a16d5
Fix JS error in source code pages
2022-05-10 16:40:14 +02:00
lcnr
bae84a484c
update rustdoc
2022-05-10 12:07:35 +02:00
Michael Howell
360d6e4b7d
rustdoc: search result ranking fix
2022-05-09 11:49:05 -07:00
Matthias Krüger
59722228b9
Rollup merge of #96858 - notriddle:notriddle/cleanup-search-js, r=GuillaumeGomez
...
Remove unused param from search.js::checkPath
2022-05-09 18:45:40 +02:00
Michael Howell
521d2c3d3c
Remove unused param from search.js::checkPath
2022-05-08 22:19:40 -07:00
bors
8a2fe75d0e
Auto merge of #95960 - jhpratt:remove-rustc_deprecated, r=compiler-errors
...
Remove `#[rustc_deprecated]`
This removes `#[rustc_deprecated]` and introduces diagnostics to help users to the right direction (that being `#[deprecated]`). All uses of `#[rustc_deprecated]` have been converted. CI is expected to fail initially; this requires #95958 , which includes converting `stdarch`.
I plan on following up in a short while (maybe a bootstrap cycle?) removing the diagnostics, as they're only intended to be short-term.
2022-05-09 04:47:30 +00:00
Guillaume Gomez
1e93165b05
Enforce no trailing spaces with eslint
2022-05-08 14:08:33 +02:00
Guillaume Gomez
b7e5116375
Enforce linebreak style in js source code
2022-05-08 14:07:25 +02:00
Guillaume Gomez
14897180ae
Enforce quote rule for JS source code
2022-05-07 20:50:55 +02:00
Guillaume Gomez
f98f92fdaf
Rollup merge of #96805 - Folyd:eslint, r=GuillaumeGomez
...
Change eslint rules from configuration comments to configuration file
Repeatedly declaring eslint rules in source files is an annoying thing, we should move those rules into the eslint configuration file.
r? ``@GuillaumeGomez``
2022-05-07 15:23:48 +02:00
Guillaume Gomez
3346d11f4e
Rollup merge of #96636 - GuillaumeGomez:fix-jump-to-def-regression, r=notriddle
...
Fix jump to def regression
https://github.com/rust-lang/rust/pull/93803 introduced a regression in the "jump to def" feature. This fixes it.
Nice side-effect: it adds a new regression test. :)
I also used this opportunity to add documentation about this unstable feature in the rustdoc book.
cc ``@cjgillot``
r? ``@notriddle``
2022-05-07 15:23:45 +02:00
Folyd
a8ede1248d
Change eslint rules from configuration comments to configuration files
2022-05-07 11:47:30 +08:00
Guillaume Gomez
5c7ce84d74
Remove unneeded SpanMapVisitor::visit_generics function
2022-05-06 22:01:30 +02:00
Guillaume Gomez
bcfb95afd3
Rollup merge of #96754 - notriddle:notriddle/impl-dups, r=GuillaumeGomez
...
rustdoc: ensure HTML/JS side implementors don't have dups
Fixes #94641
Rendered:
- https://notriddle.com/notriddle-rustdoc-test/impl-dups/std/iter/trait.Iterator.html
- https://notriddle.com/notriddle-rustdoc-test/impl-dups/core/iter/trait.Iterator.html
2022-05-06 20:05:43 +02:00
Guillaume Gomez
93b86d69b6
Rollup merge of #96748 - GuillaumeGomez:reexports-in-search, r=notriddle
...
Fixes reexports in search
Fixes #96681 .
At some point we stopped reexporting items in search so this PR fixes it.
It also adds a regression test.
r? ```@notriddle```
2022-05-06 20:05:41 +02:00
Guillaume Gomez
fcb0bce25c
Rollup merge of #96590 - notriddle:notriddle/tab-bar-fn-search, r=GuillaumeGomez,jsha
...
rustdoc: when running a function-signature search, tweak the tab bar
# Before

# After

2022-05-06 20:05:38 +02:00
Guillaume Gomez
279dee5374
Fix reexports missing from the search index
2022-05-06 13:52:21 +02:00
Michael Goulet
7cdad77536
Rollup merge of #96741 - GuillaumeGomez:improve-settings-loading-strategy, r=jsha
...
Improve settings loading strategy
I learned about this thanks to ```@jsha``` who suggested this approach:
It improves the settings loading strategy by loading CSS and JS at the same time to prevent the style to be applied afterwards on slow connections.
r? ```@jsha```
2022-05-05 19:34:25 -07:00
Michael Goulet
292eefe753
Rollup merge of #96704 - GuillaumeGomez:rotation-animation, r=jsha
...
Add rotation animation on settings button when loading
As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like):
https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4
r? ````@jsha````
2022-05-05 19:34:24 -07:00
Michael Howell
20010d7597
rustdoc: ensure HTML/JS side implementors don't have dups
2022-05-05 17:45:33 -07:00
Guillaume Gomez
87b6326d67
Improve settings loading strategy by loading CSS and JS at the same time to prevent the style to be applied afterwards on slow connections
2022-05-05 20:19:40 +02:00
Michael Howell
4c183cd2d4
rustdoc: fix JS error when rendering parse error
2022-05-05 09:39:47 -07:00
Michael Howell
8b2147b497
rustdoc: fix keyboard shortcuts and console log on search page
2022-05-05 09:39:45 -07:00
Michael Howell
21a121332b
rustdoc: change the "In Function Signatures" to context-sensitive
...
* If it's just `-> a`, use "In Function Return Types"
* If it's just `a b`, use "In Function Parameters"
* Otherwise, still use "In Function Signatures"
2022-05-05 09:37:29 -07:00
Michael Howell
6c8a2d4715
rustdoc: when running a function-signature search, tweak the tab bar
2022-05-05 09:37:29 -07:00
Guillaume Gomez
13b45aa6c6
Add rotation animation on settings button when loading
2022-05-05 11:08:15 +02:00
Guillaume Gomez
1e204ddb3b
Use "strict" mode in JS scripts
2022-05-05 11:07:14 +02:00
Folyd
67ebeea7a0
Move callback to the () => {} syntax.
...
Fix lint
Fix main.js
Restore anonymous functions
Fix
Fix more
2022-05-04 11:10:48 +08:00