Alex Macleod
6fc6d87fd0
Migrate write.rs to a late pass
2022-09-08 20:18:02 +00:00
Philipp Krones
4ee55c5528
Merge remote-tracking branch 'upstream/auto' into rustup
2022-09-08 21:27:09 +02:00
Caio
51d8b6c664
Rename the arithmetic lint
2022-09-08 12:04:55 -03:00
bors
ce339b219a
Auto merge of #101241 - camsteffen:refactor-binding-annotations, r=cjgillot
...
`BindingAnnotation` refactor
* `ast::BindingMode` is deleted and replaced with `hir::BindingAnnotation` (which is moved to `ast`)
* `BindingAnnotation` is changed from an enum to a tuple struct e.g. `BindingAnnotation(ByRef::No, Mutability::Mut)`
* Associated constants added for convenience `BindingAnnotation::{NONE, REF, MUT, REF_MUT}`
One goal is to make it more clear that `BindingAnnotation` merely represents syntax `ref mut` and not the actual binding mode. This was especially confusing since we had `ast::BindingMode`->`hir::BindingAnnotation`->`thir::BindingMode`.
I wish there were more symmetry between `ByRef` and `Mutability` (variant) naming (maybe `Mutable::Yes`?), and I also don't love how long the name `BindingAnnotation` is, but this seems like the best compromise. Ideas welcome.
2022-09-06 03:16:29 +00:00
Takayuki Maeda
4bcaddeeb2
separate the receiver from arguments in HIR under /clippy
2022-09-05 22:25:57 +09:00
Dylan DPC
9ae329232b
Rollup merge of #101142 - nnethercote:improve-hir-stats, r=davidtwco
...
Improve HIR stats
#100398 improve the AST stats collection done by `-Zhir-stats`. This PR does the same for HIR stats collection.
r? `@davidtwco`
2022-09-05 14:15:51 +05:30
Cameron Steffen
e5f30f4dfa
clippy: BindingAnnotation change
2022-09-02 13:03:11 -05:00
Jason Newcomb
fb41bfa774
Merge commit ' f51aade56f' into clippyup
2022-08-31 09:24:45 -04:00
Lukas Lueg
66a97055b2
Initial implementation of result_large_err
2022-08-30 17:39:40 +02:00
Nicholas Nethercote
3b80e994d5
Use &'hir Expr everywhere.
...
For consistency, and because it makes HIR measurement simpler and more
accurate.
2022-08-29 06:35:14 +10:00
Jason Newcomb
9790a3291b
Fixes for latest nightly
2022-08-28 06:44:22 -04:00
Jason Newcomb
3ad398d9b0
Merge branch 'master' into rustup
2022-08-28 06:44:13 -04:00
Nicholas Nethercote
06d7119f40
Remove the symbol from ast::LitKind::Err.
...
Because it's never used meaningfully.
2022-08-23 16:56:24 +10:00
bors
679fa9f2bf
Auto merge of #9187 - sgued:iter-once, r=flip1995
...
Add lint recommending using `std::iter::once` and `std::iter::empty`
```
changelog: [`iter_once`]: add new lint
changelog: [`iter_empty`]: add new lint
```
fixes #9186
- \[ ] Followed [lint naming conventions][lint_naming]
- \[x] Added passing UI tests (including committed `.stderr` file)
- \[x] `cargo test` passes locally
- \[x] Executed `cargo dev update_lints`
- \[x] Added lint documentation
- \[x] Run `cargo dev fmt`
[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
The lint doesn't really follow the naming conventions. I don't have any better idea so I'm open to suggestions.
2022-08-14 15:45:17 +00:00
Philipp Krones
dc29cfb8d5
Merge commit ' 2b2190cb56' into clippyup
2022-08-11 19:42:16 +02:00
Philipp Krones
879855bbaf
Merge remote-tracking branch 'upstream/master' into rustup
2022-08-11 19:26:04 +02:00
Sosthène Guédon
332e03146e
Fix the lint in clippy itself
2022-08-08 21:04:44 +02:00
alex-semenyuk
7062a013e7
Fix some typos
2022-08-04 19:53:07 +03:00
Miguel Guarniz
29a0f69f9c
Rename local_did to def_id
...
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
2022-07-29 18:26:10 -04:00
Miguel Guarniz
ca0996e3a0
Change maybe_body_owned_by to take local def id
...
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
2022-07-29 18:25:58 -04:00
Andy Caldwell
66b46749e6
Change lint name to plural
2022-07-29 19:35:39 +01:00
Andy Caldwell
2f48257cfb
Rename "blacklisted name" to "disallowed name" throughout
2022-07-29 19:35:18 +01:00
Andy Caldwell
ea25ef10cf
Harden duplicates checking and add tests
2022-07-28 23:05:24 +01:00
Philipp Krones
67c405cc1d
Merge commit ' 3c7e7dbc15' into clippyup
2022-07-28 19:08:22 +02:00
Philipp Krones
08e7ec4047
Read and use deprecated configuration (as well as emitting a warning)
...
Co-authored-by: Andy Caldwell <andycaldwell@microsoft.com>
2022-07-27 17:47:20 +01:00
Caio
31e5465f8a
Add Arithmetic lint
2022-07-18 14:29:45 -03:00
Xiretza
7a5965b459
unused_self: respect avoid-breaking-exported-api
2022-07-18 10:57:08 +02:00
Philipp Krones
7d4daaa8fa
Merge commit ' fdb84cbfd2' into clippyup
2022-07-18 09:39:37 +02:00
Philipp Krones
f074034590
Merge remote-tracking branch 'upstream/master' into rustup
2022-07-15 09:49:15 +02:00
bors
0930ac91b9
Fix typos
...
changelog: none
2022-07-13 14:48:32 +00:00
Maybe Waffle
1c3f62c750
Fix clippy build
2022-07-12 21:00:14 +04:00
Josh Triplett
b7230d4f44
Dogfood fixes to use bool::then_some
2022-07-06 02:03:56 -07:00
Philipp Krones
09f5df5087
Merge commit ' 0cb0f76368' into clippyup
2022-06-30 10:50:09 +02:00
Philipp Krones
f26cf11fe8
Merge remote-tracking branch 'upstream/master' into rustup
2022-06-30 10:27:25 +02:00
bors
57e7e1d7d8
Auto merge of #8871 - Serial-ATA:cargo-dev-deprecate, r=giraffate
...
Add `cargo dev deprecate`
changelog: none
I wrote this awhile ago when `regex` was still a dependency. Is it alright to add it back?
2022-06-27 00:32:22 +00:00
Serial
aec465cabd
Add test for [default_deprecation_reason]
2022-06-24 14:11:24 -04:00
bors
6985e6592b
Auto merge of #9028 - kyoto7250:issue_8798, r=xFrednet
...
confirm using chain in collapsible_span_lint_calls
close #8798
This PR fixes false positive when using chain in `collapsible_span_lint_calls`.
changelog: None
2022-06-22 22:35:21 +00:00
Serial
890fd0e3c1
Remove cargo_dev dependency
2022-06-21 14:04:37 -04:00
Serial
2bd1581bbf
Add dev deprecate
2022-06-21 13:43:47 -04:00
kyoto7250
4a4b5cf061
confirm using chain in collapsible_span_lint_calls
2022-06-20 13:17:54 +09:00
Maybe Waffle
9395c261d6
remove span_lint_and_sugg_for_edges from clippy utils
2022-06-19 23:21:14 +04:00
flip1995
f8f9d01c2a
Merge commit ' d7b5cbf065' into clippyup
2022-06-16 17:39:06 +02:00
flip1995
c5c8f6122f
Merge remote-tracking branch 'upstream/master' into rustup
2022-06-16 16:04:06 +02:00
bors
5a45805db5
Auto merge of #8947 - Serial-ATA:lint-produces-output, r=xFrednet
...
Add lint output to lint list
changelog: Add the ability to show the lint output in the lint list
This just adds the logic to produce the output, it hasn't been added to any lints yet. It did help find some mistakes in some docs though 😄 .
### Screenshots
<details>
<summary>A single code block</summary>
</details>
<details>
<summary>A single code block with a "Use instead" section</summary>
</details>
<details>
<summary>Multiple code blocks</summary>
</details>
This is the last task in #7172 🎉 .
r? `@xFrednet` (?)
2022-06-14 10:42:09 +00:00
Camille GILLOT
7b84a97c3e
Make ExprKind::Closure a struct variant.
2022-06-12 00:16:27 +02:00
bors
4970527296
Auto merge of #8954 - Serial-ATA:doc-comment-issues, r=xFrednet
...
Improve lint doc consistency
changelog: none
This is a continuation of #8908 .
Notable changes:
- Removed empty `Known Problems` sections
- Removed "Good"/"Bad" language (replaced with "Use instead")
- Removed (and added some 😄 ) duplication
- Ignored the [`create_dir`] example so it doesn't create `clippy_lints/foo` 😄
2022-06-09 11:03:49 +00:00
Serial
fdadebe672
Add lint output to lint list
2022-06-06 20:04:56 -04:00
Serial
9aeed6b9bf
Improve lint doc consistency
2022-06-05 16:03:18 -04:00
xFrednet
c31b4a9d21
List configuration values can now be extended instead of replaced
2022-06-04 16:03:25 +02:00
Philipp Krones
f067783461
Merge commit ' d9ddce8a22' into clippyup
2022-06-04 13:34:07 +02:00
