y21
8fad54e8f9
new lint: read_line_without_trim
2023-07-03 22:51:38 +02:00
bors
c46ddeb9e1
Auto merge of #10987 - y21:type_id_on_box, r=llogiq
...
new lint: `type_id_on_box`
Closes #7687 .
A new lint that detects calling `.type_id()` on `Box<dyn Any>` (and not on the underlying `dyn Any`), which can make up for some pretty confusing bugs!
changelog: new lint: [`type_id_on_box`]
2023-07-03 06:16:14 +00:00
Catherine
cb5d7e344a
address comments
2023-07-01 12:37:16 -05:00
Catherine
fbb3f759e2
update docs
2023-07-01 12:36:02 -05:00
Catherine
354172a18e
New lint manual_try_fold
2023-07-01 12:36:02 -05:00
darklyspaced
c378bf9ddf
Revert "now passes dogfood by wrapping unwrap_recv and unwrap_arg into a tuple"
...
This reverts commit 7b91844a3207d90d4200a7b53d0ae1a7a1dca73a.
2023-06-27 11:29:02 +08:00
darklyspaced
b832175b2d
now passes dogfood by wrapping unwrap_recv and unwrap_arg into a tuple
...
was previously failing due to `check` having to many arguments.
2023-06-27 11:29:02 +08:00
darklyspaced
c60222dc12
changed the msrv to 1.70 to suggest is_some_and
...
if the msrv is not >= 1.70 then the `map_or` is suggested instead of `is_some_and` (even when `unwrap_or` returns false)
2023-06-27 11:29:02 +08:00
darklyspaced
9b7d8d1dc7
suggests is_some_and over map().unwrap_or(false)
2023-06-27 11:29:02 +08:00
y21
26ac76c15f
add it to the methods lint pass
2023-06-18 22:36:08 +02:00
y21
9ab1e8e95c
that was definitely not the right version
2023-06-18 22:27:20 +02:00
y21
c5a9adc2be
new lint: type_id_on_box
2023-06-18 22:20:10 +02:00
y21
5821fbbc30
add test case for not whole length, move sugg into variable
2023-06-15 20:23:12 +02:00
y21
20ae597ec4
add a description
2023-06-15 20:23:12 +02:00
y21
2748ab9565
new lint: drain_collect
2023-06-15 20:23:11 +02:00
Pavan Kumar Sunkara
6e4c5561be
Preserve type annotations when present
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
6e4dc93e24
Support suggesting panics
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
69af0e13b2
Recognize Err
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
7ed7283e0f
Recognize unwrap_or_else method
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
8f83502989
Recognize unwrap_or methods
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
daf6197481
Implement the suggestion
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
21b88ce290
Implement the lint for expect
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
0b1bb5fbf3
Implement the lint
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
2902359b3c
Add the lint to the lib
2023-06-12 16:19:26 +01:00
rsdy
5bb768177e
Add hook
2023-06-12 16:19:26 +01:00
Pavan Kumar Sunkara
e707447a86
Boilerplate for the new lint
2023-06-12 16:19:26 +01:00
xFrednet
c5b974b55d
Update version attribute for 1.70 lints
2023-05-29 00:46:29 +02:00
Jason Newcomb
5351170744
Slightly refactor constant evaluation and add detection for empty macro expansion and cfged statements.
2023-05-18 15:43:33 -04:00
Mick van Gelderen
79eb06c6ec
Remove unnecessary from example
2023-05-15 22:24:37 +02:00
Icxolu
a8834bc46a
add lint manual_next_back
...
checks for manual reverse iteration (`.rev().next()`) of a
`DoubleEndedIterator`
2023-05-11 22:25:14 +02:00
bors
8518391e72
Auto merge of #110806 - WaffleLapkin:unmkI, r=lcnr
...
Replace `tcx.mk_trait_ref` with `TraitRef::new`
First step in implementing https://github.com/rust-lang/compiler-team/issues/616
r? `@lcnr`
2023-05-04 05:54:09 +00:00
Deadbeef
81a614145f
uplift clippy::clone_double_ref as suspicious_double_ref_op
2023-04-28 17:24:48 +00:00
Maybe Waffle
95648951ea
Fix uses of TraitRef::identity in clippy and rustdoc
2023-04-26 13:48:56 +00:00
Philipp Krones
a1b75c5108
Merge commit ' a3ed905928' into clippyup
2023-04-23 13:28:56 +02:00
Philipp Krones
6b95029f17
Merge commit ' 83e42a2337' into clippyup
2023-04-11 15:31:08 +02:00
Philipp Krones
cf8a67d9ad
Merge commit ' 3c06e0b1ce' into clippyup
2023-03-10 10:53:50 +01:00
Jason Newcomb
0413fb35ba
Merge commit ' 149392b0ba' into clippyup
2023-02-25 19:28:50 -05:00
Kyle Matsuda
98c4a49db8
remove bound_type_of query; make type_of return EarlyBinder; change type_of in metadata
2023-02-16 17:05:56 -07:00
Kyle Matsuda
f0565c939e
change usages of type_of to bound_type_of
2023-02-16 17:01:52 -07:00
Philipp Krones
e7fe1f9c14
Merge commit ' 0f7558148c' into clippyup
2023-02-10 14:01:19 +01:00
Camille GILLOT
92c4f1e2d9
Take a LocalDefId in hir::Visitor::visit_fn.
2023-01-28 09:51:50 +00:00
Philipp Krones
5c7a65251a
Merge commit ' 1480cea393' into clippyup
2023-01-27 21:09:08 +01:00
Kyle Matsuda
afb586fa1f
change fn_sig query to use EarlyBinder; remove bound_fn_sig query; add EarlyBinder to fn_sig in metadata
2023-01-26 20:28:25 -07:00
Kyle Matsuda
38899d0c29
replace usages of fn_sig query with bound_fn_sig
2023-01-26 20:15:36 -07:00
Nilstrieb
c617a8e01c
Rename Rptr to Ref in AST and HIR
...
The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already
as well.
2022-12-28 18:52:36 +01:00
Philipp Krones
1c422524c7
Merge commit ' 4bdfb0741d' into clippyup
2022-12-17 14:12:54 +01:00
Philipp Krones
d05e2865a0
Merge commit ' d822110d3b' into clippyup
2022-12-01 18:29:38 +01:00
Philipp Krones
46c5a5d234
Merge commit ' f4850f7292' into clippyup
2022-11-21 20:51:52 +01:00
Nicholas Nethercote
efca32e23a
Rename some OwnerId fields.
...
spastorino noticed some silly expressions like `item_id.def_id.def_id`.
This commit renames several `def_id: OwnerId` fields as `owner_id`, so
those expressions become `item_id.owner_id.def_id`.
`item_id.owner_id.local_def_id` would be even clearer, but the use of
`def_id` for values of type `LocalDefId` is *very* widespread, so I left
that alone.
2022-10-29 20:28:38 +11:00
Vadim Petrochenkov
45c000bbc7
privacy: Rename "accessibility levels" to "effective visibilities"
...
And a couple of other naming tweaks
Related to https://github.com/rust-lang/rust/issues/48054
2022-10-26 16:34:53 +04:00
