Wesley Norris
448d07683a
Allow specifying alignment for functions
2021-04-05 17:36:51 -04:00
Camelid
13076f90d2
Tweak diagnostics
...
- Tweak lint message
- Display multi-segment paths correctly
2021-03-14 14:00:02 -07:00
Camelid
5134047c40
Add hyphen to "crate level"
...
"crate level attribute" -> "crate-level attribute"
2021-03-13 16:29:49 -08:00
Camelid
fe64970ed1
Add another test case
2021-03-13 13:55:15 -08:00
Camelid
7e972a39b8
Report error for each invalid nested attribute
2021-03-13 13:55:15 -08:00
Camelid
7189c05bf8
Lint non-meta doc attributes
...
E.g., `#[doc(123)]`.
2021-03-13 13:25:27 -08:00
Guillaume Gomez
8867f7f650
Rollup merge of #82708 - GuillaumeGomez:doc-test-attr-check, r=Manishearth
...
Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint
Part of #82672 .
This PR does multiple things:
* Create a new `INVALID_DOC_ATTRIBUTE` lint which is also "future incompatible", allowing us to use it as a warning for the moment until it turns (eventually) into a hard error.
* Use this link when `#![doc(test(...))]` isn't used at the crate level.
* Make #82702 use this new lint as well.
r? ``@jyn514``
2021-03-05 21:44:38 +01:00
Guillaume Gomez
a11e87e74d
Make invalid_doc_attribute lint plural
2021-03-05 14:44:31 +01:00
bors
a0d66b54fb
Auto merge of #71481 - estebank:inherit-stability, r=nikomatsakis
...
Inherit `#[stable(..)]` annotations in enum variants and fields from its item
Lint changes for #65515 . The stdlib will have to be updated once this lands in beta and that version is promoted in master.
2021-03-05 05:28:07 +00:00
Guillaume Gomez
55cec9079d
Also use INVALID_DOC_ATTRIBUTE for "unknown doc attribute" warnings
2021-03-04 21:48:07 +01:00
Guillaume Gomez
85c3d102bb
Add tests for #[doc(test(...)] check
2021-03-04 21:24:35 +01:00
Joshua Nelson
4b2e4e69df
Change error about unknown doc attributes to a warning
...
This prevents breakage across the ecosystem, since the error was just
introduced recently without first having a warning period.
2021-03-03 10:04:36 -05:00
Guillaume Gomez
f6de1300b4
Add tests for doc attribute check
2021-03-01 20:26:28 +01:00
Esteban Küber
49310cee30
Add test for "const stability on macro"
2021-02-11 11:30:05 -08:00
Ryan Levick
9f0e1d4921
Add attr-on-params test
2021-02-09 22:17:10 +01:00
Esteban Küber
3b5d018ebb
Handle Spans for byte and raw strings and add more detail
2021-02-03 13:34:28 -08:00
Vadim Petrochenkov
bd07165690
parser: Collect tokens for values in key-value attributes
2021-01-24 17:11:56 +03:00
Mark Rousskov
8a3edb1d66
Update tests for extern block linting
2021-01-13 07:49:16 -05:00
Vadim Petrochenkov
d81c1946c6
resolve/expand: Improve attribute expansion on macro definitions and calls
2021-01-09 18:43:01 +03:00
Vadim Petrochenkov
31d72c2658
Accept arbitrary expressions in key-value attributes at parse time
2020-12-09 21:37:32 +03:00
Vadim Petrochenkov
19dbb02a89
Expand NtExpr tokens only in key-value attributes
2020-11-03 00:53:43 +03:00
Kornel
7ec1de062a
Clarify message about unresolved use
2020-09-01 18:38:14 +01:00
Val Markovic
2155adbc3a
Moving more build-pass tests to check-pass
...
One or two tests became build-pass without the FIXME because they really
needed build-pass (were failing without it).
Helps with #62277
2020-04-23 20:21:38 -07:00
Yuki Okushi
f9c8c49c0b
Use opt_def_id() over def_id()
2020-03-01 15:15:29 +09:00
varkor
24a2929ed1
Normalise notes with the/is
2020-01-24 16:24:50 +00:00
Vadim Petrochenkov
642669c74d
Update tests
2020-01-09 21:23:12 +03:00
Vadim Petrochenkov
5f6267c8b3
resolve: Make visibility resolution more speculative
...
To avoid potential duplicate diagnostics and separate the error reporting logic
2019-12-09 22:41:47 +03:00
Vadim Petrochenkov
9e6725dcfe
resolve: Resolve visibilities on fields with non-builtin attributes
2019-12-09 22:33:23 +03:00
Vadim Petrochenkov
f1359c61d3
expand: Fully preserve visibilities on unnamed fields with attributes
2019-11-24 11:47:46 +03:00
Vadim Petrochenkov
37bb0c7fa6
def_collector: Do not forget to save indices of fields with multiple attributes
2019-11-24 11:47:45 +03:00
Vadim Petrochenkov
83f553c95c
Address review comments
2019-11-09 18:19:34 +03:00
Vadim Petrochenkov
3a223a9173
Support registering attributes and attribute tools using crate-level attributes
2019-11-09 17:50:51 +03:00
David Wood
e79036d17f
hir: Disallow target_feature on constants
...
This commit fixes an ICE when `target_feature` is applied to constants.
Signed-off-by: David Wood <david@davidtw.co>
2019-09-26 16:55:52 +01:00
Vadim Petrochenkov
42a19dde82
resolve: Tweak "cannot find" wording for attributes
2019-09-15 13:10:12 +03:00
Mazdak Farrokhzad
3e4c7786e9
Rollup merge of #64471 - Mark-Simulacrum:warn-depr-attr, r=Centril
...
Warn on no_start, crate_id attribute use
These attributes are now deprecated; they don't have any use anymore.
`no_start` stopped being applicable in 3ee916e50b as part of #18967 . Ideally we would've removed it pre-1.0, but since that didn't happen let's at least mark it deprecated.
`crate_id` was renamed to `crate_name` in 50ee1ec1b4 as part of #15319 . Ideally we would've followed that up with a removal of crate_id itself as well, but that didn't happen; this PR finally marks it as deprecated at least.
Fixes https://github.com/rust-lang/rust/issues/43142 and resolves https://github.com/rust-lang/rust/issues/43144 .
2019-09-15 02:29:46 +02:00
Mark Rousskov
a0e48b6d25
Warn on no_start, crate_id attribute use
...
These attributes are now deprecated; they don't have any use anymore.
2019-09-14 19:43:39 -04:00
Vadim Petrochenkov
fc9f13e424
def_collector: Do not ICE on attributes on unnamed fields
2019-09-14 17:36:39 +03:00
Charles Lew
8acab6bc56
Improve wording.
2019-09-08 09:41:59 +08:00
Vadim Petrochenkov
79f0d88de8
resolve: Use feature(custom_attribute) fallback only if the feature is enabled
...
Normally `#![feature(...)]` shouldn't change behavior, but custom attributes in particular are in the process of retirement, and we should not produce a message telling to enable them.
It also helps with unifying diagnostics for unresolved macros.
2019-07-18 13:42:45 +03:00
Samy Kacimi
41e71b0c93
normalize use of backticks in compiler messages for libsyntax/feature_gate
...
https://github.com/rust-lang/rust/issues/60532
2019-07-09 14:13:28 +02:00
Mazdak Farrokhzad
0224532493
Rollup merge of #62133 - petrochenkov:norustc, r=eddyb
...
Feature gate `rustc` attributes harder
Fixes https://github.com/rust-lang/rust/issues/62116
2019-07-05 20:26:54 +02:00
Yuki Okushi
c004451a20
Migrate compile-pass annotations to build-pass
2019-07-03 06:30:28 +09:00
Vadim Petrochenkov
0ffb6438a6
Make sure #[rustc_doc_only_macro] and other rustc attributes are registered
2019-06-30 12:47:33 +03:00
Vadim Petrochenkov
ee189ae028
Address review comments
2019-06-09 00:08:53 +03:00
Vadim Petrochenkov
8e8ab49bca
Move some run-pass attribute tests to ui
2019-06-08 23:55:25 +03:00