Tyler Mandry
5ac47b1268
Rollup merge of #76154 - GuillaumeGomez:strings-indent, r=jyn514
...
Fix rustdoc strings indentation
I took the opportunity to clean up our strings indentation a bit because it was a bit messy.
r? @jyn514
2020-08-31 19:18:22 -07:00
Guillaume Gomez
b741cc5b7d
Fix string
2020-08-31 17:07:25 +02:00
Guillaume Gomez
c9a48d1d73
Fix strings indent
2020-08-31 13:16:50 +02:00
Aleksey Kladov
300d7f661a
Rollup merge of #76052 - aszenz:GH-66816_removes_disable_attribute_before_return, r=GuillaumeGomez
...
GH-66816: Remove disable attr before return
Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled
first before the function returns.
Fixes #66816
2020-08-31 12:51:46 +02:00
bors
99b4a01776
Auto merge of #75901 - GuillaumeGomez:ayu-theme-button-hover-background-color, r=pickfire
...
Improve theme button hover background color
Fixes #75880 .
r? @pickfire
2020-08-30 04:43:09 +00:00
bors
62850d882b
Auto merge of #76090 - Dylan-DPC:rollup-eksndcr, r=Dylan-DPC
...
Rollup of 14 pull requests
Successful merges:
- #75832 (Move to intra-doc links for wasi/ext/fs.rs, os_str_bytes.rs…)
- #75852 (Switch to intra-doc links in `core::hash`)
- #75874 (Shorten liballoc doc intra link while readable)
- #75881 (Expand rustdoc theme chooser x padding)
- #75885 (Fix another clashing_extern_declarations false positive.)
- #75892 (Fix typo in TLS Model in Unstable Book)
- #75910 (Add test for issue #27130 )
- #75917 (Move to intra doc links for core::ptr::non_null)
- #75975 (Allow --bess ing expect-tests in tools)
- #75990 (Add __fastfail for Windows on arm/aarch64)
- #76015 (Fix loading pretty-printers in rust-lldb script)
- #76022 (Clean up rustdoc front-end source code)
- #76029 (Move to intra-doc links for library/core/src/sync/atomic.rs)
- #76057 (Move retokenize hack to save_analysis)
Failed merges:
r? @ghost
2020-08-30 00:47:37 +00:00
Dylan DPC
b1f983a582
Rollup merge of #76022 - GuillaumeGomez:cleanup-rustdoc-front, r=jyn514
...
Clean up rustdoc front-end source code
r? @jyn514
2020-08-30 01:43:57 +02:00
Dylan DPC
f35eb5cced
Rollup merge of #75881 - pickfire:patch-5, r=GuillaumeGomez
...
Expand rustdoc theme chooser x padding
But I still think there is room for improvement considering mdbook.
CC @GuillaumeGomez @jyn514
2020-08-30 01:43:42 +02:00
bors
ced37a53d9
Auto merge of #75775 - matklad:rustc-lexer-rustdoc-highlight, r=GuillaumeGomez
...
Use rustc_lexer for rustdoc syntax highlighting
r? @ghost
2020-08-29 22:42:08 +00:00
Guillaume Gomez
3a4ef0f57d
Use an id instead of a function
2020-08-29 12:38:50 +02:00
asrar
eb2bb99021
GH-66816: Process before enabling search
2020-08-29 10:19:58 +00:00
asrar
7ee515579e
GH-66816: Removes disable before return
...
Passing --disable-per-crate-search removes the create search
inputs so moved code around so that the search input is enabled
first before the function returns
2020-08-29 09:33:41 +00:00
Guillaume Gomez
4b8ebbcc5a
Clean up rustdoc front-end source code
2020-08-28 13:30:21 +02:00
Pietro Albini
efd81b435b
Rollup merge of #75989 - matklad:renamerustdoctest, r=GuillaumeGomez
...
Rename rustdoc/test -> rustdoc/doctest
This modules contains the implementation of doctests, and not the
tests of rustdoc itself. This name is confusing, so let's rename it to
doctest for clarity.
2020-08-28 10:24:07 +02:00
Pietro Albini
8730c2beb7
Rollup merge of #75330 - Nemo157:improve-doc-cfg-features, r=GuillaumeGomez
...
Improve rendering of crate features via doc(cfg)
The current rendering of crate features with `doc(cfg(feature = ".."))` is verbose and unwieldy for users, `doc(cfg(target_feature = ".."))` is special-cased to make it render nicely, and a similar rendering can be applied to `doc(cfg(feature))` to make it easier for users to read.
I also added special casing of `all`/`any` cfgs consisting of just `feature`/`target-feature` to remove the repetitive "target/crate feature" prefix.
The downside of this current rendering is that there is no distinction between `feature` and `target_feature` in the shorthand display. IMO this is ok, or if anything `target_feature` should have a more verbose shorthand, because `doc(cfg(feature = ".."))` usage is going to vastly outstrip `doc(cfg(target_feature = ".."))` usage in non-stdlib crates when it eventually stabilizes (or even before that given the number of crates using `cfg_attr(docsrs)` like constructs).
## Previously
<img width="259" alt="Screenshot 2020-08-09 at 13 32 42" src="https://user-images.githubusercontent.com/81079/89731110-d090c000-da44-11ea-96fa-56adc6339123.png ">
<img width="438" alt="image" src="https://user-images.githubusercontent.com/81079/89731116-d7b7ce00-da44-11ea-87c6-022d192d6eca.png ">
<img width="765" alt="image" src="https://user-images.githubusercontent.com/81079/89731152-24030e00-da45-11ea-9552-1c270bff2729.png ">
<img width="671" alt="image" src="https://user-images.githubusercontent.com/81079/89731158-28c7c200-da45-11ea-8acb-97d8a4ce00eb.png ">
## Now
<img width="216" alt="image" src="https://user-images.githubusercontent.com/81079/89731123-e1d9cc80-da44-11ea-82a8-5900bd9448a5.png ">
<img width="433" alt="image" src="https://user-images.githubusercontent.com/81079/89731127-e8684400-da44-11ea-9d18-572fd810f19f.png ">
<img width="606" alt="image" src="https://user-images.githubusercontent.com/81079/89731162-2feed000-da45-11ea-98d2-8a88c364d903.png ">
<img width="669" alt="image" src="https://user-images.githubusercontent.com/81079/89731991-ccb46c00-da4b-11ea-9416-cd20a3193826.png ">
cc #43781
2020-08-28 10:23:53 +02:00
bors
397b390cc7
Auto merge of #75976 - GuillaumeGomez:help-popup, r=jyn514
...
Improve help popup
Fixes #75623 .
The second commit is just a slight improvement: the help popup won't be created until someone presses "?" or ESC. Not a big improvement in itself but considering the low amount of code required, I think it was worth the shot.
r? @jyn514
2020-08-27 21:30:32 +00:00
Aleksey Kladov
b4f4db946e
Add expect test for rustdoc html highlighting
...
It's a unit-test in a sense that it only checks syntax highlighting.
However, the resulting HTML is written to disk and can be easily
inspected in the browser.
To update the test, run with `--bless` argument or set
`UPDATE_EXPEC=1` env var
2020-08-27 18:48:06 +02:00
Aleksey Kladov
df975cf9c2
Rename rustdoc/test -> rustdoc/doctest
...
This modules contains the implementation of doctests, and not the
tests of rustdoc itself. This name is confusing, so let's rename it to
doctest for clarity.
2020-08-27 18:21:25 +02:00
Aleksey Kladov
1f95a91c24
Remove dependency on StringReader from rustdoc highlighter
...
rustc_lexer is the lossless lexer, which is a better fit for
approximate syntax highlighting.
As a side-effect, we can now syntax-highlight even broken code.
2020-08-27 17:43:15 +02:00
Guillaume Gomez
86e42c2742
Delay help popup creation to when it's needed
2020-08-27 14:22:54 +02:00
Guillaume Gomez
1727c7a194
Improve helper wording
2020-08-27 14:22:54 +02:00
bors
18b0585b52
Auto merge of #75842 - camelid:highlight-crate-links, r=jyn514
...
Highlight crate links like normal links
Fixes #75823 .
Cc @jyn514
2020-08-27 02:51:01 +00:00
Dylan DPC
c1cb46e906
Rollup merge of #75870 - GuillaumeGomez:unify-border-color-theme-ayu, r=pickfire
...
Unify theme choices border color in ayu theme
There was a slight color difference in the theme choice menu borders:
r? @Cldfire
2020-08-27 01:14:15 +02:00
Dylan DPC
88c68cae4f
Rollup merge of #75837 - GuillaumeGomez:fix-font-color-help-button, r=Cldfire
...
Fix font color for help button in ayu and dark themes
A nice before/after:
For the ayu theme, the change is very "light", the font color was already close to white, so I unified the color with the pictures of the other buttons:
2020-08-27 01:14:13 +02:00
Dylan DPC
463fdf3e04
Rollup merge of #75806 - GuillaumeGomez:prevent-automatic-page-change-history, r=pickfire
...
Prevent automatic page change when using history
Fixes #75774 .
2020-08-27 01:14:08 +02:00
Guillaume Gomez
f20f7f2267
Improve theme button hover background color
2020-08-25 13:48:47 +02:00
Ivan Tham
8e0e179776
Expand rustdoc theme chooser x padding
2020-08-24 22:32:59 +08:00
Guillaume Gomez
76bd5b3852
Add explanations on the results search element check
2020-08-24 12:59:16 +02:00
Guillaume Gomez
efef159c55
Unify theme choices border color in ayu theme
2020-08-24 10:38:28 +02:00
Camelid
4419e04f16
Highlight crate links like normal links
2020-08-23 10:24:19 -07:00
Guillaume Gomez
5041aeef3d
Fix font color for help button in ayu and dark themes
2020-08-23 15:17:50 +02:00
Guillaume Gomez
6cb364cda4
Prevent automatic page change when using history
2020-08-23 14:39:43 +02:00
Joshua Nelson
a97d65d6e4
rustdoc: Rename misleading function
...
- `is_associated` -> `is_type_alias`
`is_associated` is not a good name for what this is doing. If you look at
https://github.com/rust-lang/rust/pull/74489/files#diff-6a301d597807ee441a41e7237800563dR296 ,
is_associated() and as_assoc_kind() do completely different things, but
from the name it sounds like they're similar.
2020-08-22 00:22:43 -04:00
Yuki Okushi
98f7d882c8
Rollup merge of #75665 - GuillaumeGomez:doc-examples-coverage, r=jyn514
...
Add doc examples coverage
r? @jyn514
2020-08-19 15:54:37 +09:00
Wim Looman
3328bd9a0f
Add long cfg description to tooltip on short description
2020-08-18 22:35:50 +02:00
Guillaume Gomez
d9d84dca8e
Add doc examples count for --show-coverage
2020-08-18 13:31:23 +02:00
Bastian Kauschke
cd53760cc7
merge as_local_hir_id with local_def_id_to_hir_id
2020-08-13 16:55:16 +02:00
Tyler Mandry
a4211977d7
Rollup merge of #75393 - GuillaumeGomez:fix-help-shortcut, r=pickfire
...
Fully handle "?" shortcut
Fixes #75386 .
cc @runiq
2020-08-11 12:28:34 -07:00
Tyler Mandry
c18b64c866
Rollup merge of #75378 - petrochenkov:isident, r=Mark-Simulacrum
...
Introduce `rustc_lexer::is_ident` and use it in couple of places
Implements the suggestion from https://github.com/rust-lang/rust/pull/74537#issuecomment-662261979 .
2020-08-11 12:28:32 -07:00
Guillaume Gomez
fdf2fe18a1
Fully handle "?" shortcut
2020-08-11 18:28:01 +02:00
Yuki Okushi
a75bdfa230
Rollup merge of #75347 - fusion-engineering-forks:rustdoc-nat-sort, r=GuillaumeGomez
...
Rustdoc: Fix natural ordering to look at all numbers.
The old implementation only looks at numbers at the end, but not in other places in a name: `u8` and `u16` got sorted properly, but `u8_bla` and `u16_bla` did not.
2020-08-11 16:23:52 +09:00
Dylan DPC
51ed33d8c2
Rollup merge of #75366 - GuillaumeGomez:help-button, r=jyn514
...
Add help button
Part of #75197 .
Here is a screenshot of the result:
r? @jyn514
2020-08-11 01:56:43 +02:00
Dylan DPC
2ad7c1687f
Rollup merge of #75249 - GuillaumeGomez:rust-logo-border, r=Manishearth
...
Only add a border for the rust logo
I didn't add a border for the light theme though, as I felt it as unnecessary.
r? @Manishearth
2020-08-11 01:56:32 +02:00
Mark Rousskov
6bbf4558ac
Feature gate is always present
2020-08-11 00:08:04 +03:00
Guillaume Gomez
a34bc7961a
Add help button
2020-08-10 16:52:19 +02:00
Mara Bos
8c705f83db
Rustdoc: Fix natural ordering to look at all numbers.
...
The old implementation only looks at numbers at the end, but not in
other places in a name: "u8" and "u16" got sorted properly, but "u8_bla"
and "u16_bla" did not.
2020-08-09 23:05:35 +02:00
Camelid
f3cc957f2e
Rename "Important traits" to "Notable traits"
...
* Rename it in the UI
* Rename the CSS classes
2020-08-09 12:09:05 -07:00
Nicholas Nethercote
e539dd65f8
Eliminate the SessionGlobals from librustc_ast.
...
By moving `{known,used}_attrs` from `SessionGlobals` to `Session`. This
means they are accessed via the `Session`, rather than via TLS. A few
`Attr` methods and `librustc_ast` functions are now methods of
`Session`.
All of this required passing a `Session` to lots of functions that didn't
already have one. Some of these functions also had arguments removed, because
those arguments could be accessed directly via the `Session` argument.
`contains_feature_attr()` was dead, and is removed.
Some functions were moved from `librustc_ast` elsewhere because they now need
to access `Session`, which isn't available in that crate.
- `entry_point_type()` --> `librustc_builtin_macros`
- `global_allocator_spans()` --> `librustc_metadata`
- `is_proc_macro_attr()` --> `Session`
2020-08-08 12:03:42 +10:00
Guillaume Gomez
48a6c2125b
Only add a border for the rust logo
2020-08-07 11:19:07 +02:00
Vadim Petrochenkov
0a88346be6
rustc_ast: (Nested)MetaItem::check_name -> has_name
...
For consistency with `Attribute::has_name` which doesn't mark the attribute as used either.
Replace all uses of `check_name` with `has_name` outside of rustc
2020-08-04 00:34:11 +03:00
