Alex Macleod
e88a556124
Reuse rustdoc's doc comment handling in Clippy
2023-09-08 23:42:57 +00:00
Philipp Krones
cc61aeea54
Merge commit ' 080b587854' into clippyup
2023-08-24 21:32:12 +02:00
Philipp Krones
f730a2655a
Merge commit ' 1e8fdf4928' into clippyup
2023-08-11 14:05:13 +02:00
Philipp Krones
b0e64a9c09
Merge commit ' 5436dba826' into clippyup
2023-07-31 23:53:53 +02:00
Philipp Krones
d6d530fd0b
Merge commit ' d9c24d1b1e' into clippyup
2023-07-17 10:22:32 +02:00
Urgau
103949b241
Drop uplifted clippy::fn_null_check
2023-07-10 18:12:41 +02:00
Philipp Krones
cb3ecf7b79
Merge commit ' 37f4c1725d' into clippyup
2023-07-02 14:59:02 +02:00
Philipp Krones
e6dc0efc00
Merge commit ' 30448e8cf9' into clippyup
2023-06-02 11:41:57 +02:00
Urgau
5a2094319b
Drop uplifted clippy::invalid_utf8_in_unchecked
2023-05-27 00:16:47 +02:00
Philipp Krones
b76b0aeb63
Merge commit ' 435a8ad86c' into clippyup
2023-05-20 15:39:26 +02:00
Philipp Krones
7e9abb311d
Merge commit ' 371120bdbf' into clippyup
2023-05-05 17:45:49 +02:00
Nicholas Nethercote
431cce1540
Restrict From<S> for {D,Subd}iagnosticMessage.
...
Currently a `{D,Subd}iagnosticMessage` can be created from any type that
impls `Into<String>`. That includes `&str`, `String`, and `Cow<'static,
str>`, which are reasonable. It also includes `&String`, which is pretty
weird, and results in many places making unnecessary allocations for
patterns like this:
```
self.fatal(&format!(...))
```
This creates a string with `format!`, takes a reference, passes the
reference to `fatal`, which does an `into()`, which clones the
reference, doing a second allocation. Two allocations for a single
string, bleh.
This commit changes the `From` impls so that you can only create a
`{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static,
str>`. This requires changing all the places that currently create one
from a `&String`. Most of these are of the `&format!(...)` form
described above; each one removes an unnecessary static `&`, plus an
allocation when executed. There are also a few places where the existing
use of `&String` was more reasonable; these now just use `clone()` at
the call site.
As well as making the code nicer and more efficient, this is a step
towards possibly using `Cow<'static, str>` in
`{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing
the `From<&'a str>` impls to `From<&'static str>`, which is doable, but
I'm not yet sure if it's worthwhile.
2023-05-03 08:44:39 +10:00
Philipp Krones
a1b75c5108
Merge commit ' a3ed905928' into clippyup
2023-04-23 13:28:56 +02:00
Philipp Krones
6b95029f17
Merge commit ' 83e42a2337' into clippyup
2023-04-11 15:31:08 +02:00
Trevor Gross
4cf5bdc60c
Stabilize a portion of 'once_cell'
...
Move items not part of this stabilization to 'lazy_cell' or 'once_cell_try'
2023-03-29 18:04:44 -04:00
Philipp Krones
8df896c076
Merge commit ' d5e2a7aca5' into clippyup
2023-03-24 14:26:19 +01:00
Philipp Krones
cf8a67d9ad
Merge commit ' 3c06e0b1ce' into clippyup
2023-03-10 10:53:50 +01:00
Alex Macleod
64b54ef950
Fix array-size-threshold config deserialization error
2023-03-02 21:42:11 +01:00
Jason Newcomb
0413fb35ba
Merge commit ' 149392b0ba' into clippyup
2023-02-25 19:28:50 -05:00
Nicholas Nethercote
71b8646854
Use ThinVec in various AST types.
...
This commit changes the sequence parsers to produce `ThinVec`, which
triggers numerous conversions.
2023-02-21 11:51:56 +11:00
Philipp Krones
e7fe1f9c14
Merge commit ' 0f7558148c' into clippyup
2023-02-10 14:01:19 +01:00
Scott McMurray
e65a7ff0b3
Remove from librustdoc and clippy too
2023-01-27 20:44:19 -08:00
Philipp Krones
5c7a65251a
Merge commit ' 1480cea393' into clippyup
2023-01-27 21:09:08 +01:00
Philipp Krones
d21616737b
Merge commit ' 7f27e2e74e' into clippyup
2023-01-12 19:48:13 +01:00
Philipp Krones
4ccafea92d
Merge commit ' 4f3ab69ea0' into clippyup
2022-12-29 14:28:34 +01:00
Philipp Krones
1c422524c7
Merge commit ' 4bdfb0741d' into clippyup
2022-12-17 14:12:54 +01:00
Philipp Krones
d05e2865a0
Merge commit ' d822110d3b' into clippyup
2022-12-01 18:29:38 +01:00
hkalbasi
0aaea40eb2
move some layout logic to rustc_target::abi::layout
2022-11-24 16:26:12 +03:30
Philipp Krones
46c5a5d234
Merge commit ' f4850f7292' into clippyup
2022-11-21 20:51:52 +01:00
flip1995
cd0bb7de01
Merge commit ' 4f142aa105' into clippyup
2022-10-23 15:18:45 +02:00
lcnr
059e52b96b
rustc_hir_typeck: fix clippy
2022-10-20 17:53:14 +02:00
Philipp Krones
d75b25faab
Merge commit ' ac0e10aa68' into clippyup
2022-10-06 09:44:38 +02:00
lcnr
e5ce6d18df
rustc_typeck to rustc_hir_analysis
2022-09-27 10:37:23 +02:00
Pietro Albini
06568fd6c7
remove cfg(bootstrap)
2022-09-26 10:14:45 +02:00
David Koloski
4d015293d1
Merge commit ' 7248d06384' into sync-from-clippy
2022-09-21 13:13:27 -04:00
est31
2be8b73328
Fix clippy
2022-09-15 21:21:18 +02:00
Philipp Krones
98bf99e2f8
Merge commit ' b52fb5234c' into clippyup
2022-09-09 13:36:26 +02:00
Jason Newcomb
abd3e7eabb
Allow lint passes to be bound by TyCtxt
2022-09-06 14:23:03 -04:00
Jason Newcomb
fb41bfa774
Merge commit ' f51aade56f' into clippyup
2022-08-31 09:24:45 -04:00
Nilstrieb
ce847beb47
Revert let_chains stabilization
...
This reverts commit 3266460749#100538 .
2022-08-29 19:34:11 +02:00
Mark Rousskov
1a3192a331
Adjust cfgs
2022-08-12 16:28:15 -04:00
Philipp Krones
dc29cfb8d5
Merge commit ' 2b2190cb56' into clippyup
2022-08-11 19:42:16 +02:00
Philipp Krones
67c405cc1d
Merge commit ' 3c7e7dbc15' into clippyup
2022-07-28 19:08:22 +02:00
Philipp Krones
7d4daaa8fa
Merge commit ' fdb84cbfd2' into clippyup
2022-07-18 09:39:37 +02:00
Caio
f88a1399bb
Stabilize let_chains
2022-07-16 20:17:58 -03:00
Philipp Krones
09f5df5087
Merge commit ' 0cb0f76368' into clippyup
2022-06-30 10:50:09 +02:00
flip1995
f8f9d01c2a
Merge commit ' d7b5cbf065' into clippyup
2022-06-16 17:39:06 +02:00
Philipp Krones
f067783461
Merge commit ' d9ddce8a22' into clippyup
2022-06-04 13:34:07 +02:00
xFrednet
4587b6628d
Merge 'rust-clippy/master' into clippyup
2022-05-21 13:24:00 +02:00
Preston From
41c7e4d382
Lint for significant drops who may have surprising lifetimes #1
...
author Preston From <prestonfrom@gmail.com> 1645164142 -0600
committer Preston From <prestonfrom@gmail.com> 1650005351 -0600
2022-05-06 21:48:17 -06:00
