Devon Hollowood
6c89c00a98
Further clean up tests/ui/rename.rs
...
Now it is just a collection of lints + an empty main function
2021-10-26 10:26:35 -07:00
Devon Hollowood
d0c04b4d78
Clean up tests/ui/rename.rs
2021-10-26 00:53:53 -07:00
bors
df65291edd
Auto merge of #7856 - Manishearth:impl-safety, r=xFrednet
...
missing_safety_doc: Handle 'implementation safety' headers as well
We hit some FPs on this in `yoke`, it's somewhat normal to mark trait impl safety with "implementation safety". We could also broaden the check for headers which contain the word "safety" somehow, or split out impl safety stuff to only apply to traits.
changelog: handle 'implementation safety' headers in `missing_safety_doc`
2021-10-21 21:51:24 +00:00
bors
2ba1a6a331
Auto merge of #7801 - aDotInTheVoid:empty-format, r=camsteffen
...
Make useless_format recognize format!("")
Closes #7796
changelog: [`useless_format`] Fix for false negitive for `format!("")`
2021-10-21 18:15:23 +00:00
bors
c97a06d9af
Auto merge of #7850 - ThibsG:PossibleCastTruncation5395, r=camsteffen
...
Fix FP: no lint when cast is coming from `signum` method call for `cast_possible_truncation` lint
Fixes a FP when cast is coming from `signum` method call
fixes : #5395
changelog: [`cast_possible_truncation`] Fix FP when cast is coming from `signum` method call
2021-10-21 18:01:39 +00:00
Nixon Enraght-Moony
081d0f82f4
Make useless_format recognize format!("")
...
Closes #7796
2021-10-21 19:01:28 +01:00
ThibsG
566244a8bc
Do not lint when cast is coming from signum method call
2021-10-21 19:15:26 +02:00
Manish Goregaokar
1e8d9fb18c
Handle 'implementation safety' headers as well
2021-10-21 08:50:50 -07:00
flip1995
085181e29d
Merge remote-tracking branch 'upstream/master' into rustup
2021-10-21 12:18:12 +02:00
bors
300b821d51
Auto merge of #7838 - nhamovitz:trailing_zs_arr_wo_repr, r=Manishearth
...
Warn on structs with a trailing zero-sized array but no `repr` attribute
Closes #2868
changelog: Implement ``[`trailing_empty_array`]``, which warns if a struct is defined where the last field is a zero-sized array but there are no `repr` attributes. Zero-sized arrays aren't very useful in Rust itself, so such a struct is likely being created to pass to C code or in some other situation where control over memory layout matters. Either way, a `repr` attribute is needed.
2021-10-20 20:35:58 +00:00
bors
f11905af15
Auto merge of #7849 - ThibsG:SafetyDoc, r=llogiq
...
FIx FP in `missing_safety_doc` lint
Fix FP where lint souldn't fire if any parent has `#[doc(hidden)]` attribute
fixes : #7347
changelog: [`missing_safety_doc`] Fix FP if any parent has `#[doc(hidden)]` attribute
2021-10-20 16:46:38 +00:00
ThibsG
3630afb57f
Do not lint if any parent has hidden attribute
2021-10-20 17:53:05 +02:00
bors
06722c0c15
Auto merge of #7775 - F3real:no_effect, r=xFrednet
...
Detect underscored variables with no side effects
Fixes #7545
changelog: Lint on underscored variables with no side effects in [`no_effect`]
2021-10-20 09:33:45 +00:00
F3real
6b22bba902
Lint on underscore variable assignment
...
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
2021-10-20 00:39:28 +02:00
Nathaniel Hamovitz
0f9f591e30
Rename lint
2021-10-19 14:33:43 -07:00
Nathaniel Hamovitz
60da4c9cb6
remove resolved note
2021-10-19 14:23:55 -07:00
dswij
3fc99b6a33
Update test for question_mark to cover Result
2021-10-19 18:50:49 +08:00
Nathaniel Hamovitz
c654cc56da
One more test + final tidying
2021-10-18 17:41:27 -07:00
Nathaniel Hamovitz
6303d2d075
Revert "!: this is the commit that demonstrates the ICE"
...
This reverts commit d85f903c91
2021-10-18 17:18:07 -07:00
Nathaniel Hamovitz
d85f903c91
!: this is the commit that demonstrates the ICE
2021-10-18 17:07:51 -07:00
Nathaniel Hamovitz
ab9fa25e82
Better testcase names
2021-10-18 04:59:03 -07:00
Nathaniel Hamovitz
d25b4eeefb
One more test
2021-10-18 04:22:43 -07:00
Nathaniel Hamovitz
5b78907be7
Still renaming lmao
2021-10-18 03:56:49 -07:00
Nathaniel Hamovitz
a6aa9864a3
Rename stderr
2021-10-18 03:52:37 -07:00
Nathaniel Hamovitz
7f84e3d791
Rename lint
2021-10-18 03:45:08 -07:00
Nathaniel Hamovitz
6377fb2fe7
Tidy import + update expected stderr
2021-10-18 03:13:48 -07:00
Nathaniel Hamovitz
c5d3167a23
update testsuite and expand if_chain
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
a3420f7004
Tidy comments + tests; revert 'size-is-zero' detection
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
9b3f55ee61
tried to simplify but it doesn't work :/
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
5fdf93415b
intermediate step
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
003972f428
add multiple get_attrs and includes_repr and they all work!
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
b9948c4be6
Ran dev bless!
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
4b4db59772
output looks fantastic
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
e53a4da4a1
it works i think (incl some dbgs)
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
7ee8e7a9b8
Implement detecting trailing zero-sized array
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
c69387a0d5
Well it builds
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
797507c583
Add boilerplate and basic tests
2021-10-18 03:05:18 -07:00
Matthias Krüger
79b73ac98d
Rollup merge of #89963 - r00ster91:parenthesisparentheses, r=nagisa
...
Some "parenthesis" and "parentheses" fixes
"Parenthesis" is the singular (e.g. one `(` or one `)`) and "parentheses" is the plural (multiple `(` or `)`s) and this is not hard to mix up so here are some fixes for that.
Inspired by #89958
2021-10-17 18:18:59 +02:00
Paul Gey
a550133b8f
Fix false positive of implicit_saturating_sub with else clause
...
Fixes #7831
2021-10-17 15:56:59 +02:00
r00ster91
599d9126a2
Some "parenthesis" and "parentheses" fixes
2021-10-17 12:04:01 +02:00
bors
e1871ba0da
Auto merge of #7743 - smoelius:master, r=camsteffen
...
Add `format_in_format_args` and `to_string_in_format_args` lints
Fixes #7667 and #7729
I put these in `perf` since that was one of `@jplatte's` suggestions, and `redundant_clone` (which I consider to be similar) lives there as well.
However, I am open to changing the category or anything else.
r? `@camsteffen`
changelog: Add `format_in_format_args` and `to_string_in_format_args` lints
2021-10-15 17:05:13 +00:00
Samuel E. Moelius III
47014d81a1
Fix adjacent tests
2021-10-15 12:44:49 -04:00
Samuel E. Moelius III
c9599d79a3
Add format_in_format_args and to_string_in_format_args lints
...
Fixes #7667 and #7729
2021-10-15 12:44:38 -04:00
bors
db403bb889
Auto merge of #7823 - mikerite:match-overlapping-arm-20211015, r=xFrednet
...
Some small improvements to the `match_overlapping_arm` tests
changelog: none
2021-10-15 12:42:16 +00:00
dswij
e4ac4c2e1a
Add test on unnecessary_sort_by when argument does not implement Ord
2021-10-15 18:12:47 +08:00
Cameron Steffen
0a23fff82d
Fix clippy with changed macro statement spans
2021-10-15 02:36:58 -05:00
Michael Wright
28a249b53e
Add unbounded pats to match_overlapping_arm tests
2021-10-15 06:25:11 +02:00
Michael Wright
e664a76add
Refactor overlapping arm tests
...
Make the `println!`s match the patterns. Currently they are using the
deprecated syntax for inclusive ranges and extra spacing.
2021-10-15 06:20:28 +02:00
bors
b9b11a96d2
Auto merge of #7805 - aDotInTheVoid:transmute-num-bits, r=camsteffen
...
Add lint transmute_num_to_bytes
Closes #7803
changelog: [`transmute_num_to_bytes`] new lint
2021-10-13 19:40:33 +00:00
Nixon Enraght-Moony
58969807ab
Add lint transmute_num_to_bytes
...
Closes #7803
changelog: [`transmute_num_to_bytes`] new lint
2021-10-13 20:05:05 +01:00
